iio: Mark iio_dev as const in getter methods

Commit Message

Jorge Marques March 3, 2025, 2:46 p.m. UTC

get_current_scan_type read-only method allows to support multiple
scan types per channel, which may also depend on a buffer enabled state.
Mark iio_dev as const in iio_device_id, iio_device_get_current_mode,
iio_buffer_enabled read-only methods so they can be used from other
read-only methods.

Signed-off-by: Jorge Marques <[e-mail]>
---
 drivers/iio/industrialio-core.c | 6 +++---
 include/linux/iio/iio.h         | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)


---
base-commit: 7eb172143d5508b4da468ed59ee857c6e5e01da6
change-id: 20250303-b4-iio-dev-const-cc26bac40292

Best regards,

Comments

Jonathan Cameron March 5, 2025, 12:56 p.m. UTC | #1

On Mon, 3 Mar 2025 15:46:25 +0100
Jorge Marques <[e-mail]> wrote:

> get_current_scan_type read-only method allows to support multiple
> scan types per channel, which may also depend on a buffer enabled state.
> Mark iio_dev as const in iio_device_id, iio_device_get_current_mode,
> iio_buffer_enabled read-only methods so they can be used from other
> read-only methods.
> 
> Signed-off-by: Jorge Marques <[e-mail]>

Hi Jorge,

I'm not against this, but I would like to see this patch as part of
a series that uses it from a read-only method.

Until then this looks like noise unless there is other reasoning.

Thanks,

Jonathan

Patch

diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
index a2117ad1337d55468c0f21c274fcbedd352c97ff..3b743cc1af6a15c5b9828e2c54d89ab8abb5524d 100644
--- a/drivers/iio/industrialio-core.c
+++ b/drivers/iio/industrialio-core.c
@@ -197,7 +197,7 @@  static const char * const iio_chan_info_postfix[] = {
  *
  * Returns: Unique ID for the device.
  */
-int iio_device_id(struct iio_dev *indio_dev)
+int iio_device_id(const struct iio_dev *indio_dev)
 {
 	struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
 
@@ -211,7 +211,7 @@  EXPORT_SYMBOL_GPL(iio_device_id);
  *
  * Returns: True, if the buffer is enabled.
  */
-bool iio_buffer_enabled(struct iio_dev *indio_dev)
+bool iio_buffer_enabled(const struct iio_dev *indio_dev)
 {
 	struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
 
@@ -2227,7 +2227,7 @@  EXPORT_SYMBOL_GPL(iio_device_release_buffer_mode);
  *				   the opaque @currentmode variable
  * @indio_dev:			   IIO device structure for device
  */
-int iio_device_get_current_mode(struct iio_dev *indio_dev)
+int iio_device_get_current_mode(const struct iio_dev *indio_dev)
 {
 	struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
 
diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
index 56161e02f002cbe3a835cefce0e702c0f9776c81..b9ddfdeaef64dc5df687eac44d3f968bed2fde8e 100644
--- a/include/linux/iio/iio.h
+++ b/include/linux/iio/iio.h
@@ -627,9 +627,9 @@  struct iio_dev {
 	void				*__private priv;
 };
 
-int iio_device_id(struct iio_dev *indio_dev);
-int iio_device_get_current_mode(struct iio_dev *indio_dev);
-bool iio_buffer_enabled(struct iio_dev *indio_dev);
+int iio_device_id(const struct iio_dev *indio_dev);
+int iio_device_get_current_mode(const struct iio_dev *indio_dev);
+bool iio_buffer_enabled(const struct iio_dev *indio_dev);
 
 const struct iio_chan_spec
 *iio_find_channel_from_si(struct iio_dev *indio_dev, int si);