| Message ID | 20250305234949.1548646-1-danascape@gmail.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [v2] staging: iio: adis16203: Remove unneeded spi_set_drvdata() | expand |
Sorry, I forgot to add a V2 description V1 -> V2: Update commit message description Sincerely, Saalim Quadri
On Thu, 6 Mar 2025 05:19:49 +0530 Saalim Quadri <danascape@gmail.com> wrote: > By making use of devm_iio_device_register(), we no longer have a driver > remove callback. > Since this was the last user of spi_get_drvdata(), > we can drop the call to spi_set_drvdata(). > > Signed-off-by: Saalim Quadri <danascape@gmail.com> As per other discussion. Dropping this one as better to merge support into the adis16201 driver. > --- > drivers/staging/iio/accel/adis16203.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c > index c1c73308800c..3faf3c61046a 100644 > --- a/drivers/staging/iio/accel/adis16203.c > +++ b/drivers/staging/iio/accel/adis16203.c > @@ -267,8 +267,6 @@ static int adis16203_probe(struct spi_device *spi) > if (!indio_dev) > return -ENOMEM; > st = iio_priv(indio_dev); > - /* this is only used for removal purposes */ > - spi_set_drvdata(spi, indio_dev); > > indio_dev->name = spi->dev.driver->name; > indio_dev->channels = adis16203_channels;
diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c index c1c73308800c..3faf3c61046a 100644 --- a/drivers/staging/iio/accel/adis16203.c +++ b/drivers/staging/iio/accel/adis16203.c @@ -267,8 +267,6 @@ static int adis16203_probe(struct spi_device *spi) if (!indio_dev) return -ENOMEM; st = iio_priv(indio_dev); - /* this is only used for removal purposes */ - spi_set_drvdata(spi, indio_dev); indio_dev->name = spi->dev.driver->name; indio_dev->channels = adis16203_channels;
By making use of devm_iio_device_register(), we no longer have a driver remove callback. Since this was the last user of spi_get_drvdata(), we can drop the call to spi_set_drvdata(). Signed-off-by: Saalim Quadri <danascape@gmail.com> --- drivers/staging/iio/accel/adis16203.c | 2 -- 1 file changed, 2 deletions(-)