From patchwork Sun Mar 9 17:06:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 14008672 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C5444A0C for ; Sun, 9 Mar 2025 17:07:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741540068; cv=none; b=B0koXCMll/5xpUoTHEHuZmuD6KeIl3DcHtGNX93Uf/yqSad6dJb6F1Jk24Y4jFxGfTGXNreXGpI9whlBUnH7JxK9XiBJ42dtOTUAVA9/E3KD6FL/qv9Olk1eOAew55m3dN7n/gJZuEh5j6YH1ycYxxGo835MrMTAtsiMm1HFhEM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741540068; c=relaxed/simple; bh=JqgFsJLWCiijljkhdZqOU7uLp+uDQ2YD+YY54FqxLjM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZiQDVLJXzwzuKvCXVMKGmQIeIwiBJsm7QV5caiveLF12Czebk9pLoMhtLf1+gRsSafydiuy0MLDzONn8ao2hy9/lPlYxR1Dq2fL+APpDhwqefbC5aBnwZ1QrOd6bu9mX2REG4yBFdSE8zYryrr+mSM3dLu0vp+kztAOc6G1T6IU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Bx1T0Y9e; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Bx1T0Y9e" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0890C4CEE3; Sun, 9 Mar 2025 17:07:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741540067; bh=JqgFsJLWCiijljkhdZqOU7uLp+uDQ2YD+YY54FqxLjM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Bx1T0Y9ewKnuuoR4CAlfZJpRDnPNwxoN7e37536T5hLFBX8z4Odyi9zmKDsuoreqI Y9IGRJsBIEQ4mE7udn6cjVXNocuPw+bLfVHTSVfWNypj6u+d85dnC0TMumaBVsM99j JjaBCqXWG6XbTfY+Noz3YHHLzmtMz6FCMxIXDez0lk+UB0Lnc7TF7u+E4lO4hXOE9A iVIbqIrpPTr+Q8kXHzwDV5Ka2hdQb8nDKBYfIfrYYdoxX2dhKDmLz76ezrv2XyWQK8 1z3JF6MRSV8+nKPAGs1XgzFD4aUiY6P5D/7HGex5OqDFAt1ShOk7bmT4UWB96u6VJZ nrkGCrI3LOE4A== From: Jonathan Cameron To: linux-iio@vger.kernel.org, =?utf-8?q?Nuno_S=C3=A1?= , Astrid Rost , Matti Vaittinen , Per-Daniel Olsson , Javier Carrasco , Subhajit Ghosh Cc: =?utf-8?q?Nuno_S=C3=A1?= , David Lechner , Jonathan Cameron Subject: [PATCH 15/18] iio: light: tcs3414: Switch to sparse friendly iio_device_claim/release_direct() Date: Sun, 9 Mar 2025 17:06:30 +0000 Message-ID: <20250309170633.1347476-16-jic23@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250309170633.1347476-1-jic23@kernel.org> References: <20250309170633.1347476-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron These new functions allow sparse to find failures to release direct mode reducing chances of bugs over the claim_direct_mode() functions that are deprecated. Signed-off-by: Jonathan Cameron --- drivers/iio/light/tcs3414.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/iio/light/tcs3414.c b/drivers/iio/light/tcs3414.c index 884e43e4cda4..39268f855c77 100644 --- a/drivers/iio/light/tcs3414.c +++ b/drivers/iio/light/tcs3414.c @@ -134,16 +134,15 @@ static int tcs3414_read_raw(struct iio_dev *indio_dev, switch (mask) { case IIO_CHAN_INFO_RAW: - ret = iio_device_claim_direct_mode(indio_dev); - if (ret) - return ret; + if (!iio_device_claim_direct(indio_dev)) + return -EBUSY; ret = tcs3414_req_data(data); if (ret < 0) { - iio_device_release_direct_mode(indio_dev); + iio_device_release_direct(indio_dev); return ret; } ret = i2c_smbus_read_word_data(data->client, chan->address); - iio_device_release_direct_mode(indio_dev); + iio_device_release_direct(indio_dev); if (ret < 0) return ret; *val = ret;