From patchwork Mon Mar 10 20:43:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 14010656 Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF2C21DE8AB for ; Mon, 10 Mar 2025 20:43:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741639394; cv=none; b=YEgUlXU5BMk7E5rrth79LNQpoY7g3MdIsUNi0a19NFOYEjBW9+4jQEj+IbtvHomBYDcJ9K9CUk85yNWENtlltHhxtQVndDRZmcYi6Pz6dUvmiFddHF+nmfR7GEUwDTH+Fs8RysaD0jKS23WnM77ycdnzJSI4ZVTBBG6bDvLkbnY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741639394; c=relaxed/simple; bh=0xf2lfBMlkwq8GDrukDrWvlzGt+OAqJxAVu2qGUaX1U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=g87SY62xafoii3vmLphyYfMOg6/tIi8lF23Ayoe4PcsBInVTW6yaFe6QdjEGrP7PRrJuj8a749Vql/AXMrIe0+zKmwQslCKZHSJ9VyO8UP6FxknRzBwCF6QZhYbIbHkawwJAHeJdOvJ6I2KDyFiphhF42qAF6bAjc7apkBIq9Qo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=n6hqXagm; arc=none smtp.client-ip=209.85.161.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="n6hqXagm" Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-601a4e037a5so829458eaf.3 for ; Mon, 10 Mar 2025 13:43:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1741639391; x=1742244191; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=epdj0pGglcLo1fb3QxJPZQv/lE+WglsZbV58ruZDnRA=; b=n6hqXagmka+4Nw0mNflqhQASedNuAW2+qwbRmRCHJlBVF+i5nNZW+qpNmakA64UrhS Ar/SlCFYpaKCmaTUaX6SBuvUi8EAsSip1URPpIQgOIePIuo1CQ5UjiAKz1X6Ae2pJefd jelbsfld/VB82/6WFOcPJIErttJEzUOprv9OskVwyKm02S/Mxh9CgLaGLdRanmoTz/0x eB1x66dzpBWwDAe7HbLSAJpqVMpHWpQ5ya/KWJHJiuAIjA/VlK1EFIyrQyiS4VH5hN2z uVr1Wk9LhuzzsuaypYD6a9d6PfobF0zUa2UEtPifSK7NIMMtaUTJVRwhltRHjwnlEIFs UAHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741639391; x=1742244191; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=epdj0pGglcLo1fb3QxJPZQv/lE+WglsZbV58ruZDnRA=; b=aOLArsCzoiUkdWRczq47q8qxtd6c8vUyzM255DhZwn645Pij4kzBHlgQ1kGAb2/Gwm GGfkelSHztcuQ1zGkzeN09wtVV17mX66Q6JIbLm9dbWRXEGv9qi2MKUJkxGvwzKMuoLv zCLcLat6gb3EoQD/wn2Q7CnSF2Eg8eeeHiqVeqCuxWaw1MWyLWhbx/1wNRhKemUL+J97 uMnwhplIIb8Gg69jy2ZLLPS5y0Au77puOErlGhMR/Ys3yNM3X/cJGiy+WLeYQXvkApks IqUe9mNTz9+eubuJFuSCpmBOsGfSpHdzvco03shn+V8TgO47duJz4v6LVTD3vJYgC8oF Z6xQ== X-Gm-Message-State: AOJu0Yw2N0YNS4W2+yk+fVZtiTc1gVZZKE96UkYiCSOJZA7Eg/Og0IZb 5jtIUsC/1EGXIemU6sN+4BrkQVIkb9NvNXHu50f3hDMMsq0iayL2AhjsgNIe+5s= X-Gm-Gg: ASbGncvT/pL5fmnQFRs1Dqd3jOv+YsoYqCsAS+qaO0fVA9ysOhQu21pWEAfERgE2hPz Oi5Cs+dmgjwRmvaPKubVWHDURNYTIW2UeAAuc0lJxi9ejh4lNoKODmg/p93rrmiuAZFu3O1gwkH iAMNUeiitsP3TARhI4ywLJqNbpTnzXywFtS/fl2w7yz39w7DTDLPcKFVIpemNYHsmGq2ObwR/Y4 HDqhVzqB9tEftGTs5djBcuK+uuga4YnDa5/43Cmo6e8qad8fz7X20iE40fJFf7S47O4yXxb9VxR K9zjC4ceJPn0d2agmqJREInjHjr1EgkwAtgAKcOD+cKUWYBdve0P3a8Y/tiiLXZIsx0OmY9sEEk SYt8HqWB4Dlc= X-Google-Smtp-Source: AGHT+IF3tmx1kGHFtcRxx4TOJ+aZvJTTIq2iqIl6c/KAO5ngljUPVei58WxV+MNvlmlbqMMyOLaJYQ== X-Received: by 2002:a05:6808:1b26:b0:3f7:ff67:1d9a with SMTP id 5614622812f47-3fa2c78e8e6mr559991b6e.36.1741639390752; Mon, 10 Mar 2025 13:43:10 -0700 (PDT) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f855f69b1asm764315b6e.30.2025.03.10.13.43.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 13:43:09 -0700 (PDT) From: David Lechner Date: Mon, 10 Mar 2025 15:43:04 -0500 Subject: [PATCH 1/5] iio: adc: ad4030: check scan_type for error Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250310-iio-adc-ad4030-check-scan-type-err-v1-1-589e4ebd9711@baylibre.com> References: <20250310-iio-adc-ad4030-check-scan-type-err-v1-0-589e4ebd9711@baylibre.com> In-Reply-To: <20250310-iio-adc-ad4030-check-scan-type-err-v1-0-589e4ebd9711@baylibre.com> To: Lars-Peter Clausen , Michael Hennerich , =?utf-8?q?Nuno_S=C3=A1?= , Esteban Blanc , Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner , kernel test robot , Dan Carpenter X-Mailer: b4 0.14.2 Check scan_type for error ad4030_get_chan_scale(). Currently, this should never fail, but it is good practice to always check for errors in case of future changes. Calling iio_get_current_scan_type() is moved out of the if statement also to avoid potential issues with future changes instead of assuming that the non-differential case does not use extended scan_type. Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202503040954.n6MhjSsV-lkp@intel.com/ Signed-off-by: David Lechner Reviewed-by: Nuno Sá --- drivers/iio/adc/ad4030.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/iio/adc/ad4030.c b/drivers/iio/adc/ad4030.c index 9a020680885d93f4da8922e5cfeecc0c7ce23f4d..af7a817e8273496e8856a5ba1a9c2e66a11f0a84 100644 --- a/drivers/iio/adc/ad4030.c +++ b/drivers/iio/adc/ad4030.c @@ -390,16 +390,18 @@ static int ad4030_get_chan_scale(struct iio_dev *indio_dev, struct ad4030_state *st = iio_priv(indio_dev); const struct iio_scan_type *scan_type; + scan_type = iio_get_current_scan_type(indio_dev, st->chip->channels); + if (IS_ERR(scan_type)) + return PTR_ERR(scan_type); + if (chan->differential) { - scan_type = iio_get_current_scan_type(indio_dev, - st->chip->channels); *val = (st->vref_uv * 2) / MILLI; *val2 = scan_type->realbits; return IIO_VAL_FRACTIONAL_LOG2; } *val = st->vref_uv / MILLI; - *val2 = chan->scan_type.realbits; + *val2 = scan_type->realbits; return IIO_VAL_FRACTIONAL_LOG2; }