| Message ID | 20250318194624.7626-1-sergio@pereznus.es (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v4,1/2] dt-bindings: iio: light: bh1750: Add reset-gpios property | expand |
On Tue, Mar 18, 2025 at 08:45:54PM +0100, Sergio Perez wrote: Your threading is completely broken. Read my last message - I gave you clear instructions which you did not follow. Why? > > + reset-gpios: > + description: GPIO connected to the sensor's reset line (active low) "Active low reset line". No point to say that GPIO is a "GPIO connected to the...", because it cannot be anything else. > + maxItems: 1 > + > required: > - compatible > - reg > @@ -39,6 +43,7 @@ examples: > light-sensor@23 { > compatible = "rohm,bh1750"; > reg = <0x23>; > + reset-gpios = <&gpio2 17 0>; 1. Include header and use proper defines 2. And then you will see that it is not active low, like you claim in description... > }; > }; > > -- > 2.43.0 >
diff --git a/Documentation/devicetree/bindings/iio/light/bh1750.yaml b/Documentation/devicetree/bindings/iio/light/bh1750.yaml index 1a88b3c253d5..f7a8dcd7d2a1 100644 --- a/Documentation/devicetree/bindings/iio/light/bh1750.yaml +++ b/Documentation/devicetree/bindings/iio/light/bh1750.yaml @@ -24,6 +24,10 @@ properties: reg: maxItems: 1 + reset-gpios: + description: GPIO connected to the sensor's reset line (active low) + maxItems: 1 + required: - compatible - reg @@ -39,6 +43,7 @@ examples: light-sensor@23 { compatible = "rohm,bh1750"; reg = <0x23>; + reset-gpios = <&gpio2 17 0>; }; };
Some BH1750 sensors require a hardware reset via GPIO before they can be properly detected on the I2C bus. Add a new reset-gpios property to the binding to support this functionality. The reset-gpios property allows specifying a GPIO that will be toggled during driver initialization to reset the sensor. Signed-off-by: Sergio Perez <sergio@pereznus.es> --- Documentation/devicetree/bindings/iio/light/bh1750.yaml | 5 +++++ 1 file changed, 5 insertions(+)