| Message ID | 20250321161609.3662-1-sergio@pereznus.es (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v5,1/2] dt-bindings: iio: light: bh1750: Add reset-gpios property | expand |
On Fri, Mar 21, 2025 at 05:16:08PM +0100, Sergio Perez wrote: > + reset-gpios: > + description: GPIO connected to the DVI reset pin (active low) > + maxItems: 1 > + > required: > - compatible > - reg > @@ -36,9 +40,12 @@ examples: > #address-cells = <1>; > #size-cells = <0>; > > + #include <dt-bindings/gpio/gpio.h> This goes upper. Please open any other bindings to see how it is done. With fixed placement: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- <form letter> This is an automated instruction, just in case, because many review tags are being ignored. If you know the process, you can skip it (please do not feel offended by me posting it here - no bad intentions intended). If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577 </form letter> Best regards, Krzysztof
El 24/03/2025 a las 9:08, Krzysztof Kozlowski escribió: > On Fri, Mar 21, 2025 at 05:16:08PM +0100, Sergio Perez wrote: >> + reset-gpios: >> + description: GPIO connected to the DVI reset pin (active low) >> + maxItems: 1 >> + >> required: >> - compatible >> - reg >> @@ -36,9 +40,12 @@ examples: >> #address-cells = <1>; >> #size-cells = <0>; >> >> + #include <dt-bindings/gpio/gpio.h> > This goes upper. Please open any other bindings to see how it is done. > > With fixed placement: > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Thanks, I will fix the placement of include and send new version (v6). > --- > > <form letter> > This is an automated instruction, just in case, because many review tags > are being ignored. If you know the process, you can skip it (please do > not feel offended by me posting it here - no bad intentions intended). > If you do not know the process, here is a short explanation: > > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions of patchset, under or above your Signed-off-by tag, unless > patch changed significantly (e.g. new properties added to the DT > bindings). Tag is "received", when provided in a message replied to you > on the mailing list. Tools like b4 can help here. However, there's no > need to repost patches *only* to add the tags. The upstream maintainer > will do that for tags received on the version they apply. > > https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577 > </form letter> > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/iio/light/bh1750.yaml b/Documentation/devicetree/bindings/iio/light/bh1750.yaml index 1a88b3c253d5..e388610d3741 100644 --- a/Documentation/devicetree/bindings/iio/light/bh1750.yaml +++ b/Documentation/devicetree/bindings/iio/light/bh1750.yaml @@ -24,6 +24,10 @@ properties: reg: maxItems: 1 + reset-gpios: + description: GPIO connected to the DVI reset pin (active low) + maxItems: 1 + required: - compatible - reg @@ -36,9 +40,12 @@ examples: #address-cells = <1>; #size-cells = <0>; + #include <dt-bindings/gpio/gpio.h> + light-sensor@23 { compatible = "rohm,bh1750"; reg = <0x23>; + reset-gpios = <&gpio2 17 GPIO_ACTIVE_LOW>; }; };
Some BH1750 sensors require a hardware reset via GPIO before they can be properly detected on the I2C bus. Add a new reset-gpios property to the binding to support this functionality. The reset-gpios property allows specifying a GPIO that will be toggled during driver initialization to reset the sensor. Signed-off-by: Sergio Perez <sergio@pereznus.es> --- Revision history: v4 => v5: - Update description to reflect "active low" on reset signal as indicated by Krzysztof Kozlowski - Update description to clarify what pin of sensor is used to do reset (DVI) as mentioned by Krzysztof Kozlowski - Edit example to be coherent with "active low" as informed by Krzysztof Kozlowski - Added necessary include on example v3 => v4: - No changes v2 => v3: - Split in two patches: dtbinding and code - Ensure list off mantainers following instructions by Krzysztof Kozlowski - Delete redundant details on description as suggested by Jonathan Cameron - Added related example to existing one as suggested by Jonathan Cameron v1 => v2: - Ensure check tests as commented by Rob Herring - Fixes some whitespaces and end lines --- Documentation/devicetree/bindings/iio/light/bh1750.yaml | 7 +++++++ 1 file changed, 7 insertions(+)