diff mbox series

[3/3] dt-bindings: add winsen to the vendor prefixes

Message ID 20250329164905.632491-4-gye976@gmail.com (mailing list archive)
State Changes Requested
Headers show
Series add support for winsen MHZ19B CO2 sensor | expand

Commit Message

gyeyoung March 29, 2025, 4:49 p.m. UTC 
Add winsen to the vendor prefixes.

Signed-off-by: Gyeyoung Baek <gye976@gmail.com>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Krzysztof Kozlowski March 30, 2025, 9:37 a.m. UTC | #1 
On 29/03/2025 17:49, Gyeyoung Baek wrote:
> Add winsen to the vendor prefixes.
> 
> Signed-off-by: Gyeyoung Baek <gye976@gmail.com>
> ---
Your patches are ordered entirely in opposite order. First you use the
binding, then you document. First you use prefix, then you document it.

It's not bisectable. Reverse everything (see also DT submitting patches).

Best regards,
Krzysztof
gyeyoung March 31, 2025, 12:13 a.m. UTC | #2 
Hello Krzysztof, thank you for the review.


On Sun, Mar 30, 2025 at 6:37 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 29/03/2025 17:49, Gyeyoung Baek wrote:
> > Add winsen to the vendor prefixes.
> >
> > Signed-off-by: Gyeyoung Baek <gye976@gmail.com>
> > ---
> Your patches are ordered entirely in opposite order. First you use the
> binding, then you document. First you use prefix, then you document it.
>
> It's not bisectable. Reverse everything (see also DT submitting patches).

On second thought, reverse order makes more sense. thanks.

> Best regards,
> Krzysztof

Thanks,
Gyeyoung Baek
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 5079ca6ce1d1..ee7f6100c432 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -1679,6 +1679,8 @@  patternProperties:
     description: Wingtech Technology Co., Ltd.
   "^winlink,.*":
     description: WinLink Co., Ltd
+  "^winsen,.*":
+    description: Winsen Corp.
   "^winstar,.*":
     description: Winstar Display Corp.
   "^wirelesstag,.*":