| Message ID | 20250331121317.1694135-13-jic23@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | IIO: Sparse friendly claim of direct mode (the rest) | expand |
Hi Jonathan, Thanks for the patch. It looks good to me. Acked-by: Eugene Zaikonnikov <ez@norphonic.com> Jonathan Cameron <jic23@kernel.org> writes: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > These new functions allow sparse to find failures to release > direct mode reducing chances of bugs over the claim_direct_mode() > functions that are deprecated. > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Cc: Eugene Zaikonnikov <ez@norphonic.com> > --- > drivers/iio/humidity/hdc2010.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/iio/humidity/hdc2010.c b/drivers/iio/humidity/hdc2010.c > index f5867659e00f..894a8b4ab193 100644 > --- a/drivers/iio/humidity/hdc2010.c > +++ b/drivers/iio/humidity/hdc2010.c > @@ -169,13 +169,12 @@ static int hdc2010_read_raw(struct iio_dev *indio_dev, > *val = hdc2010_get_heater_status(data); > return IIO_VAL_INT; > } > - ret = iio_device_claim_direct_mode(indio_dev); > - if (ret) > - return ret; > + if (!iio_device_claim_direct(indio_dev)) > + return -EBUSY; > mutex_lock(&data->lock); > ret = hdc2010_get_prim_measurement_word(data, chan); > mutex_unlock(&data->lock); > - iio_device_release_direct_mode(indio_dev); > + iio_device_release_direct(indio_dev); > if (ret < 0) > return ret; > *val = ret; > @@ -184,13 +183,12 @@ static int hdc2010_read_raw(struct iio_dev *indio_dev, > case IIO_CHAN_INFO_PEAK: { > int ret; > > - ret = iio_device_claim_direct_mode(indio_dev); > - if (ret) > - return ret; > + if (!iio_device_claim_direct(indio_dev)) > + return -EBUSY; > mutex_lock(&data->lock); > ret = hdc2010_get_peak_measurement_byte(data, chan); > mutex_unlock(&data->lock); > - iio_device_release_direct_mode(indio_dev); > + iio_device_release_direct(indio_dev); > if (ret < 0) > return ret; > /* Scaling up the value so we can use same offset as RAW */
diff --git a/drivers/iio/humidity/hdc2010.c b/drivers/iio/humidity/hdc2010.c index f5867659e00f..894a8b4ab193 100644 --- a/drivers/iio/humidity/hdc2010.c +++ b/drivers/iio/humidity/hdc2010.c @@ -169,13 +169,12 @@ static int hdc2010_read_raw(struct iio_dev *indio_dev, *val = hdc2010_get_heater_status(data); return IIO_VAL_INT; } - ret = iio_device_claim_direct_mode(indio_dev); - if (ret) - return ret; + if (!iio_device_claim_direct(indio_dev)) + return -EBUSY; mutex_lock(&data->lock); ret = hdc2010_get_prim_measurement_word(data, chan); mutex_unlock(&data->lock); - iio_device_release_direct_mode(indio_dev); + iio_device_release_direct(indio_dev); if (ret < 0) return ret; *val = ret; @@ -184,13 +183,12 @@ static int hdc2010_read_raw(struct iio_dev *indio_dev, case IIO_CHAN_INFO_PEAK: { int ret; - ret = iio_device_claim_direct_mode(indio_dev); - if (ret) - return ret; + if (!iio_device_claim_direct(indio_dev)) + return -EBUSY; mutex_lock(&data->lock); ret = hdc2010_get_peak_measurement_byte(data, chan); mutex_unlock(&data->lock); - iio_device_release_direct_mode(indio_dev); + iio_device_release_direct(indio_dev); if (ret < 0) return ret; /* Scaling up the value so we can use same offset as RAW */