| Message ID | 20250331121317.1694135-15-jic23@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | IIO: Sparse friendly claim of direct mode (the rest) | expand |
On Mar 31, Jonathan Cameron wrote: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > These new functions allow sparse to find failures to release > direct mode reducing chances of bugs over the claim_direct_mode() > functions that are deprecated. > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Acked-by: Lorenzo Bianconi <lorenzo@kernel.org> > --- > drivers/iio/humidity/hts221_core.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/iio/humidity/hts221_core.c b/drivers/iio/humidity/hts221_core.c > index ca4746f2ecba..bfeb0a60d3af 100644 > --- a/drivers/iio/humidity/hts221_core.c > +++ b/drivers/iio/humidity/hts221_core.c > @@ -464,13 +464,12 @@ static int hts221_read_raw(struct iio_dev *iio_dev, > { > int ret; > > - ret = iio_device_claim_direct_mode(iio_dev); > - if (ret) > - return ret; > + if (!iio_device_claim_direct(iio_dev)) > + return -EBUSY; > > ret = __hts221_read_raw(iio_dev, ch, val, val2, mask); > > - iio_device_release_direct_mode(iio_dev); > + iio_device_release_direct(iio_dev); > > return ret; > } > @@ -504,13 +503,12 @@ static int hts221_write_raw(struct iio_dev *iio_dev, > { > int ret; > > - ret = iio_device_claim_direct_mode(iio_dev); > - if (ret) > - return ret; > + if (!iio_device_claim_direct(iio_dev)) > + return -EBUSY; > > ret = __hts221_write_raw(iio_dev, chan, val, mask); > > - iio_device_release_direct_mode(iio_dev); > + iio_device_release_direct(iio_dev); > > return ret; > } > -- > 2.48.1 >
diff --git a/drivers/iio/humidity/hts221_core.c b/drivers/iio/humidity/hts221_core.c index ca4746f2ecba..bfeb0a60d3af 100644 --- a/drivers/iio/humidity/hts221_core.c +++ b/drivers/iio/humidity/hts221_core.c @@ -464,13 +464,12 @@ static int hts221_read_raw(struct iio_dev *iio_dev, { int ret; - ret = iio_device_claim_direct_mode(iio_dev); - if (ret) - return ret; + if (!iio_device_claim_direct(iio_dev)) + return -EBUSY; ret = __hts221_read_raw(iio_dev, ch, val, val2, mask); - iio_device_release_direct_mode(iio_dev); + iio_device_release_direct(iio_dev); return ret; } @@ -504,13 +503,12 @@ static int hts221_write_raw(struct iio_dev *iio_dev, { int ret; - ret = iio_device_claim_direct_mode(iio_dev); - if (ret) - return ret; + if (!iio_device_claim_direct(iio_dev)) + return -EBUSY; ret = __hts221_write_raw(iio_dev, chan, val, mask); - iio_device_release_direct_mode(iio_dev); + iio_device_release_direct(iio_dev); return ret; }