| Message ID | 20250401-iio-ad7380-add-ad7389-4-v1-1-23d2568aa24f@baylibre.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | iio: adc: ad7380: add ad7389-4 support | expand |
On Tue, Apr 01, 2025 at 05:50:08PM -0500, David Lechner wrote: > Add compatible and quirks for AD7389-4. This is essentially the same as > AD7380-4 but instead of having no internal reference, it has no external > reference voltage supply. So neither refio nor refin, but your schema says: > + then: > + properties: > + refio-supply: false So what about refin, which is also external reference? Best regards, Krzysztof
On 4/2/25 3:25 AM, Krzysztof Kozlowski wrote: > On Tue, Apr 01, 2025 at 05:50:08PM -0500, David Lechner wrote: >> Add compatible and quirks for AD7389-4. This is essentially the same as >> AD7380-4 but instead of having no internal reference, it has no external >> reference voltage supply. > > So neither refio nor refin, but your schema says: > >> + then: >> + properties: >> + refio-supply: false > > So what about refin, which is also external reference? This is already handled by the existing if statement: - if: properties: compatible: enum: - adi,ad7380-4 - adi,adaq4370-4 - adi,adaq4380-4 - adi,adaq4381-4 then: properties: refio-supply: false required: - refin-supply else: properties: refin-supply: false
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7380.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7380.yaml index ff4f5c21c5482b77ee2774b01ad6d426e68cf207..8dae89ecb64d723dcf2b4af1e0505fc5db49595b 100644 --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7380.yaml +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7380.yaml @@ -25,6 +25,7 @@ description: | * https://www.analog.com/en/products/ad7386-4.html * https://www.analog.com/en/products/ad7387-4.html * https://www.analog.com/en/products/ad7388-4.html + * https://www.analog.com/en/products/ad7389-4.html * https://www.analog.com/en/products/adaq4370-4.html * https://www.analog.com/en/products/adaq4380-4.html * https://www.analog.com/en/products/adaq4381-4.html @@ -49,6 +50,7 @@ properties: - adi,ad7386-4 - adi,ad7387-4 - adi,ad7388-4 + - adi,ad7389-4 - adi,adaq4370-4 - adi,adaq4380-4 - adi,adaq4381-4 @@ -213,6 +215,15 @@ allOf: properties: refin-supply: false + # adi,ad7389-4 is internal reference only + - if: + properties: + compatible: + const: adi,ad7389-4 + then: + properties: + refio-supply: false + # adaq devices need more supplies and using channel to declare gain property # only applies to adaq devices - if:
Add compatible and quirks for AD7389-4. This is essentially the same as AD7380-4 but instead of having no internal reference, it has no external reference voltage supply. Signed-off-by: David Lechner <dlechner@baylibre.com> --- Documentation/devicetree/bindings/iio/adc/adi,ad7380.yaml | 11 +++++++++++ 1 file changed, 11 insertions(+)