diff mbox series

[v2,01/20] iio: adc: ad7266: Fix potential timestamp alignment issue.

Message ID 20250406172001.2167607-2-jic23@kernel.org (mailing list archive)
State New
Headers show
Series IIO: Introduce iio_push_to_buffers_with_ts() taking an input buffer length argument. | expand

Commit Message

Jonathan Cameron April 6, 2025, 5:19 p.m. UTC 
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

On architectures where an s64 is only aligned to 32 bits insufficient
padding would be left between the earlier elements and the timestamp.
Use aligned_s64 to enforce the correct placement and ensure the
storage is large enough.

Fixes: 54e018da3141 ("iio:ad7266: Mark transfer buffer as __be16") # aligned_s64 is much newer.
Reported-by: David Lechner <dlechner@baylibre.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/iio/adc/ad7266.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andy Shevchenko April 7, 2025, 9:16 a.m. UTC | #1 
On Sun, Apr 06, 2025 at 06:19:42PM +0100, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> On architectures where an s64 is only aligned to 32 bits insufficient

32-bit ?

> padding would be left between the earlier elements and the timestamp.
> Use aligned_s64 to enforce the correct placement and ensure the
> storage is large enough.
diff mbox series

Patch

diff --git a/drivers/iio/adc/ad7266.c b/drivers/iio/adc/ad7266.c
index 18559757f908..7fef2727f89e 100644
--- a/drivers/iio/adc/ad7266.c
+++ b/drivers/iio/adc/ad7266.c
@@ -45,7 +45,7 @@  struct ad7266_state {
 	 */
 	struct {
 		__be16 sample[2];
-		s64 timestamp;
+		aligned_s64 timestamp;
 	} data __aligned(IIO_DMA_MINALIGN);
 };