diff mbox series

[v2,03/20] iio: adc: dln2: Use aligned_s64 for timestamp

Message ID	20250406172001.2167607-4-jic23@kernel.org (mailing list archive)
State	New
Headers	show Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D3041487F6 for <linux-iio@vger.kernel.org>; Sun, 6 Apr 2025 17:20:26 +0000 (UTC) From: Jonathan Cameron <jic23@kernel.org> To: linux-iio@vger.kernel.org, David Lechner <dlechner@baylibre.com>, =?utf-8?q?Nuno_S=C3=A1?= <nuno.sa@analog.com>, Andy Shevchenko <andy@kernel.org> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com> Subject: [PATCH v2 03/20] iio: adc: dln2: Use aligned_s64 for timestamp Date: Sun, 6 Apr 2025 18:19:44 +0100 Message-ID: <20250406172001.2167607-4-jic23@kernel.org> In-Reply-To: <20250406172001.2167607-1-jic23@kernel.org> References: <20250406172001.2167607-1-jic23@kernel.org> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	IIO: Introduce iio_push_to_buffers_with_ts() taking an input buffer length argument. \| expand [v2,00/20] IIO: Introduce iio_push_to_buffers_with_ts() taking an input buffer length argument. [v2,01/20] iio: adc: ad7266: Fix potential timestamp alignment issue. [v2,02/20] iio: adc: ad7768-1: Fix insufficient alignment of timestamp. [v2,03/20] iio: adc: dln2: Use aligned_s64 for timestamp [v2,04/20] iio: accel: adxl355: Make timestamp 64 bit aligned using aligned_s64 [v2,05/20] iio: introduced iio_push_to_buffers_with_ts() that takes a data_total_len argument. [v2,06/20] iio: dummy: Use a fixed structure to build up scan to push to buffers. [v2,07/20] iio: dummy: Switch to iio_push_to_buffers_with_ts() and provide size of storage [v2,08/20] iio: adc: ti-ads131e08: Use new iio_push_to_buffers_with_ts() to provide length sanity c… [v2,09/20] iio: adc: Use iio_push_to_buffers_with_ts() to provide length for runtime checks. [v2,10/20] iio: accel: Use iio_push_to_buffers_with_ts() to provide length for runtime checks. [v2,11/20] iio: accel: hid: Use iio_push_to_buffers_with_ts() to provide length for runtime checks. [v2,12/20] iio: chemical: Use iio_push_to_buffers_with_ts() to provide length for runtime checks. [v2,13/20] iio: temp: maxim-thermocouple: Fix potential lack of DMA safe buffer. [v2,14/20] iio: temperature: Use iio_push_to_buffers_with_ts() to provide length for runtime checks. [v2,15/20] iio: resolver: Use iio_push_to_buffers_with_ts() to provide length for runtime checks. [v2,16/20] iio: proximity: irsd200: Use a struct for scan and iio_push_to_buffers_with_ts() [v2,17/20] iio: proximity: Use iio_push_to_buffers_with_ts() to provide length for runtime checks. [v2,18/20] iio: pressure: zpa2326: Use aligned_s64 for the timestamp [v2,19/20] iio: pressure: Use iio_push_to_buffers_with_ts() to provide length for runtime checks. [v2,20/20] iio: magnetometer: Use iio_push_to_buffers_with_ts() to provide length for runtime check…

Commit Message

Jonathan Cameron April 6, 2025, 5:19 p.m. UTC

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Here the lack of marking allows the overall structure to not be
sufficiently aligned resulting in misplacement of the timestamp
in iio_push_to_buffers_with_timestamp(). Use aligned_s64 to
force the alignment on all architectures.

Reported-by: David Lechner <dlechner@baylibre.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/iio/adc/dln2-adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andy Shevchenko April 7, 2025, 9:11 a.m. UTC | #1

On Sun, Apr 06, 2025 at 06:19:44PM +0100, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Here the lack of marking allows the overall structure to not be
> sufficiently aligned resulting in misplacement of the timestamp
> in iio_push_to_buffers_with_timestamp(). Use aligned_s64 to
> force the alignment on all architectures.

Reviewed-by: Andy Shevchenko <andy@kernel.org>

diff mbox series

Patch

diff --git a/drivers/iio/adc/dln2-adc.c b/drivers/iio/adc/dln2-adc.c
index a1e48a756a7b..359e26e3f5bc 100644
--- a/drivers/iio/adc/dln2-adc.c
+++ b/drivers/iio/adc/dln2-adc.c
@@ -466,7 +466,7 @@  static irqreturn_t dln2_adc_trigger_h(int irq, void *p)
 	struct iio_dev *indio_dev = pf->indio_dev;
 	struct {
 		__le16 values[DLN2_ADC_MAX_CHANNELS];
-		int64_t timestamp_space;
+		aligned_s64 timestamp_space;
 	} data;
 	struct dln2_adc_get_all_vals dev_data;
 	struct dln2_adc *dln2 = iio_priv(indio_dev);