From patchwork Mon Apr 7 07:18:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14039822 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 983CC22D7B3 for ; Mon, 7 Apr 2025 07:18:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010301; cv=none; b=jEFsIg0yQNSWh8P9QOmcMBdrcThKTlC7KHa2UCLcwp0Tyh64iXbCh3kU/Jvwc0YjfsCE4FgKoBzqnhM0hUeB6GV5QFA0o81lExOa/ZM/evHJNXJlcJHDznlKQsM1e5j8J7gSkY2HDqJytwuNWaKkPzekTogDJsPd5YYo2keFlc8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010301; c=relaxed/simple; bh=JcjRt3IWWdiCtJbwqzp1v4b47hd64XOA+ew6annId/8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BHN9O4wlMLi1ioU49t3G25eXW60kn3otySEIQf7IQS3qaQJYpIJ8VKvjR94bWBdSihBRhH75rCU7Y0eRUvXqXzr76haTQ6zQFeoLHvJKpqUdb1Eky2HR88TD439UmXbwmxlo0/BWZCN3VPFM6JwH4qUo07V0tA5sMozJeVjglxI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=N4ReUfRl; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="N4ReUfRl" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-43cfe574976so26699015e9.1 for ; Mon, 07 Apr 2025 00:18:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010298; x=1744615098; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XYtkHCFcaSF7UbWnri58lccyI2lE1qpEsdGVCNframM=; b=N4ReUfRlxNmbLYE9UbZ2TrsC7oE+e8x0M/39C+e6wj+lv9BjbiQe4TJkXRTujYU5+Z deN4HorPfo0GxDgQ1+OgAu4dw/CMWLQVUdN389PsMsyl/1bHxFahsNLnUBWgkZwUe/u8 bU2VaqKIWtps1z8LYY5dpQI/yAfmBesqMCZVYaUTUTSM7NqYllQg3qrdFrYKPe9wIt38 1ZfvZKIu3Kp6CkCN3T3xOx64v6LYOxx1+gXvrIhymnQpaqJidHXsmViSWFyNAYqNQfCT SYW/4ZHosjaF2pM442EtyKtTkUeo16QJuTTNEP9eXBCIVgAgj/MhRz1ydnw/7BQA2BkT ouZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010298; x=1744615098; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XYtkHCFcaSF7UbWnri58lccyI2lE1qpEsdGVCNframM=; b=ByEf5qG4etodMMEC8QvqhcKnm2K1tN0oTzxfhKY6TZwJl7w7iGCcLCMLVgDGKhJSdT 8Oz2A3jPXeX/KiFpPzsO0nrBtr2Szkz92tJBSBr58MYj3MhxVnGNWQNxzTxgFm/Er+b/ MgwEUT7oRkItQFcnWI0P81bXk1kC3LPNByMHiDmzjZMFf/jEQNR8LI8h5XZ6cB9aALrV +4dTediQQgyaJaMIq0EKdmd2pUA83U2Ggek9jsUP5sbV9/9oQkgXmF4h00MzC9aLGmIF 1BaO79nVn6qAuf7fuOPJTx+WPWVUbzfAi1ihMhpI94yoL8nYKVMbDCgVsH6+3T0JNxoP F/6A== X-Gm-Message-State: AOJu0Yzlvu3+24PvcI9dpLoOyYEWYJvRE9dkX6iRnzF/SoXd83xsc7PP iX2gCFcXNHCOwWX+aJxKXdAkrk7JYycBfbhGZC7vCkKgOMl7+vdxRcCrOUAe4Xk= X-Gm-Gg: ASbGncuBHRe81cnC7SR7p5nXCyAJ6XkdqcIFP2zqtfsJE1lQ4A9qoyctW3STrImgUQq 00clAMAHvfyaWjeL2MnYha/PNeqt/d70L7HYId1uvyJ1B2VQnFm7iR2fJ8BTonyYMHc/TGsPzp8 PRCNfHmJ4CVlL1xfDNVC1TgvCA5Nr/22IQocrrquI2nAnN2Rx6bJRKsn8/PeU39JMS97qUhQu4e RSV4QIttD/W/8Bct5ubKJ5i/dUOsK5eW7di1D2RLMWdULMeSjg83BehxPNus8F1xVAvkTg/QJlS T6pSbsdKE5KEMtYZPxrS+0lhW6ZoVnKfqEOnBI0GMe8a9P2w X-Google-Smtp-Source: AGHT+IFJgSB1mfe2t5szPiSLNr2MNwqUf8v+9jwrmbgyH2kFsuYq3Qv/ef4JBN4s56UCzcSRvHeX/g== X-Received: by 2002:a05:600c:1f07:b0:43c:f8fc:f687 with SMTP id 5b1f17b1804b1-43ecfa04a8emr85603395e9.27.1744010297012; Mon, 07 Apr 2025 00:18:17 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec1630f21sm125224455e9.8.2025.04.07.00.18.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:18:16 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:18:12 +0200 Subject: [PATCH 4/7] iio: adc: ti-ads7950: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250407-gpiochip-set-rv-iio-v1-4-8431b003a145@linaro.org> References: <20250407-gpiochip-set-rv-iio-v1-0-8431b003a145@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-iio-v1-0-8431b003a145@linaro.org> To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Linus Walleij , Bartosz Golaszewski , Cosmin Tanislav Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2122; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=2MIhT3UvouiWSb+JqPeZnzmfSS+HLRvIRYg5KBNUdDc=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83wzY9NMbOxk6VjgP1/KsmPepcYuP2rlT9xHP EzAhaaVp/KJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N8MwAKCRARpy6gFHHX cnZAEADY4UNBcOSE8f291z41AA1F2ND4+IVzRboTWFLvRw+4K1BaOrnd3ZLW0yDdokNkKCGXp1F 94KNmgK/lYxNmlQfVYU8N5Y1Pt6ss9q9f/d+VWanGAdv2UBp3I3d7OtrwgnmBAPB/lEzwicIsgt sfZsaPf5lNYyx3Jx9NIuCcfVRolZu/jwpY1uJcj8jTfZyM6eoAD2FTlqAR6WXBLaiAO9khXzzvr kqiRECyfrVntEMVIYATjhByrdw/x+NamoagDxFJZ7voEBVjZYLQ5b7zE+3U8B+4NFU/LJi6xCam zvRZ4l5N/ZP98/x0ypvjG+1nIrnNuZRQo+89QBDcgz+HPqC8cq/VyM067dUKJ/cIilIKi9JEjd4 bjRZvUdo1ymKm7HpwilINx+4nFjYu1a9Qji2IOUwvPFGbAFbtc/ndlgcnCO4rcyGy5CcERu1e49 Iu/iqffd0wgl6alpN7j0w44+MEwK3nw0sQSdS5AXD4MgWdJxrybBGmkpxcdsj9ynP8ryR5/t6iA WNIAAmUsJdTVSTJjFQIvAdEC5y+xUZ15rbP0FUmdaJ+wldYlpHskzODfNFucF+MEgxPtzsRFeq1 rf2cGaakRaIjryTMG8EFZSkR2pfnDh7Ls06Ao516+jPWA9WpN922ffqizx2UZg07tGkHTXTltOX nBMHrip0BRIKwDQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/iio/adc/ti-ads7950.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/iio/adc/ti-ads7950.c b/drivers/iio/adc/ti-ads7950.c index af28672aa803..0356ccf23fea 100644 --- a/drivers/iio/adc/ti-ads7950.c +++ b/drivers/iio/adc/ti-ads7950.c @@ -403,10 +403,11 @@ static const struct iio_info ti_ads7950_info = { .update_scan_mode = ti_ads7950_update_scan_mode, }; -static void ti_ads7950_set(struct gpio_chip *chip, unsigned int offset, - int value) +static int ti_ads7950_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct ti_ads7950_state *st = gpiochip_get_data(chip); + int ret; mutex_lock(&st->slock); @@ -416,9 +417,11 @@ static void ti_ads7950_set(struct gpio_chip *chip, unsigned int offset, st->cmd_settings_bitmask &= ~BIT(offset); st->single_tx = TI_ADS7950_MAN_CMD_SETTINGS(st); - spi_sync(st->spi, &st->scan_single_msg); + ret = spi_sync(st->spi, &st->scan_single_msg); mutex_unlock(&st->slock); + + return ret; } static int ti_ads7950_get(struct gpio_chip *chip, unsigned int offset) @@ -499,7 +502,11 @@ static int ti_ads7950_direction_input(struct gpio_chip *chip, static int ti_ads7950_direction_output(struct gpio_chip *chip, unsigned int offset, int value) { - ti_ads7950_set(chip, offset, value); + int ret; + + ret = ti_ads7950_set(chip, offset, value); + if (ret) + return ret; return _ti_ads7950_set_direction(chip, offset, 0); } @@ -641,7 +648,7 @@ static int ti_ads7950_probe(struct spi_device *spi) st->chip.direction_input = ti_ads7950_direction_input; st->chip.direction_output = ti_ads7950_direction_output; st->chip.get = ti_ads7950_get; - st->chip.set = ti_ads7950_set; + st->chip.set_rv = ti_ads7950_set; ret = gpiochip_add_data(&st->chip, st); if (ret) {