| Message ID | 209172d47d8d14c1244556e5f05bbd6455b4de04.1541733949.git.nishadkamdar@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: iio: ad7816: Switch to the gpio descriptor interface | expand |
On Fri, 2018-11-09 at 13:08 +0530, Nishad Kamdar wrote: > Add device tree table for matching vendor ID. One comment inline for this. Thanks Alex > > Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com> > --- > drivers/staging/iio/adc/ad7816.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/staging/iio/adc/ad7816.c > b/drivers/staging/iio/adc/ad7816.c > index a2fead85cd46..b8a9149fbac1 100644 > --- a/drivers/staging/iio/adc/ad7816.c > +++ b/drivers/staging/iio/adc/ad7816.c > @@ -422,6 +422,12 @@ static int ad7816_probe(struct spi_device *spi_dev) > return 0; > } > > +static const struct of_device_id ad7816_of_match[] = { > + { .compatible = "adi,ad7816", }, I think you also need to add: + { .compatible = "adi,ad7817", }, + { .compatible = "adi,ad7818", }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, ad7816_of_match); > + > static const struct spi_device_id ad7816_id[] = { > { "ad7816", ID_AD7816 }, > { "ad7817", ID_AD7817 }, > @@ -434,6 +440,7 @@ MODULE_DEVICE_TABLE(spi, ad7816_id); > static struct spi_driver ad7816_driver = { > .driver = { > .name = "ad7816", > + .of_match_table = of_match_ptr(ad7816_of_match), > }, > .probe = ad7816_probe, > .id_table = ad7816_id,
On Fri, 9 Nov 2018 08:11:57 +0000 "Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote: > On Fri, 2018-11-09 at 13:08 +0530, Nishad Kamdar wrote: > > Add device tree table for matching vendor ID. > > One comment inline for this. > > Thanks > Alex > > > > > Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com> > > --- > > drivers/staging/iio/adc/ad7816.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/staging/iio/adc/ad7816.c > > b/drivers/staging/iio/adc/ad7816.c > > index a2fead85cd46..b8a9149fbac1 100644 > > --- a/drivers/staging/iio/adc/ad7816.c > > +++ b/drivers/staging/iio/adc/ad7816.c > > @@ -422,6 +422,12 @@ static int ad7816_probe(struct spi_device *spi_dev) > > return 0; > > } > > > > +static const struct of_device_id ad7816_of_match[] = { > > + { .compatible = "adi,ad7816", }, > > I think you also need to add: > + { .compatible = "adi,ad7817", }, > + { .compatible = "adi,ad7818", }, > Yes, please add all parts to the dt binding. Particularly as they are functionally different in this case! Please send a v4 for just this patch as the rest have now been applied. Thanks, Jonathan > > + { } > > +}; > > +MODULE_DEVICE_TABLE(of, ad7816_of_match); > > + > > static const struct spi_device_id ad7816_id[] = { > > { "ad7816", ID_AD7816 }, > > { "ad7817", ID_AD7817 }, > > @@ -434,6 +440,7 @@ MODULE_DEVICE_TABLE(spi, ad7816_id); > > static struct spi_driver ad7816_driver = { > > .driver = { > > .name = "ad7816", > > + .of_match_table = of_match_ptr(ad7816_of_match), > > }, > > .probe = ad7816_probe, > > .id_table = ad7816_id,
On Fri, Nov 09, 2018 at 08:11:57AM +0000, Ardelean, Alexandru wrote: > On Fri, 2018-11-09 at 13:08 +0530, Nishad Kamdar wrote: > > Add device tree table for matching vendor ID. > > One comment inline for this. > > Thanks > Alex > > > > > Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com> > > --- > > drivers/staging/iio/adc/ad7816.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/staging/iio/adc/ad7816.c > > b/drivers/staging/iio/adc/ad7816.c > > index a2fead85cd46..b8a9149fbac1 100644 > > --- a/drivers/staging/iio/adc/ad7816.c > > +++ b/drivers/staging/iio/adc/ad7816.c > > @@ -422,6 +422,12 @@ static int ad7816_probe(struct spi_device *spi_dev) > > return 0; > > } > > > > +static const struct of_device_id ad7816_of_match[] = { > > + { .compatible = "adi,ad7816", }, > > I think you also need to add: > + { .compatible = "adi,ad7817", }, > + { .compatible = "adi,ad7818", }, > > > + { } > > +}; > > +MODULE_DEVICE_TABLE(of, ad7816_of_match); > > + > > static const struct spi_device_id ad7816_id[] = { > > { "ad7816", ID_AD7816 }, > > { "ad7817", ID_AD7817 }, > > @@ -434,6 +440,7 @@ MODULE_DEVICE_TABLE(spi, ad7816_id); > > static struct spi_driver ad7816_driver = { > > .driver = { > > .name = "ad7816", > > + .of_match_table = of_match_ptr(ad7816_of_match), > > }, > > .probe = ad7816_probe, > > .id_table = ad7816_id, Ok. I'll do that. Thanks for the review. regards, Nishad
On Sun, Nov 11, 2018 at 12:38:02PM +0000, Jonathan Cameron wrote: > On Fri, 9 Nov 2018 08:11:57 +0000 > "Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote: > > > On Fri, 2018-11-09 at 13:08 +0530, Nishad Kamdar wrote: > > > Add device tree table for matching vendor ID. > > > > One comment inline for this. > > > > Thanks > > Alex > > > > > > > > Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com> > > > --- > > > drivers/staging/iio/adc/ad7816.c | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/drivers/staging/iio/adc/ad7816.c > > > b/drivers/staging/iio/adc/ad7816.c > > > index a2fead85cd46..b8a9149fbac1 100644 > > > --- a/drivers/staging/iio/adc/ad7816.c > > > +++ b/drivers/staging/iio/adc/ad7816.c > > > @@ -422,6 +422,12 @@ static int ad7816_probe(struct spi_device *spi_dev) > > > return 0; > > > } > > > > > > +static const struct of_device_id ad7816_of_match[] = { > > > + { .compatible = "adi,ad7816", }, > > > > I think you also need to add: > > + { .compatible = "adi,ad7817", }, > > + { .compatible = "adi,ad7818", }, > > > > Yes, please add all parts to the dt binding. > Particularly as they are functionally different in this case! > > Please send a v4 for just this patch as the rest have now been > applied. > > Thanks, > > > Jonathan > > > > + { } > > > +}; > > > +MODULE_DEVICE_TABLE(of, ad7816_of_match); > > > + > > > static const struct spi_device_id ad7816_id[] = { > > > { "ad7816", ID_AD7816 }, > > > { "ad7817", ID_AD7817 }, > > > @@ -434,6 +440,7 @@ MODULE_DEVICE_TABLE(spi, ad7816_id); > > > static struct spi_driver ad7816_driver = { > > > .driver = { > > > .name = "ad7816", > > > + .of_match_table = of_match_ptr(ad7816_of_match), > > > }, > > > .probe = ad7816_probe, > > > .id_table = ad7816_id, > Ok. I'll do that. Thanks for the reivew. regards, Nishad
diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7816.c index a2fead85cd46..b8a9149fbac1 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -422,6 +422,12 @@ static int ad7816_probe(struct spi_device *spi_dev) return 0; } +static const struct of_device_id ad7816_of_match[] = { + { .compatible = "adi,ad7816", }, + { } +}; +MODULE_DEVICE_TABLE(of, ad7816_of_match); + static const struct spi_device_id ad7816_id[] = { { "ad7816", ID_AD7816 }, { "ad7817", ID_AD7817 }, @@ -434,6 +440,7 @@ MODULE_DEVICE_TABLE(spi, ad7816_id); static struct spi_driver ad7816_driver = { .driver = { .name = "ad7816", + .of_match_table = of_match_ptr(ad7816_of_match), }, .probe = ad7816_probe, .id_table = ad7816_id,
Add device tree table for matching vendor ID. Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com> --- drivers/staging/iio/adc/ad7816.c | 7 +++++++ 1 file changed, 7 insertions(+)