| Message ID | 4a227eea6fa6aa1648fb0ccba6e924b6f95b2752.1616150619.git.vilhelm.gray@gmail.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Introduce the Counter character device interface | expand |
On Fri, Mar 19, 2021 at 08:00:25PM +0900, William Breathitt Gray wrote: > Add some safety by qualifying the quad8_preset_register_set() function > parameters as const. > > Cc: Syed Nayyar Waris <syednwaris@gmail.com> > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> > --- > drivers/counter/104-quad-8.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c > index 0fd61cc82d30..51fba8cf9c2a 100644 > --- a/drivers/counter/104-quad-8.c > +++ b/drivers/counter/104-quad-8.c > @@ -632,8 +632,8 @@ static ssize_t quad8_count_preset_read(struct counter_device *counter, > return sprintf(buf, "%u\n", priv->preset[count->id]); > } > > -static void quad8_preset_register_set(struct quad8 *priv, int id, > - unsigned int preset) > +static void quad8_preset_register_set(struct quad8 *const priv, const int id, > + const unsigned int preset) > { > const unsigned int base_offset = priv->base + 2 * id; > int i; > -- > 2.30.2 > Acked-by: Syed Nayyar Waris <syednwaris@gmail.com>
diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c index 0fd61cc82d30..51fba8cf9c2a 100644 --- a/drivers/counter/104-quad-8.c +++ b/drivers/counter/104-quad-8.c @@ -632,8 +632,8 @@ static ssize_t quad8_count_preset_read(struct counter_device *counter, return sprintf(buf, "%u\n", priv->preset[count->id]); } -static void quad8_preset_register_set(struct quad8 *priv, int id, - unsigned int preset) +static void quad8_preset_register_set(struct quad8 *const priv, const int id, + const unsigned int preset) { const unsigned int base_offset = priv->base + 2 * id; int i;
Add some safety by qualifying the quad8_preset_register_set() function parameters as const. Cc: Syed Nayyar Waris <syednwaris@gmail.com> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> --- drivers/counter/104-quad-8.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)