| Message ID | 55e59e66824f75ce8ffe58d3463a9cbca56e25ac.1694001462.git.mazziesaccount@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Support ROHM BM1390 pressure sensor | expand |
On Wed, Sep 06, 2023 at 03:37:19PM +0300, Matti Vaittinen wrote: > BM1390GLV-Z is a pressure sensor which performs internal temperature > compensation for the MEMS. Pressure range is from 300 hPa to 1300 hPa > and sample averaging and IIR filtering is built in sensor. Temperature > measurement is also supported. > > Add dt-bindings for the sensor. > > Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> > --- > .../bindings/iio/pressure/rohm,bm1390.yaml | 52 +++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/pressure/rohm,bm1390.yaml > > diff --git a/Documentation/devicetree/bindings/iio/pressure/rohm,bm1390.yaml b/Documentation/devicetree/bindings/iio/pressure/rohm,bm1390.yaml > new file mode 100644 > index 000000000000..d681fdd0f5ea > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/pressure/rohm,bm1390.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/pressure/rohm,bm1390.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ROHM BM1390 pressure sensor > + > +maintainers: > + - Matti Vaittinen <mazziesaccount@gmail.com> > + > +description: | You've got no formatting to preserve the | is not needed. > + BM1390GLV-Z is a pressure sensor which performs internal temperature > + compensation for the MEMS. Pressure range is from 300 hPa to 1300 hPa > + and sample averaging and IIR filtering is built in sensor. nit: "built in to the sensor." or just "built-in." Otherwise this seems alright to me, Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > Temperature > + measurement is also supported. > + > +properties: > + compatible: > + const: rohm,bm1390glv-z > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + vdd-supply: true > + > +required: > + - compatible > + - reg > + - vdd-supply > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + pressure-sensor@5d { > + compatible = "kionix,kx022a"; > + reg = <0x5d>; > + > + interrupt-parent = <&gpio1>; > + interrupts = <29 IRQ_TYPE_LEVEL_LOW>; > + > + vdd-supply = <&vdd>; > + }; > + }; > -- > 2.41.0 > > > -- > Matti Vaittinen, Linux device drivers > ROHM Semiconductors, Finland SWDC > Kiviharjunlenkki 1E > 90220 OULU > FINLAND > > ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ > Simon says - in Latin please. > ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ > Thanks to Simon Glass for the translation =]
On 9/7/23 13:08, Conor Dooley wrote: > On Wed, Sep 06, 2023 at 03:37:19PM +0300, Matti Vaittinen wrote: >> BM1390GLV-Z is a pressure sensor which performs internal temperature >> compensation for the MEMS. Pressure range is from 300 hPa to 1300 hPa >> and sample averaging and IIR filtering is built in sensor. Temperature >> measurement is also supported. >> >> Add dt-bindings for the sensor. >> >> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> >> --- >> .../bindings/iio/pressure/rohm,bm1390.yaml | 52 +++++++++++++++++++ >> 1 file changed, 52 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/iio/pressure/rohm,bm1390.yaml >> >> diff --git a/Documentation/devicetree/bindings/iio/pressure/rohm,bm1390.yaml b/Documentation/devicetree/bindings/iio/pressure/rohm,bm1390.yaml >> new file mode 100644 >> index 000000000000..d681fdd0f5ea >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/iio/pressure/rohm,bm1390.yaml >> @@ -0,0 +1,52 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/iio/pressure/rohm,bm1390.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: ROHM BM1390 pressure sensor >> + >> +maintainers: >> + - Matti Vaittinen <mazziesaccount@gmail.com> >> + >> +description: | > > You've got no formatting to preserve the | is not needed. > >> + BM1390GLV-Z is a pressure sensor which performs internal temperature >> + compensation for the MEMS. Pressure range is from 300 hPa to 1300 hPa >> + and sample averaging and IIR filtering is built in sensor. > > nit: "built in to the sensor." or just "built-in." > > Otherwise this seems alright to me, > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Thanks Conor! I'll fix them for v2 :) Yours, -- Matti
Hi Matti, just accidentally saw your series. On Wed, Sep 06, 2023 at 03:37:19PM +0300, Matti Vaittinen wrote: > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + pressure-sensor@5d { > + compatible = "kionix,kx022a"; I think the compatible in the example is not right. Best Regards, Benjamin
On 9/8/23 10:14, Benjamin Bara wrote: > Hi Matti, > > just accidentally saw your series. > > On Wed, Sep 06, 2023 at 03:37:19PM +0300, Matti Vaittinen wrote: >> +examples: >> + - | >> + #include <dt-bindings/interrupt-controller/irq.h> >> + i2c { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + pressure-sensor@5d { >> + compatible = "kionix,kx022a"; > > I think the compatible in the example is not right. Indeed it's not! Great catch! Thanks! Must be fixed in v2. Oh - and long time no see - I hope you had a great summer :) I'm waiting to see you continuing the regulator stuff ;) Yours, -- Matti
diff --git a/Documentation/devicetree/bindings/iio/pressure/rohm,bm1390.yaml b/Documentation/devicetree/bindings/iio/pressure/rohm,bm1390.yaml new file mode 100644 index 000000000000..d681fdd0f5ea --- /dev/null +++ b/Documentation/devicetree/bindings/iio/pressure/rohm,bm1390.yaml @@ -0,0 +1,52 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/pressure/rohm,bm1390.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ROHM BM1390 pressure sensor + +maintainers: + - Matti Vaittinen <mazziesaccount@gmail.com> + +description: | + BM1390GLV-Z is a pressure sensor which performs internal temperature + compensation for the MEMS. Pressure range is from 300 hPa to 1300 hPa + and sample averaging and IIR filtering is built in sensor. Temperature + measurement is also supported. + +properties: + compatible: + const: rohm,bm1390glv-z + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + vdd-supply: true + +required: + - compatible + - reg + - vdd-supply + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + pressure-sensor@5d { + compatible = "kionix,kx022a"; + reg = <0x5d>; + + interrupt-parent = <&gpio1>; + interrupts = <29 IRQ_TYPE_LEVEL_LOW>; + + vdd-supply = <&vdd>; + }; + };
BM1390GLV-Z is a pressure sensor which performs internal temperature compensation for the MEMS. Pressure range is from 300 hPa to 1300 hPa and sample averaging and IIR filtering is built in sensor. Temperature measurement is also supported. Add dt-bindings for the sensor. Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> --- .../bindings/iio/pressure/rohm,bm1390.yaml | 52 +++++++++++++++++++ 1 file changed, 52 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/pressure/rohm,bm1390.yaml