| Message ID | 5d00983e4fb2869fd3152a609c1fffe7616c4963.1530268235.git.nikolaus.voss@loewensteinmedical.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, 29 Jun 2018 10:45:54 +0200 Nikolaus Voss <nikolaus.voss@loewensteinmedical.de> wrote: > I2C device ID table strings should really match the DT compatible > strings (without the manufacturer prefix) to avoid confusion. This is > especially reasonable when using ACPI PRP0001 HID /DT compatibility > entries along with the DT compatible property in DSD which is > used as a modalias (with manufacturer prefix stripped off) by the ACPI > layer and thus as i2c_board_info->type by the I2C layer. > > Signed-off-by: Nikolaus Voss <nikolaus.voss@loewensteinmedical.de> Nice to have I agree. However, it's an ABI change as this is exposed via /sys/bus/iio/devices/iio:\deviceN/name and is used by lots of scripts etc to identify the device. So we are stuck with it. There is a reason we've kept this mess here for quite some time. Jonathan > --- > drivers/iio/accel/st_accel.h | 32 ++++++++++++++++---------------- > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git a/drivers/iio/accel/st_accel.h b/drivers/iio/accel/st_accel.h > index 2f931e4837e5..be4a4a41f849 100644 > --- a/drivers/iio/accel/st_accel.h > +++ b/drivers/iio/accel/st_accel.h > @@ -37,23 +37,23 @@ enum st_accel_type { > ST_ACCEL_MAX, > }; > > -#define H3LIS331DL_ACCEL_DEV_NAME "h3lis331dl_accel" > -#define LIS3LV02DL_ACCEL_DEV_NAME "lis3lv02dl_accel" > -#define LSM303DLHC_ACCEL_DEV_NAME "lsm303dlhc_accel" > -#define LIS3DH_ACCEL_DEV_NAME "lis3dh" > -#define LSM330D_ACCEL_DEV_NAME "lsm330d_accel" > -#define LSM330DL_ACCEL_DEV_NAME "lsm330dl_accel" > -#define LSM330DLC_ACCEL_DEV_NAME "lsm330dlc_accel" > -#define LIS331DL_ACCEL_DEV_NAME "lis331dl_accel" > -#define LIS331DLH_ACCEL_DEV_NAME "lis331dlh" > -#define LSM303DL_ACCEL_DEV_NAME "lsm303dl_accel" > -#define LSM303DLH_ACCEL_DEV_NAME "lsm303dlh_accel" > -#define LSM303DLM_ACCEL_DEV_NAME "lsm303dlm_accel" > -#define LSM330_ACCEL_DEV_NAME "lsm330_accel" > -#define LSM303AGR_ACCEL_DEV_NAME "lsm303agr_accel" > -#define LIS2DH12_ACCEL_DEV_NAME "lis2dh12_accel" > +#define H3LIS331DL_ACCEL_DEV_NAME "h3lis331dl-accel" > +#define LIS3LV02DL_ACCEL_DEV_NAME "lis3lv02dl-accel" > +#define LSM303DLHC_ACCEL_DEV_NAME "lsm303dlhc-accel" > +#define LIS3DH_ACCEL_DEV_NAME "lis3dh-accel" > +#define LSM330D_ACCEL_DEV_NAME "lsm330d-accel" > +#define LSM330DL_ACCEL_DEV_NAME "lsm330dl-accel" > +#define LSM330DLC_ACCEL_DEV_NAME "lsm330dlc-accel" > +#define LIS331DL_ACCEL_DEV_NAME "lis331dl-accel" > +#define LIS331DLH_ACCEL_DEV_NAME "lis331dlh-accel" > +#define LSM303DL_ACCEL_DEV_NAME "lsm303dl-accel" > +#define LSM303DLH_ACCEL_DEV_NAME "lsm303dlh-accel" > +#define LSM303DLM_ACCEL_DEV_NAME "lsm303dlm-accel" > +#define LSM330_ACCEL_DEV_NAME "lsm330-accel" > +#define LSM303AGR_ACCEL_DEV_NAME "lsm303agr-accel" > +#define LIS2DH12_ACCEL_DEV_NAME "lis2dh12-accel" > #define LIS3L02DQ_ACCEL_DEV_NAME "lis3l02dq" > -#define LNG2DM_ACCEL_DEV_NAME "lng2dm" > +#define LNG2DM_ACCEL_DEV_NAME "lng2dm-accel" > #define LIS2DW12_ACCEL_DEV_NAME "lis2dw12" > #define LIS3DHH_ACCEL_DEV_NAME "lis3dhh" > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, 30 Jun 2018, Jonathan Cameron wrote: > On Fri, 29 Jun 2018 10:45:54 +0200 > Nikolaus Voss <nikolaus.voss@loewensteinmedical.de> wrote: > >> I2C device ID table strings should really match the DT compatible >> strings (without the manufacturer prefix) to avoid confusion. This is >> especially reasonable when using ACPI PRP0001 HID /DT compatibility >> entries along with the DT compatible property in DSD which is >> used as a modalias (with manufacturer prefix stripped off) by the ACPI >> layer and thus as i2c_board_info->type by the I2C layer. >> >> Signed-off-by: Nikolaus Voss <nikolaus.voss@loewensteinmedical.de> > > Nice to have I agree. However, it's an ABI change as this is exposed > via > /sys/bus/iio/devices/iio:\deviceN/name and is used by lots of scripts > etc to identify the device. So we are stuck with it. > > There is a reason we've kept this mess here for quite some time. Ok, I feared there could be some reason ;-). Tell me, if you want me to respin anything... Niko -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/iio/accel/st_accel.h b/drivers/iio/accel/st_accel.h index 2f931e4837e5..be4a4a41f849 100644 --- a/drivers/iio/accel/st_accel.h +++ b/drivers/iio/accel/st_accel.h @@ -37,23 +37,23 @@ enum st_accel_type { ST_ACCEL_MAX, }; -#define H3LIS331DL_ACCEL_DEV_NAME "h3lis331dl_accel" -#define LIS3LV02DL_ACCEL_DEV_NAME "lis3lv02dl_accel" -#define LSM303DLHC_ACCEL_DEV_NAME "lsm303dlhc_accel" -#define LIS3DH_ACCEL_DEV_NAME "lis3dh" -#define LSM330D_ACCEL_DEV_NAME "lsm330d_accel" -#define LSM330DL_ACCEL_DEV_NAME "lsm330dl_accel" -#define LSM330DLC_ACCEL_DEV_NAME "lsm330dlc_accel" -#define LIS331DL_ACCEL_DEV_NAME "lis331dl_accel" -#define LIS331DLH_ACCEL_DEV_NAME "lis331dlh" -#define LSM303DL_ACCEL_DEV_NAME "lsm303dl_accel" -#define LSM303DLH_ACCEL_DEV_NAME "lsm303dlh_accel" -#define LSM303DLM_ACCEL_DEV_NAME "lsm303dlm_accel" -#define LSM330_ACCEL_DEV_NAME "lsm330_accel" -#define LSM303AGR_ACCEL_DEV_NAME "lsm303agr_accel" -#define LIS2DH12_ACCEL_DEV_NAME "lis2dh12_accel" +#define H3LIS331DL_ACCEL_DEV_NAME "h3lis331dl-accel" +#define LIS3LV02DL_ACCEL_DEV_NAME "lis3lv02dl-accel" +#define LSM303DLHC_ACCEL_DEV_NAME "lsm303dlhc-accel" +#define LIS3DH_ACCEL_DEV_NAME "lis3dh-accel" +#define LSM330D_ACCEL_DEV_NAME "lsm330d-accel" +#define LSM330DL_ACCEL_DEV_NAME "lsm330dl-accel" +#define LSM330DLC_ACCEL_DEV_NAME "lsm330dlc-accel" +#define LIS331DL_ACCEL_DEV_NAME "lis331dl-accel" +#define LIS331DLH_ACCEL_DEV_NAME "lis331dlh-accel" +#define LSM303DL_ACCEL_DEV_NAME "lsm303dl-accel" +#define LSM303DLH_ACCEL_DEV_NAME "lsm303dlh-accel" +#define LSM303DLM_ACCEL_DEV_NAME "lsm303dlm-accel" +#define LSM330_ACCEL_DEV_NAME "lsm330-accel" +#define LSM303AGR_ACCEL_DEV_NAME "lsm303agr-accel" +#define LIS2DH12_ACCEL_DEV_NAME "lis2dh12-accel" #define LIS3L02DQ_ACCEL_DEV_NAME "lis3l02dq" -#define LNG2DM_ACCEL_DEV_NAME "lng2dm" +#define LNG2DM_ACCEL_DEV_NAME "lng2dm-accel" #define LIS2DW12_ACCEL_DEV_NAME "lis2dw12" #define LIS3DHH_ACCEL_DEV_NAME "lis3dhh"
I2C device ID table strings should really match the DT compatible strings (without the manufacturer prefix) to avoid confusion. This is especially reasonable when using ACPI PRP0001 HID /DT compatibility entries along with the DT compatible property in DSD which is used as a modalias (with manufacturer prefix stripped off) by the ACPI layer and thus as i2c_board_info->type by the I2C layer. Signed-off-by: Nikolaus Voss <nikolaus.voss@loewensteinmedical.de> --- drivers/iio/accel/st_accel.h | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-)