diff mbox series

[v2] iio: imu: inv_mpu6050: add debugfs register r/w interface

Message ID 5e7dfb41.1c69fb81.cc4bb.042f@mx.google.com (mailing list archive)
State Under Review
Delegated to: Jonathan Cameron
Headers show
Series [v2] iio: imu: inv_mpu6050: add debugfs register r/w interface | expand

Commit Message

Rohit Sarkar March 27, 2020, 1:10 p.m. UTC
The debugfs interface provides direct access to read and write device
registers if debugfs is enabled.

Signed-off-by: Rohit Sarkar <rohitsarkar5398@gmail.com>
---
Changelog v1->v2
* grab a lock to protect driver state
* add a comma at the end of structure member initialisation

 drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

Comments

Andy Shevchenko March 27, 2020, 1:19 p.m. UTC | #1
On Fri, Mar 27, 2020 at 06:40:23PM +0530, Rohit Sarkar wrote:
> The debugfs interface provides direct access to read and write device
> registers if debugfs is enabled.
> 
> Signed-off-by: Rohit Sarkar <rohitsarkar5398@gmail.com>
> ---
> Changelog v1->v2
> * grab a lock to protect driver state
> * add a comma at the end of structure member initialisation
> 
>  drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> index 7cb9ff3d3e94..381a3fb09858 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> @@ -1248,12 +1248,31 @@ static const struct attribute_group inv_attribute_group = {
>  	.attrs = inv_attributes
>  };
>  
> +static int inv_mpu6050_reg_access(struct iio_dev *indio_dev,
> +				  unsigned int reg,
> +				  unsigned int writeval,
> +				  unsigned int *readval)
> +{
> +	struct inv_mpu6050_state *st = iio_priv(indio_dev);

> +	int ret = 0;

Assignment is redundant, but I think maintainers may update this when applying.

> +
> +	mutex_lock(&st->lock);
> +	if (readval)
> +		ret = regmap_read(st->map, reg, readval);
> +	else
> +		ret = regmap_write(st->map, reg, writeval);
> +	mutex_unlock(&st->lock);
> +
> +	return ret;
> +}
> +
>  static const struct iio_info mpu_info = {
>  	.read_raw = &inv_mpu6050_read_raw,
>  	.write_raw = &inv_mpu6050_write_raw,
>  	.write_raw_get_fmt = &inv_write_raw_get_fmt,
>  	.attrs = &inv_attribute_group,
>  	.validate_trigger = inv_mpu6050_validate_trigger,
> +	.debugfs_reg_access = &inv_mpu6050_reg_access,
>  };
>  
>  /**
> -- 
> 2.23.0.385.gbc12974a89
>
Andy Shevchenko March 27, 2020, 1:19 p.m. UTC | #2
On Fri, Mar 27, 2020 at 06:40:23PM +0530, Rohit Sarkar wrote:
> The debugfs interface provides direct access to read and write device
> registers if debugfs is enabled.

FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Signed-off-by: Rohit Sarkar <rohitsarkar5398@gmail.com>
> ---
> Changelog v1->v2
> * grab a lock to protect driver state
> * add a comma at the end of structure member initialisation
> 
>  drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> index 7cb9ff3d3e94..381a3fb09858 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> @@ -1248,12 +1248,31 @@ static const struct attribute_group inv_attribute_group = {
>  	.attrs = inv_attributes
>  };
>  
> +static int inv_mpu6050_reg_access(struct iio_dev *indio_dev,
> +				  unsigned int reg,
> +				  unsigned int writeval,
> +				  unsigned int *readval)
> +{
> +	struct inv_mpu6050_state *st = iio_priv(indio_dev);
> +	int ret = 0;
> +
> +	mutex_lock(&st->lock);
> +	if (readval)
> +		ret = regmap_read(st->map, reg, readval);
> +	else
> +		ret = regmap_write(st->map, reg, writeval);
> +	mutex_unlock(&st->lock);
> +
> +	return ret;
> +}
> +
>  static const struct iio_info mpu_info = {
>  	.read_raw = &inv_mpu6050_read_raw,
>  	.write_raw = &inv_mpu6050_write_raw,
>  	.write_raw_get_fmt = &inv_write_raw_get_fmt,
>  	.attrs = &inv_attribute_group,
>  	.validate_trigger = inv_mpu6050_validate_trigger,
> +	.debugfs_reg_access = &inv_mpu6050_reg_access,
>  };
>  
>  /**
> -- 
> 2.23.0.385.gbc12974a89
>
Jean-Baptiste Maneyrol March 27, 2020, 2:08 p.m. UTC | #3
Hello,

thanks, it's OK for me.

Acked-by: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>

Best regards,
JB



From: Rohit Sarkar <rohitsarkar5398@gmail.com>

Sent: Friday, March 27, 2020 14:10

To: linux-iio@vger.kernel.org <linux-iio@vger.kernel.org>

Cc: Jonathan Cameron <jic23@kernel.org>; Hartmut Knaack <knaack.h@gmx.de>; Lars-Peter Clausen <lars@metafoo.de>; Peter Meerwald-Stadler <pmeerw@pmeerw.net>; Jean-Baptiste Maneyrol <JManeyrol@invensense.com>; Linus Walleij <linus.walleij@linaro.org>;
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>; linux-iio@vger.kernel.org <linux-iio@vger.kernel.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>

Subject: [PATCH v2] iio: imu: inv_mpu6050: add debugfs register r/w interface

 


 CAUTION: This email originated from outside of the organization. Please make sure the sender is who they say they are and do not click links or open attachments unless you recognize the sender and know the content is safe.



The debugfs interface provides direct access to read and write device

registers if debugfs is enabled.



Signed-off-by: Rohit Sarkar <rohitsarkar5398@gmail.com>

---

Changelog v1->v2

* grab a lock to protect driver state

* add a comma at the end of structure member initialisation



 drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 19 +++++++++++++++++++

 1 file changed, 19 insertions(+)



diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c

index 7cb9ff3d3e94..381a3fb09858 100644

--- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c

+++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c

@@ -1248,12 +1248,31 @@ static const struct attribute_group inv_attribute_group = {

         .attrs = inv_attributes

 };

 

+static int inv_mpu6050_reg_access(struct iio_dev *indio_dev,

+                                 unsigned int reg,

+                                 unsigned int writeval,

+                                 unsigned int *readval)

+{

+       struct inv_mpu6050_state *st = iio_priv(indio_dev);

+       int ret = 0;

+

+       mutex_lock(&st->lock);

+       if (readval)

+               ret = regmap_read(st->map, reg, readval);

+       else

+               ret = regmap_write(st->map, reg, writeval);

+       mutex_unlock(&st->lock);

+

+       return ret;

+}

+

 static const struct iio_info mpu_info = {

         .read_raw = &inv_mpu6050_read_raw,

         .write_raw = &inv_mpu6050_write_raw,

         .write_raw_get_fmt = &inv_write_raw_get_fmt,

         .attrs = &inv_attribute_group,

         .validate_trigger = inv_mpu6050_validate_trigger,

+       .debugfs_reg_access = &inv_mpu6050_reg_access,

 };

 

 /**
Jonathan Cameron March 28, 2020, 5:45 p.m. UTC | #4
On Fri, 27 Mar 2020 15:19:01 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Fri, Mar 27, 2020 at 06:40:23PM +0530, Rohit Sarkar wrote:
> > The debugfs interface provides direct access to read and write device
> > registers if debugfs is enabled.
> > 
> > Signed-off-by: Rohit Sarkar <rohitsarkar5398@gmail.com>
> > ---
> > Changelog v1->v2
> > * grab a lock to protect driver state
> > * add a comma at the end of structure member initialisation
> > 
> >  drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> > 
> > diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> > index 7cb9ff3d3e94..381a3fb09858 100644
> > --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> > +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> > @@ -1248,12 +1248,31 @@ static const struct attribute_group inv_attribute_group = {
> >  	.attrs = inv_attributes
> >  };
> >  
> > +static int inv_mpu6050_reg_access(struct iio_dev *indio_dev,
> > +				  unsigned int reg,
> > +				  unsigned int writeval,
> > +				  unsigned int *readval)
> > +{
> > +	struct inv_mpu6050_state *st = iio_priv(indio_dev);  
> 
> > +	int ret = 0;  
> 
> Assignment is redundant, but I think maintainers may update this when applying.

Fixed up and applied to the togreg branch of iio.git and pushed
out as testing for the autobuilders to play with it.

Jonathan

> 
> > +
> > +	mutex_lock(&st->lock);
> > +	if (readval)
> > +		ret = regmap_read(st->map, reg, readval);
> > +	else
> > +		ret = regmap_write(st->map, reg, writeval);
> > +	mutex_unlock(&st->lock);
> > +
> > +	return ret;
> > +}
> > +
> >  static const struct iio_info mpu_info = {
> >  	.read_raw = &inv_mpu6050_read_raw,
> >  	.write_raw = &inv_mpu6050_write_raw,
> >  	.write_raw_get_fmt = &inv_write_raw_get_fmt,
> >  	.attrs = &inv_attribute_group,
> >  	.validate_trigger = inv_mpu6050_validate_trigger,
> > +	.debugfs_reg_access = &inv_mpu6050_reg_access,
> >  };
> >  
> >  /**
> > -- 
> > 2.23.0.385.gbc12974a89
> >   
>
diff mbox series

Patch

diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
index 7cb9ff3d3e94..381a3fb09858 100644
--- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
+++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
@@ -1248,12 +1248,31 @@  static const struct attribute_group inv_attribute_group = {
 	.attrs = inv_attributes
 };
 
+static int inv_mpu6050_reg_access(struct iio_dev *indio_dev,
+				  unsigned int reg,
+				  unsigned int writeval,
+				  unsigned int *readval)
+{
+	struct inv_mpu6050_state *st = iio_priv(indio_dev);
+	int ret = 0;
+
+	mutex_lock(&st->lock);
+	if (readval)
+		ret = regmap_read(st->map, reg, readval);
+	else
+		ret = regmap_write(st->map, reg, writeval);
+	mutex_unlock(&st->lock);
+
+	return ret;
+}
+
 static const struct iio_info mpu_info = {
 	.read_raw = &inv_mpu6050_read_raw,
 	.write_raw = &inv_mpu6050_write_raw,
 	.write_raw_get_fmt = &inv_write_raw_get_fmt,
 	.attrs = &inv_attribute_group,
 	.validate_trigger = inv_mpu6050_validate_trigger,
+	.debugfs_reg_access = &inv_mpu6050_reg_access,
 };
 
 /**