diff mbox series

[5/3] dt-bindings: iio: io-channel-mux: allow duplicate channel, labels

Message ID 815d858d-3c67-c184-2413-9d6b487a853e@axentia.se (mailing list archive)
State Accepted
Headers show
Series Add settle time support to iio-mux | expand

Commit Message

Peter Rosin Oct. 8, 2021, 10:11 p.m. UTC
This is needed since an empty channel label is used to indicate an
unused channel, and there can be more that one of those.

Fixes the following problem reported by dtbs_check:
envelope-detector-mux: channels: ['', '', 'sync-1', 'in', 'out', 'sync-2', 'sys-reg', 'ana-reg'] has non-unique elements
	arch/arm/boot/dts/at91-tse850-3.dt.yaml

Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Peter Rosin <peda@axentia.se>
---
 .../devicetree/bindings/iio/multiplexer/io-channel-mux.yaml  | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Rob Herring Oct. 19, 2021, 9:25 p.m. UTC | #1
On Sat, 09 Oct 2021 00:11:30 +0200, Peter Rosin wrote:
> This is needed since an empty channel label is used to indicate an
> unused channel, and there can be more that one of those.
> 
> Fixes the following problem reported by dtbs_check:
> envelope-detector-mux: channels: ['', '', 'sync-1', 'in', 'out', 'sync-2', 'sys-reg', 'ana-reg'] has non-unique elements
> 	arch/arm/boot/dts/at91-tse850-3.dt.yaml
> 
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
>  .../devicetree/bindings/iio/multiplexer/io-channel-mux.yaml  | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>
Jonathan Cameron Oct. 20, 2021, 4:49 p.m. UTC | #2
On Tue, 19 Oct 2021 16:25:49 -0500
Rob Herring <robh@kernel.org> wrote:

> On Sat, 09 Oct 2021 00:11:30 +0200, Peter Rosin wrote:
> > This is needed since an empty channel label is used to indicate an
> > unused channel, and there can be more that one of those.
> > 
> > Fixes the following problem reported by dtbs_check:
> > envelope-detector-mux: channels: ['', '', 'sync-1', 'in', 'out', 'sync-2', 'sys-reg', 'ana-reg'] has non-unique elements
> > 	arch/arm/boot/dts/at91-tse850-3.dt.yaml
> > 
> > Suggested-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Peter Rosin <peda@axentia.se>
> > ---
> >  .../devicetree/bindings/iio/multiplexer/io-channel-mux.yaml  | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >   
> 
> Acked-by: Rob Herring <robh@kernel.org>

4 + 5 applied to the togreg branch of iio.git and pushed out as
testing for 0-day to give it a dry run.

Thanks,

Jonathan
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/multiplexer/io-channel-mux.yaml b/Documentation/devicetree/bindings/iio/multiplexer/io-channel-mux.yaml
index 80b6229a6fad..611ad4444cf0 100644
--- a/Documentation/devicetree/bindings/iio/multiplexer/io-channel-mux.yaml
+++ b/Documentation/devicetree/bindings/iio/multiplexer/io-channel-mux.yaml
@@ -35,9 +35,10 @@  properties:
   mux-control-names: true
 
   channels:
-    $ref: /schemas/types.yaml#/definitions/string-array
+    $ref: /schemas/types.yaml#/definitions/non-unique-string-array
     description:
-      List of strings, labeling the mux controller states.
+      List of strings, labeling the mux controller states. An empty
+      string for a state means that the channel is not available.
 
   settle-time-us:
     default: 0