| Message ID | 86blknd0id.fsf@norphonic.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v9,1/2] iio: humidity: Add TI HDC20x0 support | expand |
On Fri, 10 Jul 2020 14:20:58 +0200 Eugene Zaikonnikov <ez@norphonic.com> wrote: > Add device tree bindings for HDC2010/HDC2080 family of humidity and > temperature sensors. > As Andy mentioned for patch 1 please avoid attachments. > Changes from v8: > - document the use of reg > - change the license terms to GPL-2.0-only The change log should be after the --- (which isn't here because of the attachments issue). This is so we don't track a bunch of change logs in the eventual git log. They tend not to be of much interest once a patch has merged. If there is stuff in there of interest, it should usually be added to the patch description itself (e.g. some design decision or similar). The license terms seem to be dual with BSD, which is good, but not what the change log says! I've pasted in the actual patch content below, so others can easily review this version. Thanks, Jonathan > > Signed-off-by: Eugene Zaikonnikov <ez@norphonic.com> > > diff -uprN linux-5.3.8/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml linux-5.3.8_docs/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml > --- linux-5.3.8/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml 1970-01-01 01:00:00.000000000 +0100 > +++ linux-5.3.8_docs/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml 2020-07-10 13:08:46.818076734 +0200 > @@ -0,0 +1,45 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/humidity/ti,hdc2010.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HDC2010/HDC2080 humidity and temperature iio sensors > + > +maintainers: > + - Eugene Zaikonnikov <ez@norophonic.com> > + > +description: | > + Relative humidity and tempereature sensors on I2C bus > + > + Datasheets are available at: > + http://www.ti.com/product/HDC2010/datasheet > + http://www.ti.com/product/HDC2080/datasheet > + > +properties: > + compatible: > + enum: > + - ti,hdc2010 > + - ti,hdc2080 > + > + vdd-supply: > + maxItems: 1 > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +examples: > + - | > + i2c0 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + humidity@40 { > + compatible = "ti,hdc2010"; > + reg = <0x40>; > + }; > + };
On Sun, Jul 12, 2020 at 11:59:20AM +0100, Jonathan Cameron wrote: > On Fri, 10 Jul 2020 14:20:58 +0200 > Eugene Zaikonnikov <ez@norphonic.com> wrote: > > > Add device tree bindings for HDC2010/HDC2080 family of humidity and > > temperature sensors. > > > > As Andy mentioned for patch 1 please avoid attachments. > > > Changes from v8: > > - document the use of reg > > - change the license terms to GPL-2.0-only > > The change log should be after the --- (which isn't here because > of the attachments issue). This is so we don't track a bunch of change > logs in the eventual git log. They tend not to be of much interest once > a patch has merged. If there is stuff in there of interest, it should usually > be added to the patch description itself (e.g. some design decision or similar). > > The license terms seem to be dual with BSD, which is good, but > not what the change log says! > > I've pasted in the actual patch content below, so others can easily > review this version. Other than those issues, Reviewed-by: Rob Herring <robh@kernel.org>
diff -uprN linux-5.3.8/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml linux-5.3.8_docs/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml --- linux-5.3.8/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml 1970-01-01 01:00:00.000000000 +0100 +++ linux-5.3.8_docs/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml 2020-07-10 13:08:46.818076734 +0200 @@ -0,0 +1,45 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/humidity/ti,hdc2010.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: HDC2010/HDC2080 humidity and temperature iio sensors + +maintainers: + - Eugene Zaikonnikov <ez@norophonic.com> + +description: | + Relative humidity and tempereature sensors on I2C bus + + Datasheets are available at: + http://www.ti.com/product/HDC2010/datasheet + http://www.ti.com/product/HDC2080/datasheet + +properties: + compatible: + enum: + - ti,hdc2010 + - ti,hdc2080 + + vdd-supply: + maxItems: 1 + + reg: + maxItems: 1 + +required: + - compatible + - reg + +examples: + - | + i2c0 { + #address-cells = <1>; + #size-cells = <0>; + + humidity@40 { + compatible = "ti,hdc2010"; + reg = <0x40>; + }; + };
Add device tree bindings for HDC2010/HDC2080 family of humidity and temperature sensors. Changes from v8: - document the use of reg - change the license terms to GPL-2.0-only Signed-off-by: Eugene Zaikonnikov <ez@norphonic.com>