| Message ID | 9129a6c25f772bdfba28d556190e5511c7005e8a.1584518000.git.nish.malpani25@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: light: tsl2563: Fix checkpatch warnings | expand |
On Wed, 2020-03-18 at 13:33 +0530, Nishant Malpani wrote: > This patch wraps the comment description at 75 chars. Fixes the > following warning generated by checkpatch.pl: > > WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) Please do not scan files as patches. checkpatch does not emit this message on a file when used properly with the -f option. > diff --git a/drivers/iio/light/tsl2563.c b/drivers/iio/light/tsl2563.c [] > @@ -222,9 +222,9 @@ static int tsl2563_read_id(struct tsl2563_chip *chip, u8 *id) > } > > /* > - * "Normalized" ADC value is one obtained with 400ms of integration time and > - * 16x gain. This function returns the number of bits of shift needed to > - * convert between normalized values and HW values obtained using given > + * "Normalized" ADC value is one obtained with 400ms of integration time > + * and 16x gain. This function returns the number of bits of shift needed > + * to convert between normalized values and HW values obtained using given > * timing and gain settings. > */ > static int tsl2563_adc_shiftbits(u8 timing)
On 21/03/20 5:21 pm, Joe Perches wrote: > On Wed, 2020-03-18 at 13:33 +0530, Nishant Malpani wrote: >> This patch wraps the comment description at 75 chars. Fixes the >> following warning generated by checkpatch.pl: >> >> WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) > > Please do not scan files as patches. > > checkpatch does not emit this message on a file > when used properly with the -f option. > You're right, Joe. I had used checkpatch.pl without the -f option on a file, ergo giving me the aforementioned warning. My bad, I shall refrain from not doing this in the future. Thank you and Jonathan for correcting me. With regards, Nishant Malpani >> diff --git a/drivers/iio/light/tsl2563.c b/drivers/iio/light/tsl2563.c > [] >> @@ -222,9 +222,9 @@ static int tsl2563_read_id(struct tsl2563_chip *chip, u8 *id) >> } >> >> /* >> - * "Normalized" ADC value is one obtained with 400ms of integration time and >> - * 16x gain. This function returns the number of bits of shift needed to >> - * convert between normalized values and HW values obtained using given >> + * "Normalized" ADC value is one obtained with 400ms of integration time >> + * and 16x gain. This function returns the number of bits of shift needed >> + * to convert between normalized values and HW values obtained using given >> * timing and gain settings. >> */ >> static int tsl2563_adc_shiftbits(u8 timing) >
diff --git a/drivers/iio/light/tsl2563.c b/drivers/iio/light/tsl2563.c index d8c40a83097d..260b38ee81f7 100644 --- a/drivers/iio/light/tsl2563.c +++ b/drivers/iio/light/tsl2563.c @@ -222,9 +222,9 @@ static int tsl2563_read_id(struct tsl2563_chip *chip, u8 *id) } /* - * "Normalized" ADC value is one obtained with 400ms of integration time and - * 16x gain. This function returns the number of bits of shift needed to - * convert between normalized values and HW values obtained using given + * "Normalized" ADC value is one obtained with 400ms of integration time + * and 16x gain. This function returns the number of bits of shift needed + * to convert between normalized values and HW values obtained using given * timing and gain settings. */ static int tsl2563_adc_shiftbits(u8 timing)
This patch wraps the comment description at 75 chars. Fixes the following warning generated by checkpatch.pl: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) Signed-off-by: Nishant Malpani <nish.malpani25@gmail.com> --- drivers/iio/light/tsl2563.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)