From patchwork Mon Apr 17 09:19:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 13213500 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA28CC77B70 for ; Mon, 17 Apr 2023 09:20:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229833AbjDQJUW (ORCPT ); Mon, 17 Apr 2023 05:20:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230046AbjDQJUV (ORCPT ); Mon, 17 Apr 2023 05:20:21 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8971421C; Mon, 17 Apr 2023 02:20:05 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2a8b62cfaceso11775461fa.2; Mon, 17 Apr 2023 02:20:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681723204; x=1684315204; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RgrbmJtSLO84P/9uImcl/ILG4CYzql2cJa7HytOmSio=; b=EOlZMB3Qua8VqDYh8UvRT26spK208uMi3/t4NKBjbTh+tGhzY0xCMaEgBBGAOek8wM UCs7XiVcnOkwTY8MhYnjdV7sT6VQlTMnk1BbDzWtTECYhe6fALnLvCX+jrTEMWc3bPl+ zwdX7oO8/swY+9HjJR8Q7f47VkKh5SUGaEOEUffLnXtQllB+u850iuAmfFgPmxNmXEdZ 0t3Z0k8QxnV5cu5EbsC0FonmoTb6C8NV/WZX8uDZ2LXL7x84BMxa1AuERDxikpXx8K+9 8aPys25Ho2rj7mnUD3tvl2vj5p9ZBpXtFRal0Atbfo1YX3JLGOfXniOE3B/emUWDndks 1A4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681723204; x=1684315204; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RgrbmJtSLO84P/9uImcl/ILG4CYzql2cJa7HytOmSio=; b=dlrcE85R5C83mbI+8oSr2jPpjTnZhV7Z7c1aTAnGDR6NFpnTqhPqk5d7uAAvha8sd0 oJCKyf1nfev1zN7Zo+/VU/+MToLPmPEPU2m8SjD0eAzGvuM/mv1q8anJs82mGx7qgq0Z EyHm9T2iuD36L3yTeXsfh83ZLRuFeLtOC5G1W464vesw/FmJ5rdg5Lqj20HC3+JpNVii PXesTBH7pCc48lBJO79V+mxJDCRjm/Nl/8oM2+kb+XLI64eNkCXL+rm4PqQVpnzwnAYH 1YN00FblRsrknt9AwQVgWu13JqHNa3anvJifX5Pdp9CxDnfd9TfwjZ9SMH+fPllDkKgW 8RRA== X-Gm-Message-State: AAQBX9eC/vPBF9lgSXYWeOX5h70kFqZBcj0pavTPufoRIgv/COMHY2W1 ROXgmMon+dZBpybsVGKtrZ4= X-Google-Smtp-Source: AKy350akDTp90kvAlE1J5IpQpL0xybQXZiyBGwk9M6x2mkuH4dP9XQVBPQIJtXYbV3hBDI7Vqp5+zw== X-Received: by 2002:a19:f702:0:b0:4a4:68b8:f4f1 with SMTP id z2-20020a19f702000000b004a468b8f4f1mr1792676lfe.55.1681723203760; Mon, 17 Apr 2023 02:20:03 -0700 (PDT) Received: from dc75zzyyyyyyyyyyyyyyt-3.rev.dnainternet.fi (dc75zzyyyyyyyyyyyyyyt-3.rev.dnainternet.fi. [2001:14ba:16f3:4a00::1]) by smtp.gmail.com with ESMTPSA id l9-20020ac25549000000b004eb00c0d417sm1983556lfk.130.2023.04.17.02.20.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 02:20:03 -0700 (PDT) Date: Mon, 17 Apr 2023 12:19:57 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Jonathan Cameron , Lars-Peter Clausen , Matti Vaittinen , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] iio: bu27034: Fix integration time Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org The bu27034 uses micro seconds for integration time configuration. This is incorrect as the ABI mandates use of seconds. Change BU27034 driver to use seconds for integration time. Signed-off-by: Matti Vaittinen --- drivers/iio/light/rohm-bu27034.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/iio/light/rohm-bu27034.c b/drivers/iio/light/rohm-bu27034.c index e486dcf35eba..25c9b79574a5 100644 --- a/drivers/iio/light/rohm-bu27034.c +++ b/drivers/iio/light/rohm-bu27034.c @@ -1167,11 +1167,12 @@ static int bu27034_read_raw(struct iio_dev *idev, switch (mask) { case IIO_CHAN_INFO_INT_TIME: - *val = bu27034_get_int_time(data); - if (*val < 0) - return *val; + *val = 0; + *val2 = bu27034_get_int_time(data); + if (*val2 < 0) + return *val2; - return IIO_VAL_INT; + return IIO_VAL_INT_PLUS_MICRO; case IIO_CHAN_INFO_SCALE: return bu27034_get_scale(data, chan->channel, val, val2); @@ -1229,7 +1230,10 @@ static int bu27034_write_raw(struct iio_dev *idev, ret = bu27034_set_scale(data, chan->channel, val, val2); break; case IIO_CHAN_INFO_INT_TIME: - ret = bu27034_try_set_int_time(data, val); + if (!val) + ret = bu27034_try_set_int_time(data, val2); + else + ret = -EINVAL; break; default: ret = -EINVAL;