| Message ID | b59a9f59-da42-41b6-926b-50fb5b7909c3@rwthex-w2-a.rwth-ad.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 21 Dec 2017 19:31:32 +0100 Stefan Brüns <stefan.bruens@rwth-aachen.de> wrote: > iio_push_to_buffers_with_timestamp expects a void pointer, so the cast > is both unnecessary and misleading. > > Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> Hi Stefan, I applied the first few patches the first time around. Please drop them from new versions - if nothing else if confuses me ;) > --- > > Changes in v2: None > > drivers/iio/adc/ina2xx-adc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c > index ddf878163bf9..3195f8754c3b 100644 > --- a/drivers/iio/adc/ina2xx-adc.c > +++ b/drivers/iio/adc/ina2xx-adc.c > @@ -767,8 +767,7 @@ static int ina2xx_work_buffer(struct iio_dev *indio_dev) > > time_b = iio_get_time_ns(indio_dev); > > - iio_push_to_buffers_with_timestamp(indio_dev, > - (unsigned int *)data, time_a); > + iio_push_to_buffers_with_timestamp(indio_dev, data, time_a); > > return (unsigned long)(time_b - time_a) / 1000; > }; -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c index ddf878163bf9..3195f8754c3b 100644 --- a/drivers/iio/adc/ina2xx-adc.c +++ b/drivers/iio/adc/ina2xx-adc.c @@ -767,8 +767,7 @@ static int ina2xx_work_buffer(struct iio_dev *indio_dev) time_b = iio_get_time_ns(indio_dev); - iio_push_to_buffers_with_timestamp(indio_dev, - (unsigned int *)data, time_a); + iio_push_to_buffers_with_timestamp(indio_dev, data, time_a); return (unsigned long)(time_b - time_a) / 1000; };
iio_push_to_buffers_with_timestamp expects a void pointer, so the cast is both unnecessary and misleading. Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> --- Changes in v2: None drivers/iio/adc/ina2xx-adc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)