| Message ID | c50640665f091a04086e5092cf50f73f2055107a.1727980825.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | iio: hid-sensors: Fix an error handling path in _hid_sensor_set_report_latency() | expand |
On Thu, 3 Oct 2024 20:41:12 +0200 Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > If hid_sensor_set_report_latency() fails, the error code should be returned > instead of a value likely to be interpreted as 'success'. > > Fixes: 138bc7969c24 ("iio: hid-sensor-hub: Implement batch mode") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > This patch is speculative. > > The code just *looks* wrong to me. No strong opinion, if it is done on > purpose or not. Agreed it smells :) But I'd like more eyes on this before I take the fix as maybe there is something subtle going on. J > --- > drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c > index ad8910e6ad59..abb09fefc792 100644 > --- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c > +++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c > @@ -32,7 +32,7 @@ static ssize_t _hid_sensor_set_report_latency(struct device *dev, > latency = integer * 1000 + fract / 1000; > ret = hid_sensor_set_report_latency(attrb, latency); > if (ret < 0) > - return len; > + return ret; > > attrb->latency_ms = hid_sensor_get_report_latency(attrb); >
diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c index ad8910e6ad59..abb09fefc792 100644 --- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c +++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c @@ -32,7 +32,7 @@ static ssize_t _hid_sensor_set_report_latency(struct device *dev, latency = integer * 1000 + fract / 1000; ret = hid_sensor_set_report_latency(attrb, latency); if (ret < 0) - return len; + return ret; attrb->latency_ms = hid_sensor_get_report_latency(attrb);
If hid_sensor_set_report_latency() fails, the error code should be returned instead of a value likely to be interpreted as 'success'. Fixes: 138bc7969c24 ("iio: hid-sensor-hub: Implement batch mode") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- This patch is speculative. The code just *looks* wrong to me. No strong opinion, if it is done on purpose or not. --- drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)