| Message ID | ecbd85c40bce45078658a63bbd8b0a50@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | 答复: [PATCH 2/2] iio:filter:admv8818: Fix missing clk_disable_unprepare() in admv8818_clk_setup | expand |
diff --git a/drivers/iio/filter/admv8818.c b/drivers/iio/filter/admv8818.c index 68de45fe21b4..acb436efd8b5 100644 --- a/drivers/iio/filter/admv8818.c +++ b/drivers/iio/filter/admv8818.c @@ -590,14 +590,22 @@ static int admv8818_clk_setup(struct admv8818_state *st) ret = devm_add_action_or_reset(&spi->dev, admv8818_clk_disable, st); if (ret) - return ret; + goto out_clk_disable; admv8818_clk_disable() would do clk_disable_unprepare(), so clk_disable_unprepare() is not needed after devm_add_action_or_reset(),there is no problem in this function. this patch is not needed anymore. -- wangshaobo
-----邮件原件----- 发件人: Wangshaobo (bobo) 发送时间: 2022年3月18日 10:59 抄送: chengjian (D) <cj.chengjian@huawei.com>; liwei (GF) <liwei391@huawei.com>; Wangshaobo (bobo) <bobo.shaobowang@huawei.com>; antoniu.miclaus@analog.com; linux-iio@vger.kernel.org; linux-kernel@vger.kernel.org; jic23@kernel.org; Jonathan Cameron <jonathan.cameron@huawei.com> 主题: [PATCH 2/2] iio:filter:admv8818: Fix missing clk_disable_unprepare() in admv8818_clk_setup Fix missing clk_disable_unprepare() before return from admv8818_clk_setup in the error handling cases. Fixes: f34fe888ad05 ("iio:filter:admv8818: add support for ADMV8818") Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com> --- drivers/iio/filter/admv8818.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)