From patchwork Fri Dec 8 17:41:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Stefan_Br=C3=BCns?= X-Patchwork-Id: 10103093 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4355B60329 for ; Fri, 8 Dec 2017 17:44:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2A0EA28E42 for ; Fri, 8 Dec 2017 17:44:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1EE3D28E50; Fri, 8 Dec 2017 17:44:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A1D0528E42 for ; Fri, 8 Dec 2017 17:44:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753790AbdLHRo0 (ORCPT ); Fri, 8 Dec 2017 12:44:26 -0500 Received: from mail-out-2.itc.rwth-aachen.de ([134.130.5.47]:37961 "EHLO mail-out-2.itc.rwth-aachen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752954AbdLHRmN (ORCPT ); Fri, 8 Dec 2017 12:42:13 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2DTBADbzSpa/54agoZcHAEBAQQBAQoBA?= =?us-ascii?q?YM+ZoEbB4N7mSGbHgolhEdPAoRfQxQBAQEBAQEBAQFrKIUjBiMECwFGECUCJgI?= =?us-ascii?q?CVwYOBYooBAyoIoFtOohJghoBAQEBAQEEAQEBAQEjCQGBBYJMgguDPymIBRFXg?= =?us-ascii?q?kmCYwWKRZhDgRCGaY89iXQphy6NCIknAgICAgkCGoE7NiKBT3CCdwmETXeJIQG?= =?us-ascii?q?BFAEBAQ?= X-IPAS-Result: =?us-ascii?q?A2DTBADbzSpa/54agoZcHAEBAQQBAQoBAYM+ZoEbB4N7mSG?= =?us-ascii?q?bHgolhEdPAoRfQxQBAQEBAQEBAQFrKIUjBiMECwFGECUCJgICVwYOBYooBAyoI?= =?us-ascii?q?oFtOohJghoBAQEBAQEEAQEBAQEjCQGBBYJMgguDPymIBRFXgkmCYwWKRZhDgRC?= =?us-ascii?q?GaY89iXQphy6NCIknAgICAgkCGoE7NiKBT3CCdwmETXeJIQGBFAEBAQ?= X-IronPort-AV: E=Sophos;i="5.45,378,1508796000"; d="scan'208";a="28277016" Received: from rwthex-w2-a.rwth-ad.de ([134.130.26.158]) by mail-in-2.itc.rwth-aachen.de with ESMTP; 08 Dec 2017 18:42:06 +0100 Received: from pebbles.fritz.box (78.48.176.14) by rwthex-w2-a.rwth-ad.de (2002:8682:1a9e::8682:1a9e) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26; Fri, 8 Dec 2017 18:42:01 +0100 From: =?UTF-8?q?Stefan=20Br=C3=BCns?= To: CC: Peter Meerwald-Stadler , =?UTF-8?q?Stefan=20Br=C3=BCns?= , Maciej Purski , , "Andrew F . Davis" , Lars-Peter Clausen , Jonathan Cameron , Hartmut Knaack , "Javier Martinez Canillas" Subject: [PATCH v1 3/7] iio: adc: ina2xx: Remove unneeded dummy read to clear CNVR flag Date: Fri, 8 Dec 2017 18:41:48 +0100 X-Mailer: git-send-email 2.15.1 In-Reply-To: <20171208174152.30341-1-stefan.bruens@rwth-aachen.de> References: <20171208174152.30341-1-stefan.bruens@rwth-aachen.de> MIME-Version: 1.0 X-Originating-IP: [78.48.176.14] X-ClientProxiedBy: rwthex-w3-a.rwth-ad.de (2002:8682:1aa2::8682:1aa2) To rwthex-w2-a.rwth-ad.de (2002:8682:1a9e::8682:1a9e) Message-ID: Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Although the datasheet states the CNVR flag is cleared by reading the BUS_VOLTAGE register, it is actually cleared by reading any of the voltage/current/power registers. The behaviour has been confirmed by TI support: http://e2e.ti.com/support/amplifiers/current-shunt-monitors/f/931/p/647053/2378282 Signed-off-by: Stefan Brüns --- drivers/iio/adc/ina2xx-adc.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c index 8c8120406f52..b027d485398b 100644 --- a/drivers/iio/adc/ina2xx-adc.c +++ b/drivers/iio/adc/ina2xx-adc.c @@ -705,7 +705,6 @@ static int ina2xx_work_buffer(struct iio_dev *indio_dev) int bit, ret, i = 0; s64 time_a, time_b; unsigned int alert; - int cnvr_need_clear = 0; time_a = iio_get_time_ns(indio_dev); @@ -730,7 +729,6 @@ static int ina2xx_work_buffer(struct iio_dev *indio_dev) ret = regmap_read(chip->regmap, INA2XX_BUS_VOLTAGE, &alert); alert &= INA219_CNVR; - cnvr_need_clear = alert; } if (ret < 0) @@ -752,18 +750,6 @@ static int ina2xx_work_buffer(struct iio_dev *indio_dev) return ret; data[i++] = val; - - if (INA2XX_SHUNT_VOLTAGE + bit == INA2XX_POWER) - cnvr_need_clear = 0; - } - - /* Dummy read on INA219 power register to clear CNVR flag */ - if (cnvr_need_clear && chip->config->chip_id == ina219) { - unsigned int val; - - ret = regmap_read(chip->regmap, INA2XX_POWER, &val); - if (ret < 0) - return ret; } time_b = iio_get_time_ns(indio_dev);