diff mbox series

[v2] tools/counter: Makefile: Remove lingering 'include' when make clean

Message ID tencent_F85E314661100B0CE2845EB27E2E2F558C09@qq.com (mailing list archive)
State Handled Elsewhere
Headers show
Series [v2] tools/counter: Makefile: Remove lingering 'include' when make clean | expand

Commit Message

Rong Tao April 22, 2023, 2:27 p.m. UTC 
From: Rong Tao <rongtao@cestc.cn>

'make' create 'include' directory, we should remove it when 'make clean'.

Signed-off-by: Rong Tao <rongtao@cestc.cn>
---
v2: this commit, according to William Breathitt Gray's suggession in v1
v1: https://lore.kernel.org/lkml/tencent_FA682F628E818DD04B96C3E5A94ACFABE206@qq.com/
---
 tools/counter/Makefile | 1 +
 1 file changed, 1 insertion(+)

Comments

William Breathitt Gray April 22, 2023, 4:08 p.m. UTC | #1 
On Sat, Apr 22, 2023 at 10:27:38PM +0800, Rong Tao wrote:
> From: Rong Tao <rongtao@cestc.cn>
> 
> 'make' create 'include' directory, we should remove it when 'make clean'.
> 
> Signed-off-by: Rong Tao <rongtao@cestc.cn>

Hi Rong,

The code changes in this v2 are acceptable for me now, but I would like
the commit description typos fixed. I can fix it myself when I apply
this patch so that you don't need to submit a v3. Would you be okay if I
did that?

William Breathitt Gray
Rong Tao April 23, 2023, 12:22 a.m. UTC | #2 
Hi, William,

Of course it's okay, thanks.

Rong Tao
William Breathitt Gray April 23, 2023, 1:45 p.m. UTC | #3 
On Sat, Apr 22, 2023 at 10:27:38PM +0800, Rong Tao wrote:
> From: Rong Tao <rongtao@cestc.cn>
> 
> 'make' create 'include' directory, we should remove it when 'make clean'.
> 
> Signed-off-by: Rong Tao <rongtao@cestc.cn>

Queued (with minor commit description cleanup) for the counter-next
branch of the Counter tree.

Thank you,

William Breathitt Gray
diff mbox series

Patch

diff --git a/tools/counter/Makefile b/tools/counter/Makefile
index 8843f0fa6119..a0f4cab71fe5 100644
--- a/tools/counter/Makefile
+++ b/tools/counter/Makefile
@@ -40,6 +40,7 @@  $(OUTPUT)counter_example: $(COUNTER_EXAMPLE)
 clean:
 	rm -f $(ALL_PROGRAMS)
 	rm -rf $(OUTPUT)include/linux/counter.h
+	rmdir -p $(OUTPUT)include/linux
 	find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '\.*.d' -delete
 
 install: $(ALL_PROGRAMS)