mbox series

[v3,0/3] Add support for Goodix GT917S touch controller

Message ID 20200228010146.12215-1-icenowy@aosc.io (mailing list archive)
Headers show
Series Add support for Goodix GT917S touch controller | expand

Message

Icenowy Zheng Feb. 28, 2020, 1:01 a.m. UTC
This patchset introduces support for Goodix GT917S touch controller.

The major difference with other touch controllers from Goodix is that
the ID string is no longer number-only (it contains a 'S'), so an
additional patch is introduced for migrating the ID to a string.

Icenowy Zheng (3):
  dt-bindings: input: touchscreen: add compatible string for Goodix
    GT917S
  Input: goodix - use string-based chip ID
  Input: goodix - Add support for Goodix GT917S

 .../bindings/input/touchscreen/goodix.yaml    |  1 +
 drivers/input/touchscreen/goodix.c            | 71 +++++++++++--------
 2 files changed, 43 insertions(+), 29 deletions(-)

Comments

Bastien Nocera Feb. 28, 2020, 9:46 a.m. UTC | #1
On Fri, 2020-02-28 at 09:01 +0800, Icenowy Zheng wrote:
> This patchset introduces support for Goodix GT917S touch controller.
> 
> The major difference with other touch controllers from Goodix is that
> the ID string is no longer number-only (it contains a 'S'), so an
> additional patch is introduced for migrating the ID to a string.
> 
> Icenowy Zheng (3):
>   dt-bindings: input: touchscreen: add compatible string for Goodix
>     GT917S
>   Input: goodix - use string-based chip ID
>   Input: goodix - Add support for Goodix GT917S

For the whole patchset:
Reviewed-by: Bastien Nocera <hadess@hadess.net>

Thanks!

>  .../bindings/input/touchscreen/goodix.yaml    |  1 +
>  drivers/input/touchscreen/goodix.c            | 71 +++++++++++----
> ----
>  2 files changed, 43 insertions(+), 29 deletions(-)
>
Bastien Nocera March 2, 2020, 10:58 a.m. UTC | #2
On Fri, 2020-02-28 at 10:46 +0100, Bastien Nocera wrote:
> On Fri, 2020-02-28 at 09:01 +0800, Icenowy Zheng wrote:
> > This patchset introduces support for Goodix GT917S touch
> > controller.
> > 
> > The major difference with other touch controllers from Goodix is
> > that
> > the ID string is no longer number-only (it contains a 'S'), so an
> > additional patch is introduced for migrating the ID to a string.
> > 
> > Icenowy Zheng (3):
> >   dt-bindings: input: touchscreen: add compatible string for Goodix
> >     GT917S
> >   Input: goodix - use string-based chip ID
> >   Input: goodix - Add support for Goodix GT917S
> 
> For the whole patchset:
> Reviewed-by: Bastien Nocera <hadess@hadess.net>

Dmitry, would be nice to land this soon, there are a couple of patches
still in the queue to be reviewed with support for new models, and they
will conflict with this one.

Cheers