mbox series

[v6,0/4] add z1 and z2 channels support for resistive-adc-touch driver

Message ID 20210525054634.9134-1-o.rempel@pengutronix.de (mailing list archive)
Headers show
Series add z1 and z2 channels support for resistive-adc-touch driver | expand

Message

Oleksij Rempel May 25, 2021, 5:46 a.m. UTC
changes v6:
- drop other DT changes
- add more Reviewed-by tags
- remove redundant GRTS_CH_NONE check

changes v5:
- fix validate for other DT examples.
- add Reviewed-by: Rob Herring <robh@kernel.org> to some of the patches

changes v4:
- resistive-adc-touch: remove unused variable

changes v3:
- yaml: fix validation for channel names
- yaml: add nodename validation

changes v2:
- add yaml conversion patch to this series
- reword commit message for the last patch
- fix possible overflow on the buffer dispatcher

Oleksij Rempel (4):
  dt-bindings: touchscreen: Convert resistive-adc-touch binding to json
    schema
  dt-bindings: touchscreen: add touchscreen-x/y-plate-ohms property
  dt-bindings: touchscreen: resistive-adc-touch: add support for z1 and
    z2 channels
  Input: resistive-adc-touch: add support for z1 and z2 channels

 .../input/touchscreen/resistive-adc-touch.txt |  33 -----
 .../touchscreen/resistive-adc-touch.yaml      |  86 +++++++++++
 .../input/touchscreen/touchscreen.yaml        |   6 +
 .../input/touchscreen/resistive-adc-touch.c   | 140 ++++++++++++++++--
 4 files changed, 218 insertions(+), 47 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.txt
 create mode 100644 Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.yaml

Comments

Dmitry Torokhov May 25, 2021, 8:06 p.m. UTC | #1
Hi Oleksij,

On Tue, May 25, 2021 at 07:46:30AM +0200, Oleksij Rempel wrote:
> changes v6:
> - drop other DT changes
> - add more Reviewed-by tags
> - remove redundant GRTS_CH_NONE check

Applied the lot, thank you.
Eugen Hristev June 2, 2021, 11:15 a.m. UTC | #2
On 5/25/21 8:46 AM, Oleksij Rempel wrote:
> changes v6:
> - drop other DT changes
> - add more Reviewed-by tags
> - remove redundant GRTS_CH_NONE check
> 
> changes v5:
> - fix validate for other DT examples.
> - add Reviewed-by: Rob Herring <robh@kernel.org> to some of the patches
> 
> changes v4:
> - resistive-adc-touch: remove unused variable
> 
> changes v3:
> - yaml: fix validation for channel names
> - yaml: add nodename validation
> 
> changes v2:
> - add yaml conversion patch to this series
> - reword commit message for the last patch
> - fix possible overflow on the buffer dispatcher
> 
> Oleksij Rempel (4):
>    dt-bindings: touchscreen: Convert resistive-adc-touch binding to json
>      schema
>    dt-bindings: touchscreen: add touchscreen-x/y-plate-ohms property
>    dt-bindings: touchscreen: resistive-adc-touch: add support for z1 and
>      z2 channels
>    Input: resistive-adc-touch: add support for z1 and z2 channels
> 
>   .../input/touchscreen/resistive-adc-touch.txt |  33 -----
>   .../touchscreen/resistive-adc-touch.yaml      |  86 +++++++++++
>   .../input/touchscreen/touchscreen.yaml        |   6 +
>   .../input/touchscreen/resistive-adc-touch.c   | 140 ++++++++++++++++--
>   4 files changed, 218 insertions(+), 47 deletions(-)
>   delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.txt
>   create mode 100644 Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.yaml
> 
> --
> 2.29.2
> 



Hello Oleksij,

As I am listed in the MAINTAINERS file for this driver, why I am not 
even CC-ed to this patch series ?
At least what I could have done is test this series on my board using 
this driver.

Eugen
Oleksij Rempel June 7, 2021, 9:22 a.m. UTC | #3
Hello Eugen,

On Wed, Jun 02, 2021 at 11:15:47AM +0000, Eugen.Hristev@microchip.com wrote:
> On 5/25/21 8:46 AM, Oleksij Rempel wrote:
> > changes v6:
> > - drop other DT changes
> > - add more Reviewed-by tags
> > - remove redundant GRTS_CH_NONE check
> > 
> > changes v5:
> > - fix validate for other DT examples.
> > - add Reviewed-by: Rob Herring <robh@kernel.org> to some of the patches
> > 
> > changes v4:
> > - resistive-adc-touch: remove unused variable
> > 
> > changes v3:
> > - yaml: fix validation for channel names
> > - yaml: add nodename validation
> > 
> > changes v2:
> > - add yaml conversion patch to this series
> > - reword commit message for the last patch
> > - fix possible overflow on the buffer dispatcher
> > 
> > Oleksij Rempel (4):
> >    dt-bindings: touchscreen: Convert resistive-adc-touch binding to json
> >      schema
> >    dt-bindings: touchscreen: add touchscreen-x/y-plate-ohms property
> >    dt-bindings: touchscreen: resistive-adc-touch: add support for z1 and
> >      z2 channels
> >    Input: resistive-adc-touch: add support for z1 and z2 channels
> > 
> >   .../input/touchscreen/resistive-adc-touch.txt |  33 -----
> >   .../touchscreen/resistive-adc-touch.yaml      |  86 +++++++++++
> >   .../input/touchscreen/touchscreen.yaml        |   6 +
> >   .../input/touchscreen/resistive-adc-touch.c   | 140 ++++++++++++++++--
> >   4 files changed, 218 insertions(+), 47 deletions(-)
> >   delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.txt
> >   create mode 100644 Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.yaml
> > 
> > --
> > 2.29.2
> > 
> 
> 
> 
> Hello Oleksij,
> 
> As I am listed in the MAINTAINERS file for this driver, why I am not 
> even CC-ed to this patch series ?

Sorry, I missed you by accident.
Beside, you are not listed as maintainer for the:
Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.*

> At least what I could have done is test this series on my board using 
> this driver.

Do you have some regressions with it?

Regards,
Oleksij