mbox series

[RESEND,v11,0/5] Add support for CS40L50

Message ID 20240620161745.2312359-1-jogletre@opensource.cirrus.com (mailing list archive)
Headers show
Series Add support for CS40L50 | expand

Message

James Ogletree June 20, 2024, 4:17 p.m. UTC
Changes in v11:
- Constified function parameters in ASOC driver
- Removed an unneeded #include
- Changed number of max FF effects = 1
- Minor refactoring in Input driver
- Reworded comment in MFD driver

Changes in v10:
- Minor refactoring and logical improvements all around
- Renamed and added supplies

Changes in v9:
- Fixed empty struct by utilizing cs_dsp's post_run callback
- Style fixes in MFD driver

Changes in v8:
- set_sysclk() -> set_bclk_ratio()
- Added ID table to codec driver
- Style improvements
- Fixed ordering of new write sequence operations

Changes in v7:
- Fixed sparse warning
- Moved write sequences to private data structure
- Logical and style improvements in write sequence interface

Changes in v6:
- Updated write sequencer interface to be control-name based
- Fixed a race condition and non-handling of repeats in playback callback
- Stylistic and logical improvements all around

Changes in v5:
- Added a codec sub-device to support I2S streaming
- Moved write sequencer code from cirrus_haptics to cs_dsp
- Reverted cirrus_haptics library; future Cirrus input
  drivers will export and utilize cs40l50_vibra functions
- Added more comments
- Many small stylistic and logical improvements

Changes in v4:
- Moved from Input to MFD
- Moved common Cirrus haptic functions to a library
- Incorporated runtime PM framework
- Many style improvements

Changes in v3:
- YAML formatting corrections
- Fixed typo in MAINTAINERS
- Used generic node name "haptic-driver"
- Fixed probe error code paths
- Switched to "sizeof(*)"
- Removed tree reference in MAINTAINERS

Changes in v2:
- Fixed checkpatch warnings

James Ogletree (5):
  firmware: cs_dsp: Add write sequence interface
  dt-bindings: input: cirrus,cs40l50: Add initial DT binding
  mfd: cs40l50: Add support for CS40L50 core driver
  Input: cs40l50 - Add support for the CS40L50 haptic driver
  ASoC: cs40l50: Support I2S streaming to CS40L50

 .../bindings/input/cirrus,cs40l50.yaml        |  68 +++
 MAINTAINERS                                   |  12 +
 drivers/firmware/cirrus/cs_dsp.c              | 278 +++++++++
 drivers/input/misc/Kconfig                    |  10 +
 drivers/input/misc/Makefile                   |   1 +
 drivers/input/misc/cs40l50-vibra.c            | 555 +++++++++++++++++
 drivers/mfd/Kconfig                           |  30 +
 drivers/mfd/Makefile                          |   4 +
 drivers/mfd/cs40l50-core.c                    | 570 ++++++++++++++++++
 drivers/mfd/cs40l50-i2c.c                     |  68 +++
 drivers/mfd/cs40l50-spi.c                     |  68 +++
 include/linux/firmware/cirrus/cs_dsp.h        |  27 +
 include/linux/mfd/cs40l50.h                   | 137 +++++
 sound/soc/codecs/Kconfig                      |  11 +
 sound/soc/codecs/Makefile                     |   2 +
 sound/soc/codecs/cs40l50-codec.c              | 307 ++++++++++
 16 files changed, 2148 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/cirrus,cs40l50.yaml
 create mode 100644 drivers/input/misc/cs40l50-vibra.c
 create mode 100644 drivers/mfd/cs40l50-core.c
 create mode 100644 drivers/mfd/cs40l50-i2c.c
 create mode 100644 drivers/mfd/cs40l50-spi.c
 create mode 100644 include/linux/mfd/cs40l50.h
 create mode 100644 sound/soc/codecs/cs40l50-codec.c

Comments

Lee Jones June 20, 2024, 4:59 p.m. UTC | #1
On Thu, 20 Jun 2024, James Ogletree wrote:

> Changes in v11:
> - Constified function parameters in ASOC driver
> - Removed an unneeded #include
> - Changed number of max FF effects = 1
> - Minor refactoring in Input driver
> - Reworded comment in MFD driver
> 
> Changes in v10:
> - Minor refactoring and logical improvements all around
> - Renamed and added supplies
> 
> Changes in v9:
> - Fixed empty struct by utilizing cs_dsp's post_run callback
> - Style fixes in MFD driver
> 
> Changes in v8:
> - set_sysclk() -> set_bclk_ratio()
> - Added ID table to codec driver
> - Style improvements
> - Fixed ordering of new write sequence operations
> 
> Changes in v7:
> - Fixed sparse warning
> - Moved write sequences to private data structure
> - Logical and style improvements in write sequence interface
> 
> Changes in v6:
> - Updated write sequencer interface to be control-name based
> - Fixed a race condition and non-handling of repeats in playback callback
> - Stylistic and logical improvements all around
> 
> Changes in v5:
> - Added a codec sub-device to support I2S streaming
> - Moved write sequencer code from cirrus_haptics to cs_dsp
> - Reverted cirrus_haptics library; future Cirrus input
>   drivers will export and utilize cs40l50_vibra functions
> - Added more comments
> - Many small stylistic and logical improvements
> 
> Changes in v4:
> - Moved from Input to MFD
> - Moved common Cirrus haptic functions to a library
> - Incorporated runtime PM framework
> - Many style improvements
> 
> Changes in v3:
> - YAML formatting corrections
> - Fixed typo in MAINTAINERS
> - Used generic node name "haptic-driver"
> - Fixed probe error code paths
> - Switched to "sizeof(*)"
> - Removed tree reference in MAINTAINERS
> 
> Changes in v2:
> - Fixed checkpatch warnings
> 
> James Ogletree (5):
>   firmware: cs_dsp: Add write sequence interface
>   dt-bindings: input: cirrus,cs40l50: Add initial DT binding
>   mfd: cs40l50: Add support for CS40L50 core driver
>   Input: cs40l50 - Add support for the CS40L50 haptic driver
>   ASoC: cs40l50: Support I2S streaming to CS40L50
> 
>  .../bindings/input/cirrus,cs40l50.yaml        |  68 +++
>  MAINTAINERS                                   |  12 +
>  drivers/firmware/cirrus/cs_dsp.c              | 278 +++++++++
>  drivers/input/misc/Kconfig                    |  10 +
>  drivers/input/misc/Makefile                   |   1 +
>  drivers/input/misc/cs40l50-vibra.c            | 555 +++++++++++++++++
>  drivers/mfd/Kconfig                           |  30 +
>  drivers/mfd/Makefile                          |   4 +
>  drivers/mfd/cs40l50-core.c                    | 570 ++++++++++++++++++
>  drivers/mfd/cs40l50-i2c.c                     |  68 +++
>  drivers/mfd/cs40l50-spi.c                     |  68 +++
>  include/linux/firmware/cirrus/cs_dsp.h        |  27 +
>  include/linux/mfd/cs40l50.h                   | 137 +++++
>  sound/soc/codecs/Kconfig                      |  11 +
>  sound/soc/codecs/Makefile                     |   2 +
>  sound/soc/codecs/cs40l50-codec.c              | 307 ++++++++++
>  16 files changed, 2148 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/cirrus,cs40l50.yaml
>  create mode 100644 drivers/input/misc/cs40l50-vibra.c
>  create mode 100644 drivers/mfd/cs40l50-core.c
>  create mode 100644 drivers/mfd/cs40l50-i2c.c
>  create mode 100644 drivers/mfd/cs40l50-spi.c
>  create mode 100644 include/linux/mfd/cs40l50.h
>  create mode 100644 sound/soc/codecs/cs40l50-codec.c

Still needs Acks - ping me when you have them.
James Ogletree June 26, 2024, 8:35 p.m. UTC | #2
> On Jun 20, 2024, at 11:59 AM, Lee Jones <lee@kernel.org> wrote:
> 
> On Thu, 20 Jun 2024, James Ogletree wrote:
> 
>> Changes in v11:
>> - Constified function parameters in ASOC driver
>> - Removed an unneeded #include
>> - Changed number of max FF effects = 1
>> - Minor refactoring in Input driver
>> - Reworded comment in MFD driver
>> 
>> Changes in v10:
>> - Minor refactoring and logical improvements all around
>> - Renamed and added supplies
>> 
>> Changes in v9:
>> - Fixed empty struct by utilizing cs_dsp's post_run callback
>> - Style fixes in MFD driver
>> 
>> Changes in v8:
>> - set_sysclk() -> set_bclk_ratio()
>> - Added ID table to codec driver
>> - Style improvements
>> - Fixed ordering of new write sequence operations
>> 
>> Changes in v7:
>> - Fixed sparse warning
>> - Moved write sequences to private data structure
>> - Logical and style improvements in write sequence interface
>> 
>> Changes in v6:
>> - Updated write sequencer interface to be control-name based
>> - Fixed a race condition and non-handling of repeats in playback callback
>> - Stylistic and logical improvements all around
>> 
>> Changes in v5:
>> - Added a codec sub-device to support I2S streaming
>> - Moved write sequencer code from cirrus_haptics to cs_dsp
>> - Reverted cirrus_haptics library; future Cirrus input
>>  drivers will export and utilize cs40l50_vibra functions
>> - Added more comments
>> - Many small stylistic and logical improvements
>> 
>> Changes in v4:
>> - Moved from Input to MFD
>> - Moved common Cirrus haptic functions to a library
>> - Incorporated runtime PM framework
>> - Many style improvements
>> 
>> Changes in v3:
>> - YAML formatting corrections
>> - Fixed typo in MAINTAINERS
>> - Used generic node name "haptic-driver"
>> - Fixed probe error code paths
>> - Switched to "sizeof(*)"
>> - Removed tree reference in MAINTAINERS
>> 
>> Changes in v2:
>> - Fixed checkpatch warnings
>> 
>> James Ogletree (5):
>>  firmware: cs_dsp: Add write sequence interface
>>  dt-bindings: input: cirrus,cs40l50: Add initial DT binding
>>  mfd: cs40l50: Add support for CS40L50 core driver
>>  Input: cs40l50 - Add support for the CS40L50 haptic driver
>>  ASoC: cs40l50: Support I2S streaming to CS40L50
>> 
>> .../bindings/input/cirrus,cs40l50.yaml        |  68 +++
>> MAINTAINERS                                   |  12 +
>> drivers/firmware/cirrus/cs_dsp.c              | 278 +++++++++
>> drivers/input/misc/Kconfig                    |  10 +
>> drivers/input/misc/Makefile                   |   1 +
>> drivers/input/misc/cs40l50-vibra.c            | 555 +++++++++++++++++
>> drivers/mfd/Kconfig                           |  30 +
>> drivers/mfd/Makefile                          |   4 +
>> drivers/mfd/cs40l50-core.c                    | 570 ++++++++++++++++++
>> drivers/mfd/cs40l50-i2c.c                     |  68 +++
>> drivers/mfd/cs40l50-spi.c                     |  68 +++
>> include/linux/firmware/cirrus/cs_dsp.h        |  27 +
>> include/linux/mfd/cs40l50.h                   | 137 +++++
>> sound/soc/codecs/Kconfig                      |  11 +
>> sound/soc/codecs/Makefile                     |   2 +
>> sound/soc/codecs/cs40l50-codec.c              | 307 ++++++++++
>> 16 files changed, 2148 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/input/cirrus,cs40l50.yaml
>> create mode 100644 drivers/input/misc/cs40l50-vibra.c
>> create mode 100644 drivers/mfd/cs40l50-core.c
>> create mode 100644 drivers/mfd/cs40l50-i2c.c
>> create mode 100644 drivers/mfd/cs40l50-spi.c
>> create mode 100644 include/linux/mfd/cs40l50.h
>> create mode 100644 sound/soc/codecs/cs40l50-codec.c
> 
> Still needs Acks - ping me when you have them.
> 
> -- 
> Lee Jones [李琼斯]

Hi Lee,

You can take this series now.

Best,
James
Lee Jones June 27, 2024, 7:12 a.m. UTC | #3
On Wed, 26 Jun 2024, James Ogletree wrote:

> 
> > On Jun 20, 2024, at 11:59 AM, Lee Jones <lee@kernel.org> wrote:
> > 
> > On Thu, 20 Jun 2024, James Ogletree wrote:
> > 
> >> Changes in v11:
> >> - Constified function parameters in ASOC driver
> >> - Removed an unneeded #include
> >> - Changed number of max FF effects = 1
> >> - Minor refactoring in Input driver
> >> - Reworded comment in MFD driver
> >> 
> >> Changes in v10:
> >> - Minor refactoring and logical improvements all around
> >> - Renamed and added supplies
> >> 
> >> Changes in v9:
> >> - Fixed empty struct by utilizing cs_dsp's post_run callback
> >> - Style fixes in MFD driver
> >> 
> >> Changes in v8:
> >> - set_sysclk() -> set_bclk_ratio()
> >> - Added ID table to codec driver
> >> - Style improvements
> >> - Fixed ordering of new write sequence operations
> >> 
> >> Changes in v7:
> >> - Fixed sparse warning
> >> - Moved write sequences to private data structure
> >> - Logical and style improvements in write sequence interface
> >> 
> >> Changes in v6:
> >> - Updated write sequencer interface to be control-name based
> >> - Fixed a race condition and non-handling of repeats in playback callback
> >> - Stylistic and logical improvements all around
> >> 
> >> Changes in v5:
> >> - Added a codec sub-device to support I2S streaming
> >> - Moved write sequencer code from cirrus_haptics to cs_dsp
> >> - Reverted cirrus_haptics library; future Cirrus input
> >>  drivers will export and utilize cs40l50_vibra functions
> >> - Added more comments
> >> - Many small stylistic and logical improvements
> >> 
> >> Changes in v4:
> >> - Moved from Input to MFD
> >> - Moved common Cirrus haptic functions to a library
> >> - Incorporated runtime PM framework
> >> - Many style improvements
> >> 
> >> Changes in v3:
> >> - YAML formatting corrections
> >> - Fixed typo in MAINTAINERS
> >> - Used generic node name "haptic-driver"
> >> - Fixed probe error code paths
> >> - Switched to "sizeof(*)"
> >> - Removed tree reference in MAINTAINERS
> >> 
> >> Changes in v2:
> >> - Fixed checkpatch warnings
> >> 
> >> James Ogletree (5):
> >>  firmware: cs_dsp: Add write sequence interface
> >>  dt-bindings: input: cirrus,cs40l50: Add initial DT binding
> >>  mfd: cs40l50: Add support for CS40L50 core driver
> >>  Input: cs40l50 - Add support for the CS40L50 haptic driver
> >>  ASoC: cs40l50: Support I2S streaming to CS40L50
> >> 
> >> .../bindings/input/cirrus,cs40l50.yaml        |  68 +++
> >> MAINTAINERS                                   |  12 +
> >> drivers/firmware/cirrus/cs_dsp.c              | 278 +++++++++
> >> drivers/input/misc/Kconfig                    |  10 +
> >> drivers/input/misc/Makefile                   |   1 +
> >> drivers/input/misc/cs40l50-vibra.c            | 555 +++++++++++++++++
> >> drivers/mfd/Kconfig                           |  30 +
> >> drivers/mfd/Makefile                          |   4 +
> >> drivers/mfd/cs40l50-core.c                    | 570 ++++++++++++++++++
> >> drivers/mfd/cs40l50-i2c.c                     |  68 +++
> >> drivers/mfd/cs40l50-spi.c                     |  68 +++
> >> include/linux/firmware/cirrus/cs_dsp.h        |  27 +
> >> include/linux/mfd/cs40l50.h                   | 137 +++++
> >> sound/soc/codecs/Kconfig                      |  11 +
> >> sound/soc/codecs/Makefile                     |   2 +
> >> sound/soc/codecs/cs40l50-codec.c              | 307 ++++++++++
> >> 16 files changed, 2148 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/input/cirrus,cs40l50.yaml
> >> create mode 100644 drivers/input/misc/cs40l50-vibra.c
> >> create mode 100644 drivers/mfd/cs40l50-core.c
> >> create mode 100644 drivers/mfd/cs40l50-i2c.c
> >> create mode 100644 drivers/mfd/cs40l50-spi.c
> >> create mode 100644 include/linux/mfd/cs40l50.h
> >> create mode 100644 sound/soc/codecs/cs40l50-codec.c
> > 
> > Still needs Acks - ping me when you have them.
> > 
> > -- 
> > Lee Jones [李琼斯]
> 
> Hi Lee,
> 
> You can take this series now.

sound/soc?
James Ogletree June 27, 2024, 12:07 p.m. UTC | #4
> On Jun 27, 2024, at 2:12 AM, Lee Jones <lee@kernel.org> wrote:
> 
> On Wed, 26 Jun 2024, James Ogletree wrote:
> 
>> 
>>> On Jun 20, 2024, at 11:59 AM, Lee Jones <lee@kernel.org> wrote:
>>> 
>>> On Thu, 20 Jun 2024, James Ogletree wrote:
>>> 
>>>> Changes in v11:
>>>> - Constified function parameters in ASOC driver
>>>> - Removed an unneeded #include
>>>> - Changed number of max FF effects = 1
>>>> - Minor refactoring in Input driver
>>>> - Reworded comment in MFD driver
>>>> 
>>>> Changes in v10:
>>>> - Minor refactoring and logical improvements all around
>>>> - Renamed and added supplies
>>>> 
>>>> Changes in v9:
>>>> - Fixed empty struct by utilizing cs_dsp's post_run callback
>>>> - Style fixes in MFD driver
>>>> 
>>>> Changes in v8:
>>>> - set_sysclk() -> set_bclk_ratio()
>>>> - Added ID table to codec driver
>>>> - Style improvements
>>>> - Fixed ordering of new write sequence operations
>>>> 
>>>> Changes in v7:
>>>> - Fixed sparse warning
>>>> - Moved write sequences to private data structure
>>>> - Logical and style improvements in write sequence interface
>>>> 
>>>> Changes in v6:
>>>> - Updated write sequencer interface to be control-name based
>>>> - Fixed a race condition and non-handling of repeats in playback callback
>>>> - Stylistic and logical improvements all around
>>>> 
>>>> Changes in v5:
>>>> - Added a codec sub-device to support I2S streaming
>>>> - Moved write sequencer code from cirrus_haptics to cs_dsp
>>>> - Reverted cirrus_haptics library; future Cirrus input
>>>> drivers will export and utilize cs40l50_vibra functions
>>>> - Added more comments
>>>> - Many small stylistic and logical improvements
>>>> 
>>>> Changes in v4:
>>>> - Moved from Input to MFD
>>>> - Moved common Cirrus haptic functions to a library
>>>> - Incorporated runtime PM framework
>>>> - Many style improvements
>>>> 
>>>> Changes in v3:
>>>> - YAML formatting corrections
>>>> - Fixed typo in MAINTAINERS
>>>> - Used generic node name "haptic-driver"
>>>> - Fixed probe error code paths
>>>> - Switched to "sizeof(*)"
>>>> - Removed tree reference in MAINTAINERS
>>>> 
>>>> Changes in v2:
>>>> - Fixed checkpatch warnings
>>>> 
>>>> James Ogletree (5):
>>>> firmware: cs_dsp: Add write sequence interface
>>>> dt-bindings: input: cirrus,cs40l50: Add initial DT binding
>>>> mfd: cs40l50: Add support for CS40L50 core driver
>>>> Input: cs40l50 - Add support for the CS40L50 haptic driver
>>>> ASoC: cs40l50: Support I2S streaming to CS40L50
>>>> 
>>>> .../bindings/input/cirrus,cs40l50.yaml        |  68 +++
>>>> MAINTAINERS                                   |  12 +
>>>> drivers/firmware/cirrus/cs_dsp.c              | 278 +++++++++
>>>> drivers/input/misc/Kconfig                    |  10 +
>>>> drivers/input/misc/Makefile                   |   1 +
>>>> drivers/input/misc/cs40l50-vibra.c            | 555 +++++++++++++++++
>>>> drivers/mfd/Kconfig                           |  30 +
>>>> drivers/mfd/Makefile                          |   4 +
>>>> drivers/mfd/cs40l50-core.c                    | 570 ++++++++++++++++++
>>>> drivers/mfd/cs40l50-i2c.c                     |  68 +++
>>>> drivers/mfd/cs40l50-spi.c                     |  68 +++
>>>> include/linux/firmware/cirrus/cs_dsp.h        |  27 +
>>>> include/linux/mfd/cs40l50.h                   | 137 +++++
>>>> sound/soc/codecs/Kconfig                      |  11 +
>>>> sound/soc/codecs/Makefile                     |   2 +
>>>> sound/soc/codecs/cs40l50-codec.c              | 307 ++++++++++
>>>> 16 files changed, 2148 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/input/cirrus,cs40l50.yaml
>>>> create mode 100644 drivers/input/misc/cs40l50-vibra.c
>>>> create mode 100644 drivers/mfd/cs40l50-core.c
>>>> create mode 100644 drivers/mfd/cs40l50-i2c.c
>>>> create mode 100644 drivers/mfd/cs40l50-spi.c
>>>> create mode 100644 include/linux/mfd/cs40l50.h
>>>> create mode 100644 sound/soc/codecs/cs40l50-codec.c
>>> 
>>> Still needs Acks - ping me when you have them.
>>> 
>>> -- 
>>> Lee Jones [李琼斯]
>> 
>> Hi Lee,
>> 
>> You can take this series now.
> 
> sound/soc?
> 
> -- 
> Lee Jones [李琼斯]

Mark has Acked the original v11 series here:
https://lore.kernel.org/all/a85e09d6-d8eb-4c60-ae83-b4dbf875a926@sirena.org.uk/

Best,
James
Lee Jones June 28, 2024, 8:06 a.m. UTC | #5
On Thu, 27 Jun 2024, James Ogletree wrote:

> 
> > On Jun 27, 2024, at 2:12 AM, Lee Jones <lee@kernel.org> wrote:
> > 
> > On Wed, 26 Jun 2024, James Ogletree wrote:
> > 
> >> 
> >>> On Jun 20, 2024, at 11:59 AM, Lee Jones <lee@kernel.org> wrote:
> >>> 
> >>> On Thu, 20 Jun 2024, James Ogletree wrote:
> >>> 
> >>>> Changes in v11:
> >>>> - Constified function parameters in ASOC driver
> >>>> - Removed an unneeded #include
> >>>> - Changed number of max FF effects = 1
> >>>> - Minor refactoring in Input driver
> >>>> - Reworded comment in MFD driver
> >>>> 
> >>>> Changes in v10:
> >>>> - Minor refactoring and logical improvements all around
> >>>> - Renamed and added supplies
> >>>> 
> >>>> Changes in v9:
> >>>> - Fixed empty struct by utilizing cs_dsp's post_run callback
> >>>> - Style fixes in MFD driver
> >>>> 
> >>>> Changes in v8:
> >>>> - set_sysclk() -> set_bclk_ratio()
> >>>> - Added ID table to codec driver
> >>>> - Style improvements
> >>>> - Fixed ordering of new write sequence operations
> >>>> 
> >>>> Changes in v7:
> >>>> - Fixed sparse warning
> >>>> - Moved write sequences to private data structure
> >>>> - Logical and style improvements in write sequence interface
> >>>> 
> >>>> Changes in v6:
> >>>> - Updated write sequencer interface to be control-name based
> >>>> - Fixed a race condition and non-handling of repeats in playback callback
> >>>> - Stylistic and logical improvements all around
> >>>> 
> >>>> Changes in v5:
> >>>> - Added a codec sub-device to support I2S streaming
> >>>> - Moved write sequencer code from cirrus_haptics to cs_dsp
> >>>> - Reverted cirrus_haptics library; future Cirrus input
> >>>> drivers will export and utilize cs40l50_vibra functions
> >>>> - Added more comments
> >>>> - Many small stylistic and logical improvements
> >>>> 
> >>>> Changes in v4:
> >>>> - Moved from Input to MFD
> >>>> - Moved common Cirrus haptic functions to a library
> >>>> - Incorporated runtime PM framework
> >>>> - Many style improvements
> >>>> 
> >>>> Changes in v3:
> >>>> - YAML formatting corrections
> >>>> - Fixed typo in MAINTAINERS
> >>>> - Used generic node name "haptic-driver"
> >>>> - Fixed probe error code paths
> >>>> - Switched to "sizeof(*)"
> >>>> - Removed tree reference in MAINTAINERS
> >>>> 
> >>>> Changes in v2:
> >>>> - Fixed checkpatch warnings
> >>>> 
> >>>> James Ogletree (5):
> >>>> firmware: cs_dsp: Add write sequence interface
> >>>> dt-bindings: input: cirrus,cs40l50: Add initial DT binding
> >>>> mfd: cs40l50: Add support for CS40L50 core driver
> >>>> Input: cs40l50 - Add support for the CS40L50 haptic driver
> >>>> ASoC: cs40l50: Support I2S streaming to CS40L50
> >>>> 
> >>>> .../bindings/input/cirrus,cs40l50.yaml        |  68 +++
> >>>> MAINTAINERS                                   |  12 +
> >>>> drivers/firmware/cirrus/cs_dsp.c              | 278 +++++++++
> >>>> drivers/input/misc/Kconfig                    |  10 +
> >>>> drivers/input/misc/Makefile                   |   1 +
> >>>> drivers/input/misc/cs40l50-vibra.c            | 555 +++++++++++++++++
> >>>> drivers/mfd/Kconfig                           |  30 +
> >>>> drivers/mfd/Makefile                          |   4 +
> >>>> drivers/mfd/cs40l50-core.c                    | 570 ++++++++++++++++++
> >>>> drivers/mfd/cs40l50-i2c.c                     |  68 +++
> >>>> drivers/mfd/cs40l50-spi.c                     |  68 +++
> >>>> include/linux/firmware/cirrus/cs_dsp.h        |  27 +
> >>>> include/linux/mfd/cs40l50.h                   | 137 +++++
> >>>> sound/soc/codecs/Kconfig                      |  11 +
> >>>> sound/soc/codecs/Makefile                     |   2 +
> >>>> sound/soc/codecs/cs40l50-codec.c              | 307 ++++++++++
> >>>> 16 files changed, 2148 insertions(+)
> >>>> create mode 100644 Documentation/devicetree/bindings/input/cirrus,cs40l50.yaml
> >>>> create mode 100644 drivers/input/misc/cs40l50-vibra.c
> >>>> create mode 100644 drivers/mfd/cs40l50-core.c
> >>>> create mode 100644 drivers/mfd/cs40l50-i2c.c
> >>>> create mode 100644 drivers/mfd/cs40l50-spi.c
> >>>> create mode 100644 include/linux/mfd/cs40l50.h
> >>>> create mode 100644 sound/soc/codecs/cs40l50-codec.c
> >>> 
> >>> Still needs Acks - ping me when you have them.
> >>> 
> >>> -- 
> >>> Lee Jones [李琼斯]
> >> 
> >> Hi Lee,
> >> 
> >> You can take this series now.
> > 
> > sound/soc?
> > 
> > -- 
> > Lee Jones [李琼斯]
> 
> Mark has Acked the original v11 series here:
> https://lore.kernel.org/all/a85e09d6-d8eb-4c60-ae83-b4dbf875a926@sirena.org.uk/

Ah, you just forgot to add it to the RESEND?

Okay, leave it with me then.
James Ogletree June 28, 2024, 11:18 a.m. UTC | #6
> On Jun 28, 2024, at 3:06 AM, Lee Jones <lee@kernel.org> wrote:
> 
> On Thu, 27 Jun 2024, James Ogletree wrote:
> 
>> 
>>> On Jun 27, 2024, at 2:12 AM, Lee Jones <lee@kernel.org> wrote:
>>> 
>>> On Wed, 26 Jun 2024, James Ogletree wrote:
>>> 
>>>> 
>>>>> On Jun 20, 2024, at 11:59 AM, Lee Jones <lee@kernel.org> wrote:
>>>>> 
>>>>> On Thu, 20 Jun 2024, James Ogletree wrote:
>>>>> 
>>>>>> Changes in v11:
>>>>>> - Constified function parameters in ASOC driver
>>>>>> - Removed an unneeded #include
>>>>>> - Changed number of max FF effects = 1
>>>>>> - Minor refactoring in Input driver
>>>>>> - Reworded comment in MFD driver
>>>>>> 
>>>>>> Changes in v10:
>>>>>> - Minor refactoring and logical improvements all around
>>>>>> - Renamed and added supplies
>>>>>> 
>>>>>> Changes in v9:
>>>>>> - Fixed empty struct by utilizing cs_dsp's post_run callback
>>>>>> - Style fixes in MFD driver
>>>>>> 
>>>>>> Changes in v8:
>>>>>> - set_sysclk() -> set_bclk_ratio()
>>>>>> - Added ID table to codec driver
>>>>>> - Style improvements
>>>>>> - Fixed ordering of new write sequence operations
>>>>>> 
>>>>>> Changes in v7:
>>>>>> - Fixed sparse warning
>>>>>> - Moved write sequences to private data structure
>>>>>> - Logical and style improvements in write sequence interface
>>>>>> 
>>>>>> Changes in v6:
>>>>>> - Updated write sequencer interface to be control-name based
>>>>>> - Fixed a race condition and non-handling of repeats in playback callback
>>>>>> - Stylistic and logical improvements all around
>>>>>> 
>>>>>> Changes in v5:
>>>>>> - Added a codec sub-device to support I2S streaming
>>>>>> - Moved write sequencer code from cirrus_haptics to cs_dsp
>>>>>> - Reverted cirrus_haptics library; future Cirrus input
>>>>>> drivers will export and utilize cs40l50_vibra functions
>>>>>> - Added more comments
>>>>>> - Many small stylistic and logical improvements
>>>>>> 
>>>>>> Changes in v4:
>>>>>> - Moved from Input to MFD
>>>>>> - Moved common Cirrus haptic functions to a library
>>>>>> - Incorporated runtime PM framework
>>>>>> - Many style improvements
>>>>>> 
>>>>>> Changes in v3:
>>>>>> - YAML formatting corrections
>>>>>> - Fixed typo in MAINTAINERS
>>>>>> - Used generic node name "haptic-driver"
>>>>>> - Fixed probe error code paths
>>>>>> - Switched to "sizeof(*)"
>>>>>> - Removed tree reference in MAINTAINERS
>>>>>> 
>>>>>> Changes in v2:
>>>>>> - Fixed checkpatch warnings
>>>>>> 
>>>>>> James Ogletree (5):
>>>>>> firmware: cs_dsp: Add write sequence interface
>>>>>> dt-bindings: input: cirrus,cs40l50: Add initial DT binding
>>>>>> mfd: cs40l50: Add support for CS40L50 core driver
>>>>>> Input: cs40l50 - Add support for the CS40L50 haptic driver
>>>>>> ASoC: cs40l50: Support I2S streaming to CS40L50
>>>>>> 
>>>>>> .../bindings/input/cirrus,cs40l50.yaml        |  68 +++
>>>>>> MAINTAINERS                                   |  12 +
>>>>>> drivers/firmware/cirrus/cs_dsp.c              | 278 +++++++++
>>>>>> drivers/input/misc/Kconfig                    |  10 +
>>>>>> drivers/input/misc/Makefile                   |   1 +
>>>>>> drivers/input/misc/cs40l50-vibra.c            | 555 +++++++++++++++++
>>>>>> drivers/mfd/Kconfig                           |  30 +
>>>>>> drivers/mfd/Makefile                          |   4 +
>>>>>> drivers/mfd/cs40l50-core.c                    | 570 ++++++++++++++++++
>>>>>> drivers/mfd/cs40l50-i2c.c                     |  68 +++
>>>>>> drivers/mfd/cs40l50-spi.c                     |  68 +++
>>>>>> include/linux/firmware/cirrus/cs_dsp.h        |  27 +
>>>>>> include/linux/mfd/cs40l50.h                   | 137 +++++
>>>>>> sound/soc/codecs/Kconfig                      |  11 +
>>>>>> sound/soc/codecs/Makefile                     |   2 +
>>>>>> sound/soc/codecs/cs40l50-codec.c              | 307 ++++++++++
>>>>>> 16 files changed, 2148 insertions(+)
>>>>>> create mode 100644 Documentation/devicetree/bindings/input/cirrus,cs40l50.yaml
>>>>>> create mode 100644 drivers/input/misc/cs40l50-vibra.c
>>>>>> create mode 100644 drivers/mfd/cs40l50-core.c
>>>>>> create mode 100644 drivers/mfd/cs40l50-i2c.c
>>>>>> create mode 100644 drivers/mfd/cs40l50-spi.c
>>>>>> create mode 100644 include/linux/mfd/cs40l50.h
>>>>>> create mode 100644 sound/soc/codecs/cs40l50-codec.c
>>>>> 
>>>>> Still needs Acks - ping me when you have them.
>>>>> 
>>>>> -- 
>>>>> Lee Jones [李琼斯]
>>>> 
>>>> Hi Lee,
>>>> 
>>>> You can take this series now.
>>> 
>>> sound/soc?
>>> 
>>> -- 
>>> Lee Jones [李琼斯]
>> 
>> Mark has Acked the original v11 series here:
>> https://urldefense.com/v3/__https://lore.kernel.org/all/a85e09d6-d8eb-4c60-ae83-b4dbf875a926@sirena.org.uk/__;!!DQ3KfwI!0a407iFiKYCsNXJTLf65046j5eBK-mijVgGMYsX8Rg8dCaxttzQAKBI976mPk_AxuVs7n1zqpQmpy7o$
> 
> Ah, you just forgot to add it to the RESEND?
> 
> Okay, leave it with me then.
> 
> -- 
> Lee Jones [李琼斯]

Actually it was Acked on the original v11 series after the RESEND had been sent
out. If you like, I can resend with all the collected tags.

Best,
James
Lee Jones June 28, 2024, 2:23 p.m. UTC | #7
On Fri, 28 Jun 2024, James Ogletree wrote:

> 
> > On Jun 28, 2024, at 3:06 AM, Lee Jones <lee@kernel.org> wrote:
> > 
> > On Thu, 27 Jun 2024, James Ogletree wrote:
> > 
> >> 
> >>> On Jun 27, 2024, at 2:12 AM, Lee Jones <lee@kernel.org> wrote:
> >>> 
> >>> On Wed, 26 Jun 2024, James Ogletree wrote:
> >>> 
> >>>> 
> >>>>> On Jun 20, 2024, at 11:59 AM, Lee Jones <lee@kernel.org> wrote:
> >>>>> 
> >>>>> On Thu, 20 Jun 2024, James Ogletree wrote:
> >>>>> 
> >>>>>> Changes in v11:
> >>>>>> - Constified function parameters in ASOC driver
> >>>>>> - Removed an unneeded #include
> >>>>>> - Changed number of max FF effects = 1
> >>>>>> - Minor refactoring in Input driver
> >>>>>> - Reworded comment in MFD driver
> >>>>>> 
> >>>>>> Changes in v10:
> >>>>>> - Minor refactoring and logical improvements all around
> >>>>>> - Renamed and added supplies
> >>>>>> 
> >>>>>> Changes in v9:
> >>>>>> - Fixed empty struct by utilizing cs_dsp's post_run callback
> >>>>>> - Style fixes in MFD driver
> >>>>>> 
> >>>>>> Changes in v8:
> >>>>>> - set_sysclk() -> set_bclk_ratio()
> >>>>>> - Added ID table to codec driver
> >>>>>> - Style improvements
> >>>>>> - Fixed ordering of new write sequence operations
> >>>>>> 
> >>>>>> Changes in v7:
> >>>>>> - Fixed sparse warning
> >>>>>> - Moved write sequences to private data structure
> >>>>>> - Logical and style improvements in write sequence interface
> >>>>>> 
> >>>>>> Changes in v6:
> >>>>>> - Updated write sequencer interface to be control-name based
> >>>>>> - Fixed a race condition and non-handling of repeats in playback callback
> >>>>>> - Stylistic and logical improvements all around
> >>>>>> 
> >>>>>> Changes in v5:
> >>>>>> - Added a codec sub-device to support I2S streaming
> >>>>>> - Moved write sequencer code from cirrus_haptics to cs_dsp
> >>>>>> - Reverted cirrus_haptics library; future Cirrus input
> >>>>>> drivers will export and utilize cs40l50_vibra functions
> >>>>>> - Added more comments
> >>>>>> - Many small stylistic and logical improvements
> >>>>>> 
> >>>>>> Changes in v4:
> >>>>>> - Moved from Input to MFD
> >>>>>> - Moved common Cirrus haptic functions to a library
> >>>>>> - Incorporated runtime PM framework
> >>>>>> - Many style improvements
> >>>>>> 
> >>>>>> Changes in v3:
> >>>>>> - YAML formatting corrections
> >>>>>> - Fixed typo in MAINTAINERS
> >>>>>> - Used generic node name "haptic-driver"
> >>>>>> - Fixed probe error code paths
> >>>>>> - Switched to "sizeof(*)"
> >>>>>> - Removed tree reference in MAINTAINERS
> >>>>>> 
> >>>>>> Changes in v2:
> >>>>>> - Fixed checkpatch warnings
> >>>>>> 
> >>>>>> James Ogletree (5):
> >>>>>> firmware: cs_dsp: Add write sequence interface
> >>>>>> dt-bindings: input: cirrus,cs40l50: Add initial DT binding
> >>>>>> mfd: cs40l50: Add support for CS40L50 core driver
> >>>>>> Input: cs40l50 - Add support for the CS40L50 haptic driver
> >>>>>> ASoC: cs40l50: Support I2S streaming to CS40L50
> >>>>>> 
> >>>>>> .../bindings/input/cirrus,cs40l50.yaml        |  68 +++
> >>>>>> MAINTAINERS                                   |  12 +
> >>>>>> drivers/firmware/cirrus/cs_dsp.c              | 278 +++++++++
> >>>>>> drivers/input/misc/Kconfig                    |  10 +
> >>>>>> drivers/input/misc/Makefile                   |   1 +
> >>>>>> drivers/input/misc/cs40l50-vibra.c            | 555 +++++++++++++++++
> >>>>>> drivers/mfd/Kconfig                           |  30 +
> >>>>>> drivers/mfd/Makefile                          |   4 +
> >>>>>> drivers/mfd/cs40l50-core.c                    | 570 ++++++++++++++++++
> >>>>>> drivers/mfd/cs40l50-i2c.c                     |  68 +++
> >>>>>> drivers/mfd/cs40l50-spi.c                     |  68 +++
> >>>>>> include/linux/firmware/cirrus/cs_dsp.h        |  27 +
> >>>>>> include/linux/mfd/cs40l50.h                   | 137 +++++
> >>>>>> sound/soc/codecs/Kconfig                      |  11 +
> >>>>>> sound/soc/codecs/Makefile                     |   2 +
> >>>>>> sound/soc/codecs/cs40l50-codec.c              | 307 ++++++++++
> >>>>>> 16 files changed, 2148 insertions(+)
> >>>>>> create mode 100644 Documentation/devicetree/bindings/input/cirrus,cs40l50.yaml
> >>>>>> create mode 100644 drivers/input/misc/cs40l50-vibra.c
> >>>>>> create mode 100644 drivers/mfd/cs40l50-core.c
> >>>>>> create mode 100644 drivers/mfd/cs40l50-i2c.c
> >>>>>> create mode 100644 drivers/mfd/cs40l50-spi.c
> >>>>>> create mode 100644 include/linux/mfd/cs40l50.h
> >>>>>> create mode 100644 sound/soc/codecs/cs40l50-codec.c
> >>>>> 
> >>>>> Still needs Acks - ping me when you have them.
> >>>>> 
> >>>>> -- 
> >>>>> Lee Jones [李琼斯]
> >>>> 
> >>>> Hi Lee,
> >>>> 
> >>>> You can take this series now.
> >>> 
> >>> sound/soc?
> >>> 
> >>> -- 
> >>> Lee Jones [李琼斯]
> >> 
> >> Mark has Acked the original v11 series here:
> >> https://urldefense.com/v3/__https://lore.kernel.org/all/a85e09d6-d8eb-4c60-ae83-b4dbf875a926@sirena.org.uk/__;!!DQ3KfwI!0a407iFiKYCsNXJTLf65046j5eBK-mijVgGMYsX8Rg8dCaxttzQAKBI976mPk_AxuVs7n1zqpQmpy7o$
> > 
> > Ah, you just forgot to add it to the RESEND?
> > 
> > Okay, leave it with me then.
> > 
> > -- 
> > Lee Jones [李琼斯]
> 
> Actually it was Acked on the original v11 series after the RESEND had been sent
> out. If you like, I can resend with all the collected tags.

I see.  Thanks for the explanation.

No need to resend again, I'll add it manually.
Lee Jones June 28, 2024, 2:36 p.m. UTC | #8
On Thu, 20 Jun 2024 16:17:40 +0000, James Ogletree wrote:
> Changes in v11:
> - Constified function parameters in ASOC driver
> - Removed an unneeded #include
> - Changed number of max FF effects = 1
> - Minor refactoring in Input driver
> - Reworded comment in MFD driver
> 
> [...]

Applied, thanks!

[1/5] firmware: cs_dsp: Add write sequence interface
      commit: 205fdba5d0ffe1ad8de61763d74323e88b640d41
[2/5] dt-bindings: input: cirrus,cs40l50: Add initial DT binding
      commit: 2fab5abad124fe7e1b99ccba3305aa4c5a24496b
[3/5] mfd: cs40l50: Add support for CS40L50 core driver
      commit: cb626376cbd00cd69329371519a8e9568baef715
[4/5] Input: cs40l50 - Add support for the CS40L50 haptic driver
      commit: c38fe1bb5d21c2ce0857965ee06174ee587d6b42
[5/5] ASoC: cs40l50: Support I2S streaming to CS40L50
      commit: c486def5b3ba6c55294cee9abc7396d9dc18f223

--
Lee Jones [李琼斯]
Lee Jones June 28, 2024, 2:38 p.m. UTC | #9
On Fri, 28 Jun 2024, Lee Jones wrote:

> On Thu, 20 Jun 2024 16:17:40 +0000, James Ogletree wrote:
> > Changes in v11:
> > - Constified function parameters in ASOC driver
> > - Removed an unneeded #include
> > - Changed number of max FF effects = 1
> > - Minor refactoring in Input driver
> > - Reworded comment in MFD driver
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/5] firmware: cs_dsp: Add write sequence interface
>       commit: 205fdba5d0ffe1ad8de61763d74323e88b640d41
> [2/5] dt-bindings: input: cirrus,cs40l50: Add initial DT binding
>       commit: 2fab5abad124fe7e1b99ccba3305aa4c5a24496b
> [3/5] mfd: cs40l50: Add support for CS40L50 core driver
>       commit: cb626376cbd00cd69329371519a8e9568baef715
> [4/5] Input: cs40l50 - Add support for the CS40L50 haptic driver
>       commit: c38fe1bb5d21c2ce0857965ee06174ee587d6b42
> [5/5] ASoC: cs40l50: Support I2S streaming to CS40L50
>       commit: c486def5b3ba6c55294cee9abc7396d9dc18f223

Submitted for build testing.

If all is good, I'll submit a PR for the other maintainers soon.
Lee Jones June 28, 2024, 2:38 p.m. UTC | #10
On Fri, 28 Jun 2024, Lee Jones wrote:

> On Fri, 28 Jun 2024, Lee Jones wrote:
> 
> > On Thu, 20 Jun 2024 16:17:40 +0000, James Ogletree wrote:
> > > Changes in v11:
> > > - Constified function parameters in ASOC driver
> > > - Removed an unneeded #include
> > > - Changed number of max FF effects = 1
> > > - Minor refactoring in Input driver
> > > - Reworded comment in MFD driver
> > > 
> > > [...]
> > 
> > Applied, thanks!
> > 
> > [1/5] firmware: cs_dsp: Add write sequence interface
> >       commit: 205fdba5d0ffe1ad8de61763d74323e88b640d41
> > [2/5] dt-bindings: input: cirrus,cs40l50: Add initial DT binding
> >       commit: 2fab5abad124fe7e1b99ccba3305aa4c5a24496b
> > [3/5] mfd: cs40l50: Add support for CS40L50 core driver
> >       commit: cb626376cbd00cd69329371519a8e9568baef715
> > [4/5] Input: cs40l50 - Add support for the CS40L50 haptic driver
> >       commit: c38fe1bb5d21c2ce0857965ee06174ee587d6b42
> > [5/5] ASoC: cs40l50: Support I2S streaming to CS40L50
> >       commit: c486def5b3ba6c55294cee9abc7396d9dc18f223
> 
> Submitted for build testing.
> 
> If all is good, I'll submit a PR for the other maintainers soon.

For my own info: ib-mfd-firmware-input-sound-soc-6.11