mbox series

[RESEND,0/1] Do Not Disturb broke GD D-pad

Message ID 20241220192318.1174945-1-terry.tritton@linaro.org (mailing list archive)
Headers show
Series Do Not Disturb broke GD D-pad | expand

Message

Terry Tritton Dec. 20, 2024, 7:23 p.m. UTC 
Hi, 
We noticed a breakage in the android test: CtsHardwareTestCases_cts_tests
android.hardware.input.cts.tests.GameviceGv186Test#testAllMotions

I bisected the issue to:
	commit 22d6d060ac77 ("input: Add support for "Do Not Disturb"")
The cause is pretty clear there are 2 separate checks for:
	if ((usage->hid & 0xf0) == 0x90)
so the second one which handles the d-pad is getting skipped.

I've combined them both in the following patch which works for me.

Resending with reviewers tagged from previous discussion[1]

Thanks

[1] https://lore.kernel.org/linux-input/20241011195808.2201-1-terry.tritton@linaro.org/

Terry Tritton (1):
  input: fix generic desktop D-Pad controls

 drivers/hid/hid-input.c | 37 +++++++++++++++++--------------------
 include/linux/hid.h     |  1 +
 2 files changed, 18 insertions(+), 20 deletions(-)