mbox series

[0/2] Add driver for keyboard backlight on Magic keyboards found on T2 Macs

Message ID 3055BCC5-8F8B-4472-9E94-1319D1C6DEED@live.com (mailing list archive)
Headers show
Series Add driver for keyboard backlight on Magic keyboards found on T2 Macs | expand

Message

Aditya Garg July 1, 2024, 7:18 p.m. UTC 
This patchseries adds support for the internal keyboard backlight of
Macs with Apple's "Magic" keyboard (MacBookPro16,* and MacBookAir9,1),
and also documents what names should be used for keyboard backlight
leds in Documentation/leds/well-known-leds.txt.

A separate driver for the purpose of backlight has been chosen because:

1. On the MacBookAir9,1 there is a USB device dedicated just for keyboard
  backlight by the name of Touchbar Backlight. Adding its support to any other
  hid-driver breaks the device.

2. Its now possible to use drm on the Touch Bar (similar to what macOS does).
  So, the Touch Bar drivers intended to be upstreamed before are no longer used.
  https://lore.kernel.org/all/868AA58D-2399-4E4A-A6C6-73F88DB13992@live.com/
  The driver that supports drm is still out of tree and yet to be submitted.

Orlando Chamberlain (2):
Documentation: leds: standardise keyboard backlight led names
HID: hid-apple-magic-backlight: Add driver for keyboard backlight on
internal Magic Keyboards

Documentation/leds/well-known-leds.txt | 8 ++
MAINTAINERS | 6 ++
drivers/hid/Kconfig | 13 +++
drivers/hid/Makefile | 1 +
drivers/hid/hid-apple-magic-backlight.c | 120 ++++++++++++++++++++++++
5 files changed, 148 insertions(+)
create mode 100644 drivers/hid/hid-apple-magic-backlight.c

Comments

Aditya Garg July 3, 2024, 11:21 a.m. UTC | #1 
> On 2 Jul 2024, at 12:48 AM, Aditya Garg <gargaditya08@live.com> wrote:
> 
> This patchseries adds support for the internal keyboard backlight of
> Macs with Apple's "Magic" keyboard (MacBookPro16,* and MacBookAir9,1),
> and also documents what names should be used for keyboard backlight
> leds in Documentation/leds/well-known-leds.txt.
> 
> A separate driver for the purpose of backlight has been chosen because:
> 
> 1. On the MacBookAir9,1 there is a USB device dedicated just for keyboard
>  backlight by the name of Touchbar Backlight. Adding its support to any other
>  hid-driver breaks the device.
> 

Thanks to Orlando’s help, I managed to port the backlight code to already existing hid-apple

So, consider https://lore.kernel.org/lkml/16C35623-78AE-44B9-8D54-CA9584AEC49E@live.com/T/#u instead of this patch series.

> 2. It’s now possible to use drm on the Touch Bar (similar to what macOS does).
>  So, the Touch Bar drivers intended to be upstreamed before are no longer used.
>  https://lore.kernel.org/all/868AA58D-2399-4E4A-A6C6-73F88DB13992@live.com/
>  The driver that supports drm is still out of tree and yet to be submitted.
> 
> Orlando Chamberlain (2):
> Documentation: leds: standardise keyboard backlight led names
> HID: hid-apple-magic-backlight: Add driver for keyboard backlight on
> internal Magic Keyboards
> 
> Documentation/leds/well-known-leds.txt | 8 ++
> MAINTAINERS | 6 ++
> drivers/hid/Kconfig | 13 +++
> drivers/hid/Makefile | 1 +
> drivers/hid/hid-apple-magic-backlight.c | 120 ++++++++++++++++++++++++
> 5 files changed, 148 insertions(+)
> create mode 100644 drivers/hid/hid-apple-magic-backlight.c
> 
> -- 
> 2.39.2