[v2,0/2] Add HX83102j driver for HIMAX HID touchscreen

Message

Allen_Lin Dec. 6, 2023, 10:35 a.m. UTC

Hi,
This driver implements for HIMAX HID touchscreen HX8310XX series. 

Using SPI interface to acquire HID packets from driver. 

Patchs notes as below 
1. Add the Maintainer and devicetree bindings document for driver
2. Add the driver code and modify Kconfig/Makefiles to support the driver

change in v2 :
- Fix kernel test robot build warnings.

Thanks.

Allen_Lin (2):
  dt-bindings: input: Add Himax HX83102J touchscreen
  Input: Add Himax HX83102J touchscreen driver

 .../bindings/input/himax,hx8310xx.yaml        |   70 +
 MAINTAINERS                                   |    8 +
 drivers/hid/Kconfig                           |    9 +-
 drivers/hid/Makefile                          |    2 +-
 drivers/hid/hid-himax-83102j.c                | 3175 +++++++++++++++++
 drivers/hid/hid-himax-83102j.h                |  923 +++++
 6 files changed, 4185 insertions(+), 2 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/input/himax,hx8310xx.yaml
 create mode 100644 drivers/hid/hid-himax-83102j.c
 create mode 100644 drivers/hid/hid-himax-83102j.h

Comments

Krzysztof Kozlowski Dec. 6, 2023, 11 a.m. UTC | #1

On 06/12/2023 11:35, Allen_Lin wrote:
> Hi,
> This driver implements for HIMAX HID touchscreen HX8310XX series. 
> 
> Using SPI interface to acquire HID packets from driver. 
> 
> Patchs notes as below 
> 1. Add the Maintainer and devicetree bindings document for driver
> 2. Add the driver code and modify Kconfig/Makefiles to support the driver
> 
> change in v2 :
> - Fix kernel test robot build warnings.

I reviewed v1, so you must fix everything I pointed out. This code is in
absolutely terrible shape. It way over complicated, with way too many
structures, way too many abstractions (you must have exactly 0
abstractions). It was not written in Linux style.

Best regards,
Krzysztof