From patchwork Tue Jul 21 02:23:42 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "james.chen" X-Patchwork-Id: 6831941 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 448099F1D4 for ; Tue, 21 Jul 2015 02:23:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 57143206A0 for ; Tue, 21 Jul 2015 02:23:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 75EA22069A for ; Tue, 21 Jul 2015 02:23:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753024AbbGUCXu (ORCPT ); Mon, 20 Jul 2015 22:23:50 -0400 Received: from emcscan.emc.com.tw ([192.72.220.5]:43738 "EHLO emcscan.emc.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751580AbbGUCXu (ORCPT ); Mon, 20 Jul 2015 22:23:50 -0400 Received: from unknown (HELO emc.com.tw) ([192.168.10.1]) by emcscan.emc.com.tw with ESMTP; 21 Jul 2015 10:23:49 +0800 Received: from NB90032 ([192.168.55.89]) by emc.com.tw (8.13.7+Sun/8.13.7) with ESMTP id t6L2NkTI021315; Tue, 21 Jul 2015 10:23:46 +0800 (CST) From: "James Chen" To: "'Dmitry Torokhov'" , "'Herman Lin'" , , References: <1437444582-9653-1-git-send-email-james.chen@emc.com.tw> In-Reply-To: <1437444582-9653-1-git-send-email-james.chen@emc.com.tw> Subject: RE: [PATCH] CHROMIUM: elants_i2c.c: Disable idle mode before firmware upgrade procedure. Date: Tue, 21 Jul 2015 10:23:42 +0800 Message-ID: <001601d0c35c$461b5bb0$d2521310$@emc.com.tw> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQJpjPferlPgCnZz/+dwtm5X8eriY5yzncEw Content-Language: zh-tw Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Dear all: Sorry for mistyped. Please abandon this patch. And review next patch as shown in below. [PATCH 2/2] CHROMIUM: elants_i2c.c: Disable idle mode before firmware upgrade procedure. -----Original Message----- From: linux-input-owner@vger.kernel.org [mailto:linux-input-owner@vger.kernel.org] On Behalf Of james.chen Sent: Tuesday, July 21, 2015 10:10 AM To: Dmitry Torokhov; Herman Lin; linux-input@vger.kernel.org; charliemooney@chromium.org Cc: james.chen Subject: [PATCH] CHROMIUM: elants_i2c.c: Disable idle mode before firmware upgrade procedure. From: "james.chen" This patch is disable idle mode before firmware upgrade procedure. BUG=chrome-os-partner:39373 TEST= Test Elan touchscreen on cyan project(kernel 3.18) without problems. --- drivers/input/touchscreen/elants_i2c.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) int page, n_fw_pages; @@ -617,8 +618,13 @@ static int elants_i2c_do_update_firmware(struct i2c_client *client, } else { /* Start IAP Procedure */ dev_dbg(&client->dev, "Normal IAP procedure\n"); + /* Close idle mode */ + error = elants_i2c_send(client, close_idle, sizeof(close_idle)); + if (error) + dev_err(&client->dev, "Failed close idle: %d\n", error); + msleep(60); elants_i2c_sw_reset(client); - + msleep(20); error = elants_i2c_send(client, enter_iap, sizeof(enter_iap)); } -- 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c index 0efd766..6d3570e 100644 --- a/drivers/input/touchscreen/elants_i2c.c +++ b/drivers/input/touchscreen/elants_i2c.c @@ -605,6 +605,7 @@ static int elants_i2c_do_update_firmware(struct i2c_client *client, const u8 enter_iap[] = { 0x45, 0x49, 0x41, 0x50 }; const u8 enter_iap2[] = { 0x54, 0x00, 0x12, 0x34 }; const u8 iap_ack[] = { 0x55, 0xaa, 0x33, 0xcc }; + const u8 close_idle[] = {0x54, 0x2c, 0x01, 0x01}; u8 buf[HEADER_SIZE]; u16 send_id;