From patchwork Thu Dec 10 13:18:16 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anisse Astier X-Patchwork-Id: 66251 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id nBADRnQe018006 for ; Thu, 10 Dec 2009 13:27:49 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759394AbZLJN1l (ORCPT ); Thu, 10 Dec 2009 08:27:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759452AbZLJN1l (ORCPT ); Thu, 10 Dec 2009 08:27:41 -0500 Received: from mail-ew0-f219.google.com ([209.85.219.219]:45121 "EHLO mail-ew0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759394AbZLJN1i (ORCPT ); Thu, 10 Dec 2009 08:27:38 -0500 Received: by ewy19 with SMTP id 19so4303562ewy.21 for ; Thu, 10 Dec 2009 05:27:43 -0800 (PST) Received: by 10.213.107.131 with SMTP id b3mr2723349ebp.91.1260451663778; Thu, 10 Dec 2009 05:27:43 -0800 (PST) Received: from localhost.localdomain (253.175.70-86.rev.gaoland.net [86.70.175.253]) by mx.google.com with ESMTPS id 14sm508811ewy.11.2009.12.10.05.27.42 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 10 Dec 2009 05:27:43 -0800 (PST) From: Anisse Astier To: linux-acpi@vger.kernel.org, linux-input@vger.kernel.org Cc: Dmitry Torokhov , Len Brown , Matthew Garrett , Thomas Renninger , Carlos Corbacho , Matt Chen , Anisse Astier Subject: [PATCH 4/7] msi-wmi: remove custom runtime debug implementation Date: Thu, 10 Dec 2009 14:18:16 +0100 Message-Id: <1260451099-25620-5-git-send-email-anisse@astier.eu> X-Mailer: git-send-email 1.6.5.3 In-Reply-To: <1260451099-25620-1-git-send-email-anisse@astier.eu> References: <1260451099-25620-1-git-send-email-anisse@astier.eu> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi-wmi.c index dcb048c..75e422b 100644 --- a/drivers/platform/x86/msi-wmi.c +++ b/drivers/platform/x86/msi-wmi.c @@ -31,10 +31,6 @@ MODULE_AUTHOR("Thomas Renninger "); MODULE_DESCRIPTION("MSI laptop WMI hotkeys driver"); MODULE_LICENSE("GPL"); -static int debug; -module_param(debug, int, 0); -MODULE_PARM_DESC(debug, "Set this to 1 to let the driver be more verbose"); - MODULE_ALIAS("wmi:551A1F84-FBDD-4125-91DB-3EA8F44F1D45"); MODULE_ALIAS("wmi:B6F3EEF2-3D2F-49DC-9DE3-85BCE18C62F2"); @@ -54,10 +50,7 @@ MODULE_ALIAS("dmi:*:svnMICRO-STARINTERNATIONAL*:pnMS-6638:*"); #define MSIWMI_BIOS_GUID "551A1F84-FBDD-4125-91DB-3EA8F44F1D45" #define MSIWMI_EVENT_GUID "B6F3EEF2-3D2F-49DC-9DE3-85BCE18C62F2" -#define dprintk(msg...) do { \ - if (debug) \ - printk(KERN_INFO DRV_PFX msg); \ - } while (0) +#define dprintk(msg...) pr_debug(DRV_PFX msg) struct key_entry { char type; /* See KE_* below */ @@ -343,7 +336,7 @@ static int __init msi_wmi_init(void) backlight->props.brightness = err; } - printk(KERN_INFO DRV_PFX "Event handler installed\n"); + dprintk("Event handler installed\n"); return 0;