From patchwork Tue May 18 20:10:28 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Henrik Rydberg X-Patchwork-Id: 100591 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o4IKBOgN019643 for ; Tue, 18 May 2010 20:11:24 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752906Ab0ERULI (ORCPT ); Tue, 18 May 2010 16:11:08 -0400 Received: from ch-smtp02.sth.basefarm.net ([80.76.149.213]:35869 "EHLO ch-smtp02.sth.basefarm.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758058Ab0ERULG (ORCPT ); Tue, 18 May 2010 16:11:06 -0400 Received: from c83-248-196-134.bredband.comhem.se ([83.248.196.134]:39893 helo=alnilam) by ch-smtp02.sth.basefarm.net with smtp (Exim 4.68) (envelope-from ) id 1OET7t-0007Bu-7c; Tue, 18 May 2010 22:10:56 +0200 Received: by alnilam (sSMTP sendmail emulation); Tue, 18 May 2010 22:10:49 +0200 From: "Henrik Rydberg" To: Dmitry Torokhov Cc: Andrew Morton , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Mika Kuoppala , Peter Hutterer , Benjamin Tissoires , Stephane Chatty , Rafi Rubin , Michael Poole , Henrik Rydberg Subject: [PATCH] input: mt: Introduce MT event slots (rev 3) Date: Tue, 18 May 2010 22:10:28 +0200 Message-Id: <1274213429-22667-1-git-send-email-rydberg@euromail.se> X-Mailer: git-send-email 1.6.3.3 X-Originating-IP: 83.248.196.134 X-Scan-Result: No virus found in message 1OET7t-0007Bu-7c. X-Scan-Signature: ch-smtp02.sth.basefarm.net 1OET7t-0007Bu-7c 2d0adc81029338471d917281a7a64242 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Tue, 18 May 2010 20:11:24 +0000 (UTC) diff --git a/drivers/input/input.c b/drivers/input/input.c index 9c79bd5..2007488 100644 --- a/drivers/input/input.c +++ b/drivers/input/input.c @@ -34,9 +34,9 @@ MODULE_LICENSE("GPL"); #define INPUT_DEVICES 256 /* - * EV_ABS events which should not be cached are listed here. + * EV_ABS events which should be filtered on a per-slot basis are listed here. */ -static unsigned int input_abs_bypass_init_data[] __initdata = { +static unsigned int input_mt_abs_map_init_data[] __initdata = { ABS_MT_TOUCH_MAJOR, ABS_MT_TOUCH_MINOR, ABS_MT_WIDTH_MAJOR, @@ -48,9 +48,8 @@ static unsigned int input_abs_bypass_init_data[] __initdata = { ABS_MT_BLOB_ID, ABS_MT_TRACKING_ID, ABS_MT_PRESSURE, - 0 }; -static unsigned long input_abs_bypass[BITS_TO_LONGS(ABS_CNT)]; +static unsigned char input_mt_abs_map[ABS_CNT]; static LIST_HEAD(input_dev_list); static LIST_HEAD(input_handler_list); @@ -181,6 +180,26 @@ static void input_stop_autorepeat(struct input_dev *dev) #define INPUT_PASS_TO_DEVICE 2 #define INPUT_PASS_TO_ALL (INPUT_PASS_TO_HANDLERS | INPUT_PASS_TO_DEVICE) +static void input_mt_handle_abs_event(struct input_dev *dev, + unsigned int code, int value) +{ + if (dev->mt) { + struct input_mt_slot *mtslot = &dev->mt[dev->slot]; + unsigned int mtcode = input_mt_abs_map[code] - 1; + int old = mtslot->abs[mtcode]; + value = input_defuzz_abs_event(value, old, dev->absfuzz[code]); + if (value == old) + return; + mtslot->abs[mtcode] = value; + } + dev->sync = 0; + if (dev->slot != dev->last_slot) { + dev->last_slot = dev->slot; + input_pass_event(dev, EV_SYN, SYN_MT_SLOT, dev->slot); + } + input_pass_event(dev, EV_ABS, code, value); +} + static void input_handle_event(struct input_dev *dev, unsigned int type, unsigned int code, int value) { @@ -204,6 +223,10 @@ static void input_handle_event(struct input_dev *dev, dev->sync = 0; disposition = INPUT_PASS_TO_HANDLERS; break; + case SYN_MT_SLOT: + if (value >= 0 && value < dev->mtsize) + dev->slot = value; + break; } break; @@ -235,9 +258,9 @@ static void input_handle_event(struct input_dev *dev, case EV_ABS: if (is_event_supported(code, dev->absbit, ABS_MAX)) { - if (test_bit(code, input_abs_bypass)) { - disposition = INPUT_PASS_TO_HANDLERS; - break; + if (input_mt_abs_map[code]) { + input_mt_handle_abs_event(dev, code, value); + return; } value = input_defuzz_abs_event(value, @@ -1278,6 +1301,7 @@ static void input_dev_release(struct device *device) struct input_dev *dev = to_input_dev(device); input_ff_destroy(dev); + input_mt_destroy_slots(dev); kfree(dev); module_put(THIS_MODULE); @@ -1518,6 +1542,43 @@ void input_free_device(struct input_dev *dev) EXPORT_SYMBOL(input_free_device); /** + * input_mt_create_slots() - create MT input slots + * @dev: input device supporting MT events and finger tracking + * @max_slots: maximum number of slots supported by the device + * + * This function allocates all necessary memory for MT slot handling + * in the input device. + */ +int input_mt_create_slots(struct input_dev *dev, int max_slots) +{ + struct input_mt_slot *mt; + + mt = kzalloc(max_slots * sizeof(struct input_mt_slot), GFP_KERNEL); + if (!mt) + return -ENOMEM; + + dev->mt = mt; + dev->mtsize = max_slots; + return 0; +} +EXPORT_SYMBOL(input_mt_create_slots); + +/** + * input_mt_destroy_slots() - frees the MT slots of the input device + * @dev: input device with allocated MT slots + * + * This function is only needed in error path as the input core will + * automatically free the MT slots when the device is destroyed. + */ +void input_mt_destroy_slots(struct input_dev *dev) +{ + kfree(dev->mt); + dev->mt = NULL; + dev->mtsize = 0; +} +EXPORT_SYMBOL(input_mt_destroy_slots); + +/** * input_set_capability - mark device as capable of a certain event * @dev: device that is capable of emitting or accepting event * @type: type of the event (EV_KEY, EV_REL, etc...) @@ -1926,19 +1987,20 @@ static const struct file_operations input_fops = { .open = input_open_file, }; -static void __init input_init_abs_bypass(void) +static void __init input_mt_init_maps(void) { - const unsigned int *p; - - for (p = input_abs_bypass_init_data; *p; p++) - input_abs_bypass[BIT_WORD(*p)] |= BIT_MASK(*p); + int i; + BUILD_BUG_ON(MT_ABS_SIZE != (typeof(input_mt_abs_map[0]))MT_ABS_SIZE); + BUILD_BUG_ON(ARRAY_SIZE(input_mt_abs_map_init_data) > MT_ABS_SIZE); + for (i = 0; i < ARRAY_SIZE(input_mt_abs_map_init_data); i++) + input_mt_abs_map[input_mt_abs_map_init_data[i]] = i + 1; } static int __init input_init(void) { int err; - input_init_abs_bypass(); + input_mt_init_maps(); err = class_register(&input_class); if (err) { diff --git a/include/linux/input.h b/include/linux/input.h index 7ed2251..596ba29 100644 --- a/include/linux/input.h +++ b/include/linux/input.h @@ -108,6 +108,7 @@ struct input_absinfo { #define SYN_REPORT 0 #define SYN_CONFIG 1 #define SYN_MT_REPORT 2 +#define SYN_MT_SLOT 3 /* * Keys and buttons @@ -1080,6 +1081,10 @@ struct ff_effect { * @sync: set to 1 when there were no new events since last EV_SYNC * @abs: current values for reports from absolute axes * @rep: current values for autorepeat parameters (delay, rate) + * @mt: array of MT slots + * @mtsize: number of allocated MT slots + * @slot: current MT slot + * @last_slot: last MT slot reported * @key: reflects current state of device's keys/buttons * @led: reflects current state of device's LEDs * @snd: reflects current state of sound effects @@ -1157,6 +1162,11 @@ struct input_dev { int abs[ABS_MAX + 1]; int rep[REP_MAX + 1]; + struct input_mt_slot *mt; + int mtsize; + int slot; + int last_slot; + unsigned long key[BITS_TO_LONGS(KEY_CNT)]; unsigned long led[BITS_TO_LONGS(LED_CNT)]; unsigned long snd[BITS_TO_LONGS(SND_CNT)]; @@ -1405,6 +1415,11 @@ static inline void input_mt_sync(struct input_dev *dev) input_event(dev, EV_SYN, SYN_MT_REPORT, 0); } +static inline void input_mt_slot(struct input_dev *dev, int slot) +{ + input_event(dev, EV_SYN, SYN_MT_SLOT, slot); +} + void input_set_capability(struct input_dev *dev, unsigned int type, unsigned int code); static inline void input_set_abs_params(struct input_dev *dev, int axis, int min, int max, int fuzz, int flat) @@ -1484,5 +1499,18 @@ int input_ff_erase(struct input_dev *dev, int effect_id, struct file *file); int input_ff_create_memless(struct input_dev *dev, void *data, int (*play_effect)(struct input_dev *, void *, struct ff_effect *)); +#define MT_ABS_SIZE 11 + +/** + * struct input_mt_slot - represents the state of an input MT slot + * @abs: current values of ABS_MT axes for this slot + */ +struct input_mt_slot { + int abs[MT_ABS_SIZE]; +}; + +int input_mt_create_slots(struct input_dev *dev, int max_slots); +void input_mt_destroy_slots(struct input_dev *dev); + #endif #endif