| Message ID | 1309908304-18792-1-git-send-email-pinglinux@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 998c454e1c850f8e5cc0ae2299c4789b395d6d98 |
| Headers | show |
On Tue, Jul 5, 2011 at 6:25 PM, Ping Cheng <pinglinux@gmail.com> wrote: > With the removal of BTN_TOOL_FINGER for tablet buttons and > expresskeys, serial number is needed to distingush if the > events were from a regular tool (stylus, eraser, or mouse) > or the attribures (buttons, strips, or wheels) on the tablet > since there are overlapped events between the tools and the > tablet attributes. > > Signed-off-by: Ping Cheng <pingc@wacom.com> This patch I believe will even work in isolation of others in series and will fix some pad button issues reported by various graphire users. Reviewed-by: Chris Bagwell <chris@cnpbagwell.com> > --- > drivers/input/tablet/wacom_wac.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c > index 7ce1294..b93501a 100644 > --- a/drivers/input/tablet/wacom_wac.c > +++ b/drivers/input/tablet/wacom_wac.c > @@ -265,6 +265,7 @@ static int wacom_graphire_irq(struct wacom_wac *wacom) > wacom->id[0] = 0; > input_report_abs(input, ABS_MISC, wacom->id[0]); /* report tool id */ > input_report_key(input, wacom->tool[0], prox); > + input_event(input, EV_MSC, MSC_SERIAL, 1); > input_sync(input); /* sync last event */ > } > > -- > 1.7.5.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c index 7ce1294..b93501a 100644 --- a/drivers/input/tablet/wacom_wac.c +++ b/drivers/input/tablet/wacom_wac.c @@ -265,6 +265,7 @@ static int wacom_graphire_irq(struct wacom_wac *wacom) wacom->id[0] = 0; input_report_abs(input, ABS_MISC, wacom->id[0]); /* report tool id */ input_report_key(input, wacom->tool[0], prox); + input_event(input, EV_MSC, MSC_SERIAL, 1); input_sync(input); /* sync last event */ }
With the removal of BTN_TOOL_FINGER for tablet buttons and expresskeys, serial number is needed to distingush if the events were from a regular tool (stylus, eraser, or mouse) or the attribures (buttons, strips, or wheels) on the tablet since there are overlapped events between the tools and the tablet attributes. Signed-off-by: Ping Cheng <pingc@wacom.com> --- drivers/input/tablet/wacom_wac.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)