From patchwork Tue Jul 12 07:13:51 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: axel lin X-Patchwork-Id: 967382 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p6C7E15Y026396 for ; Tue, 12 Jul 2011 07:14:03 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751831Ab1GLHN7 (ORCPT ); Tue, 12 Jul 2011 03:13:59 -0400 Received: from mail-yi0-f46.google.com ([209.85.218.46]:33927 "EHLO mail-yi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751789Ab1GLHN7 (ORCPT ); Tue, 12 Jul 2011 03:13:59 -0400 Received: by yia27 with SMTP id 27so1827521yia.19 for ; Tue, 12 Jul 2011 00:13:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=subject:from:to:cc:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; bh=/RBkORVNCaV723sXMFHwhG9MOkXD+rqQLevShI9+9kw=; b=AmqkzvWSuypUV2kCqbd1hHRbs2baC9MY4m4H6VcgRFEY8zRO4b0sC4PT5fZTuf9PhX LCsuZYbetMCjukdWyjaxlN2sQy2K1aBQfbUsbJx/3+a+J2XKzl+fQpGV36QZHWBlLlix N8cq7RKaxjY367izTYxzLX3p2hQ9K129R+pFc= Received: by 10.150.140.15 with SMTP id n15mr4649714ybd.446.1310454838397; Tue, 12 Jul 2011 00:13:58 -0700 (PDT) Received: from [218.172.239.112] (218-172-239-112.dynamic.hinet.net [218.172.239.112]) by mx.google.com with ESMTPS id u17sm4366093ybl.18.2011.07.12.00.13.55 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 12 Jul 2011 00:13:58 -0700 (PDT) Subject: [PATCH] Input: intel-mid-touch - remove pointless checking for variable 'found' From: Axel Lin To: linux-kernel@vger.kernel.org Cc: "Sreedhara Murthy. D.S" , Dmitry Torokhov , linux-input@vger.kernel.org Date: Tue, 12 Jul 2011 15:13:51 +0800 Message-ID: <1310454831.16511.1.camel@phoenix> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Tue, 12 Jul 2011 07:14:26 +0000 (UTC) The implementation does break from the for loop after we assign i to variable 'found'. Signed-off-by: Axel Lin --- drivers/input/touchscreen/intel-mid-touch.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/input/touchscreen/intel-mid-touch.c b/drivers/input/touchscreen/intel-mid-touch.c index 66c96bf..9283284 100644 --- a/drivers/input/touchscreen/intel-mid-touch.c +++ b/drivers/input/touchscreen/intel-mid-touch.c @@ -454,9 +454,6 @@ static int __devinit mrstouch_chan_parse(struct mrstouch_dev *tsdev) found = -1; for (i = 0; i < MRSTOUCH_MAX_CHANNELS; i++) { - if (found >= 0) - break; - err = intel_scu_ipc_ioread8(PMICADDR0 + i, &r8); if (err) return err;