| Message ID | 1310562419.5753.2.camel@phoenix (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2c204109ec1018f72114c7f19132a1109a3f0653 |
| Headers | show |
On Wed, 13 Jul 2011 21:06:59 +0800 Axel Lin <axel.lin@gmail.com> wrote: > The implementation in cy8ctmg110_probe() does not properly set reset_pin > and irq_pin from platform data. Let's fix it. > > Signed-off-by: Axel Lin <axel.lin@gmail.com> > --- > Current implementation returns -ENODEV if no pdata available. > But it does not use the information from pdata. > I think currently the driver does not work because both ts->reset_pin and ts->irq_pin are 0, then gpio_request with ts->irq_pin will fail. > > Just found this bug while reading the code. > I don't have this hardware. I appreciate if someone can test it. Looks right, but I'm likewise unable to test it as I no longer have access to a device using it. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/input/touchscreen/cy8ctmg110_ts.c b/drivers/input/touchscreen/cy8ctmg110_ts.c index d7afa20..cd60b3c 100644 --- a/drivers/input/touchscreen/cy8ctmg110_ts.c +++ b/drivers/input/touchscreen/cy8ctmg110_ts.c @@ -193,6 +193,8 @@ static int __devinit cy8ctmg110_probe(struct i2c_client *client, ts->client = client; ts->input = input_dev; + ts->reset_pin = pdata->reset_pin; + ts->irq_pin = pdata->irq_pin; snprintf(ts->phys, sizeof(ts->phys), "%s/input0", dev_name(&client->dev));
The implementation in cy8ctmg110_probe() does not properly set reset_pin and irq_pin from platform data. Let's fix it. Signed-off-by: Axel Lin <axel.lin@gmail.com> --- Current implementation returns -ENODEV if no pdata available. But it does not use the information from pdata. I think currently the driver does not work because both ts->reset_pin and ts->irq_pin are 0, then gpio_request with ts->irq_pin will fail. Just found this bug while reading the code. I don't have this hardware. I appreciate if someone can test it. Axel drivers/input/touchscreen/cy8ctmg110_ts.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)