| Message ID | 1310564781-5979-1-git-send-email-monstr@monstr.eu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jul 13, 2011 at 10:46 PM, Michal Simek <monstr@monstr.eu> wrote: > Add missing header. > > Error log: > CC drivers/input/serio/xilinx_ps2.o > drivers/input/serio/xilinx_ps2.c: In function 'xps2_of_probe': > drivers/input/serio/xilinx_ps2.c:249: error: implicit declaration of function 'of_address_to_resource' > > Signed-off-by: Michal Simek <monstr@monstr.eu> Acked-by: Grant Likely <grant.likely@secretlab.ca> > --- > drivers/input/serio/xilinx_ps2.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/input/serio/xilinx_ps2.c b/drivers/input/serio/xilinx_ps2.c > index 80baa53..d64c5a4 100644 > --- a/drivers/input/serio/xilinx_ps2.c > +++ b/drivers/input/serio/xilinx_ps2.c > @@ -23,7 +23,7 @@ > #include <linux/init.h> > #include <linux/list.h> > #include <linux/io.h> > - > +#include <linux/of_address.h> > #include <linux/of_device.h> > #include <linux/of_platform.h> > > -- > 1.5.5.6 > >
Hi Grant, can you propose this patch to mainline through your devicetree tree? Thanks, Michal Grant Likely wrote: > On Wed, Jul 13, 2011 at 10:46 PM, Michal Simek <monstr@monstr.eu> wrote: >> Add missing header. >> >> Error log: >> CC drivers/input/serio/xilinx_ps2.o >> drivers/input/serio/xilinx_ps2.c: In function 'xps2_of_probe': >> drivers/input/serio/xilinx_ps2.c:249: error: implicit declaration of function 'of_address_to_resource' >> >> Signed-off-by: Michal Simek <monstr@monstr.eu> > > Acked-by: Grant Likely <grant.likely@secretlab.ca> > >> --- >> drivers/input/serio/xilinx_ps2.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/input/serio/xilinx_ps2.c b/drivers/input/serio/xilinx_ps2.c >> index 80baa53..d64c5a4 100644 >> --- a/drivers/input/serio/xilinx_ps2.c >> +++ b/drivers/input/serio/xilinx_ps2.c >> @@ -23,7 +23,7 @@ >> #include <linux/init.h> >> #include <linux/list.h> >> #include <linux/io.h> >> - >> +#include <linux/of_address.h> >> #include <linux/of_device.h> >> #include <linux/of_platform.h> >> >> -- >> 1.5.5.6 >> >> > > >
On Sun, Jul 24, 2011 at 03:51:30PM +0200, Michal Simek wrote: > Hi Grant, > > can you propose this patch to mainline through your devicetree tree? I've got it in a "input/next" branch. Since the input maintainer doesn't seem to be active on driver patches, I'll send a pull req to Linus. g. > > Thanks, > Michal > > Grant Likely wrote: > >On Wed, Jul 13, 2011 at 10:46 PM, Michal Simek <monstr@monstr.eu> wrote: > >>Add missing header. > >> > >>Error log: > >>CC drivers/input/serio/xilinx_ps2.o > >>drivers/input/serio/xilinx_ps2.c: In function 'xps2_of_probe': > >>drivers/input/serio/xilinx_ps2.c:249: error: implicit declaration of function 'of_address_to_resource' > >> > >>Signed-off-by: Michal Simek <monstr@monstr.eu> > > > >Acked-by: Grant Likely <grant.likely@secretlab.ca> > > > >>--- > >> drivers/input/serio/xilinx_ps2.c | 2 +- > >> 1 files changed, 1 insertions(+), 1 deletions(-) > >> > >>diff --git a/drivers/input/serio/xilinx_ps2.c b/drivers/input/serio/xilinx_ps2.c > >>index 80baa53..d64c5a4 100644 > >>--- a/drivers/input/serio/xilinx_ps2.c > >>+++ b/drivers/input/serio/xilinx_ps2.c > >>@@ -23,7 +23,7 @@ > >> #include <linux/init.h> > >> #include <linux/list.h> > >> #include <linux/io.h> > >>- > >>+#include <linux/of_address.h> > >> #include <linux/of_device.h> > >> #include <linux/of_platform.h> > >> > >>-- > >>1.5.5.6 > >> > >> > > > > > > > > > -- > Michal Simek, Ing. (M.Eng) > w: www.monstr.eu p: +42-0-721842854 > Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ > Microblaze U-BOOT custodian -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Jul 30, 2011 at 10:12:30PM -0600, Grant Likely wrote: > On Sun, Jul 24, 2011 at 03:51:30PM +0200, Michal Simek wrote: > > Hi Grant, > > > > can you propose this patch to mainline through your devicetree tree? > > I've got it in a "input/next" branch. Since the input maintainer > doesn't seem to be active on driver patches, I'll send a pull req to > Linus. CCing me on patches usually helps... Yes, please feel free to push through your tree if you'd like.
diff --git a/drivers/input/serio/xilinx_ps2.c b/drivers/input/serio/xilinx_ps2.c index 80baa53..d64c5a4 100644 --- a/drivers/input/serio/xilinx_ps2.c +++ b/drivers/input/serio/xilinx_ps2.c @@ -23,7 +23,7 @@ #include <linux/init.h> #include <linux/list.h> #include <linux/io.h> - +#include <linux/of_address.h> #include <linux/of_device.h> #include <linux/of_platform.h>
Add missing header. Error log: CC drivers/input/serio/xilinx_ps2.o drivers/input/serio/xilinx_ps2.c: In function 'xps2_of_probe': drivers/input/serio/xilinx_ps2.c:249: error: implicit declaration of function 'of_address_to_resource' Signed-off-by: Michal Simek <monstr@monstr.eu> --- drivers/input/serio/xilinx_ps2.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)