diff mbox

kxtj9: fix input device allocation sequence

Message ID 1310568519-28103-1-git-send-email-chris.hudson.comp.eng@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Christopher Hudson July 13, 2011, 2:48 p.m. UTC 
From: Chris Hudson <chudson@kionix.com>

Small bug fix patch against the driver version in Dmitry's queue.  Resulting
driver tested on hardware in both polled and IRQ modes.

Signed-off-by: Chris Hudson <chudson@kionix.com>
---
 drivers/input/misc/kxtj9.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Dmitry Torokhov July 20, 2011, 6:15 a.m. UTC | #1 
On Wed, Jul 13, 2011 at 10:48:39AM -0400, chris.hudson.comp.eng@gmail.com wrote:
> From: Chris Hudson <chudson@kionix.com>
> 
> Small bug fix patch against the driver version in Dmitry's queue.  Resulting
> driver tested on hardware in both polled and IRQ modes.
> 

Hmm, I tried applying the patch but the version I have in my public tree
(that was committed on July 6th) already has this fix...

Oh, you did mention the correct function (kxtj9_setup_input_device) in
your first e-mail, but then in this patch you are trying to change
kxtj9_setup_polled_device for some reason.

Anyway, I just got the patch addressing this issue from Dan Carpenter so
I will aplly it.

Thanks.
diff mbox

Patch

diff --git a/drivers/input/misc/kxtj9.c b/drivers/input/misc/kxtj9.c
index 1788390..1799430 100644
--- a/drivers/input/misc/kxtj9.c
+++ b/drivers/input/misc/kxtj9.c
@@ -426,7 +426,7 @@  static int __devinit kxtj9_setup_polled_device(struct kxtj9_data *tj9)
 	struct input_polled_dev *poll_dev;
 	poll_dev = input_allocate_polled_device();
 
-	if (!tj9->poll_dev) {
+	if (!poll_dev) {
 		dev_err(&tj9->client->dev,
 			"Failed to allocate polled device\n");
 		return -ENOMEM;