diff mbox

Input: mpu3050 - call input_free_device() in mpu3050_probe() error handling

Message ID 1311147490.10091.1.camel@phoenix (mailing list archive)
State Accepted
Commit d9b830fa444c1f4955d0ee88f5af2aa24d2c7837
Headers show

Commit Message

axel lin July 20, 2011, 7:38 a.m. UTC 
From 3dcc899388d98a68c22d14b3149d3cc472f8d2fa Mon Sep 17 00:00:00 2001
From: Axel Lin <axel.lin@gmail.com>
Date: Wed, 20 Jul 2011 15:34:33 +0800
Subject: [PATCH] Input: mpu3050 - correct call to input_free_device

input_free_device() should be used if input_register_device() was not called
yet or if it failed.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/input/misc/mpu3050.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

axel lin Aug. 11, 2011, 7:52 a.m. UTC | #1 
2011/7/20 Axel Lin <axel.lin@gmail.com>:
> From 3dcc899388d98a68c22d14b3149d3cc472f8d2fa Mon Sep 17 00:00:00 2001
> From: Axel Lin <axel.lin@gmail.com>
> Date: Wed, 20 Jul 2011 15:34:33 +0800
> Subject: [PATCH] Input: mpu3050 - correct call to input_free_device
>
> input_free_device() should be used if input_register_device() was not called
> yet or if it failed.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
hi Dmitry,
Seems this fix is not yet upstream.

Regards,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/input/misc/mpu3050.c b/drivers/input/misc/mpu3050.c
index b95fac1..f71dc72 100644
--- a/drivers/input/misc/mpu3050.c
+++ b/drivers/input/misc/mpu3050.c
@@ -282,7 +282,7 @@  err_free_irq:
 err_pm_set_suspended:
 	pm_runtime_set_suspended(&client->dev);
 err_free_mem:
-	input_unregister_device(idev);
+	input_free_device(idev);
 	kfree(sensor);
 	return error;
 }