| Message ID | 1311169146-20066-2-git-send-email-djkurtz@chromium.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On 07/20/2011 06:38 AM, djkurtz@chromium.org wrote: > From: Daniel Kurtz <djkurtz@chromium.org> > > Synaptics touchpads report increasing y from bottom to top. > This is inverted from normal userspace "top of screen is 0" coordinates. > Thus, the kernel driver reports inverted y coordinates to userspace. > > This patch refactors this inversion. > > Signed-off-by: Daniel Kurtz <djkurtz@chromium.org> Acked-by: Chase Douglas <chase.douglas@canonical.com> -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jul 20, 2011 at 09:38:58PM +0800, djkurtz@chromium.org wrote: > From: Daniel Kurtz <djkurtz@chromium.org> > > Synaptics touchpads report increasing y from bottom to top. > This is inverted from normal userspace "top of screen is 0" coordinates. > Thus, the kernel driver reports inverted y coordinates to userspace. > > This patch refactors this inversion. > I really do not see the point... Thanks.
On Mon, Jul 25, 2011 at 4:27 PM, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > On Wed, Jul 20, 2011 at 09:38:58PM +0800, djkurtz@chromium.org wrote: >> From: Daniel Kurtz <djkurtz@chromium.org> >> >> Synaptics touchpads report increasing y from bottom to top. >> This is inverted from normal userspace "top of screen is 0" coordinates. >> Thus, the kernel driver reports inverted y coordinates to userspace. >> >> This patch refactors this inversion. >> > > I really do not see the point... The point is that this inversion is done in 3 places in the driver. Refactoring lets us document why this inversion is happening in just a single place. > > Thanks. > > -- > Dmitry > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/25/2011 01:27 AM, Dmitry Torokhov wrote: > On Wed, Jul 20, 2011 at 09:38:58PM +0800, djkurtz@chromium.org wrote: >> From: Daniel Kurtz <djkurtz@chromium.org> >> >> Synaptics touchpads report increasing y from bottom to top. >> This is inverted from normal userspace "top of screen is 0" coordinates. >> Thus, the kernel driver reports inverted y coordinates to userspace. >> >> This patch refactors this inversion. >> > > I really do not see the point... It's easier for me to read and comprehend, at least. I agree that it's really really minor, but if it's in the middle of 10 other patches, then I don't have a problem with it. -- Chase -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index 5538fc6..297e88f 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -44,6 +44,16 @@ #define YMIN_NOMINAL 1408 #define YMAX_NOMINAL 4448 +/* + * Synaptics touchpads report the y coordinate from bottom to top, which is + * opposite from what userspace expects. + * This function is used to invert y before reporting. + */ +static int invert_y(int y) +{ + return YMAX_NOMINAL + YMIN_NOMINAL - y; +} + /***************************************************************************** * Stuff we need even when we do not want native Synaptics support @@ -502,8 +512,7 @@ static void synaptics_report_semi_mt_slot(struct input_dev *dev, int slot, input_mt_report_slot_state(dev, MT_TOOL_FINGER, active); if (active) { input_report_abs(dev, ABS_MT_POSITION_X, x); - input_report_abs(dev, ABS_MT_POSITION_Y, - YMAX_NOMINAL + YMIN_NOMINAL - y); + input_report_abs(dev, ABS_MT_POSITION_Y, invert_y(y)); } } @@ -597,7 +606,7 @@ static void synaptics_process_packet(struct psmouse *psmouse) if (num_fingers > 0) { input_report_abs(dev, ABS_X, hw.x); - input_report_abs(dev, ABS_Y, YMAX_NOMINAL + YMIN_NOMINAL - hw.y); + input_report_abs(dev, ABS_Y, invert_y(hw.y)); } input_report_abs(dev, ABS_PRESSURE, hw.z);