From patchwork Thu Jul 21 07:21:33 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: axel lin X-Patchwork-Id: 993962 X-Patchwork-Delegate: jikos@jikos.cz Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p6L7LjpC011512 for ; Thu, 21 Jul 2011 07:21:45 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751905Ab1GUHVo (ORCPT ); Thu, 21 Jul 2011 03:21:44 -0400 Received: from mail-yx0-f174.google.com ([209.85.213.174]:41940 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751818Ab1GUHVn (ORCPT ); Thu, 21 Jul 2011 03:21:43 -0400 Received: by yxi11 with SMTP id 11so522972yxi.19 for ; Thu, 21 Jul 2011 00:21:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=subject:from:to:cc:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; bh=EppYe8t5eD+tGNjmVEW3dhoAC2A7TCjfWs6HFrmrXYU=; b=MSaW2BPgYWrL2IDcDA3zfW9ylUj8E+5Ty3gJopuulu4Z46e35BB30kgAIMrjDn8tD0 xavIEOSvSoncmxFa3VMLxm8L526dDmOe3rGUkm8l5HhJBf4kDuHusM4K8iNCUd43M0Jo vRO5LftwewmZbil8xtWmfifj2UdjKlTKpF4yI= Received: by 10.150.160.3 with SMTP id i3mr241639ybe.406.1311232902698; Thu, 21 Jul 2011 00:21:42 -0700 (PDT) Received: from [218.172.232.249] (218-172-232-249.dynamic.hinet.net [218.172.232.249]) by mx.google.com with ESMTPS id s2sm1478601icw.5.2011.07.21.00.21.40 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 21 Jul 2011 00:21:41 -0700 (PDT) Subject: [PATCH] HID: prodikeys: make needlessly global symbols static From: Axel Lin To: linux-kernel@vger.kernel.org Cc: Don Prince , Jiri Kosina , linux-input@vger.kernel.org Date: Thu, 21 Jul 2011 15:21:33 +0800 Message-ID: <1311232893.10976.1.camel@phoenix> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Thu, 21 Jul 2011 07:21:46 +0000 (UTC) The following symbols are not referenced outside this file so there's no need for it to be in the global name space. pcmidi_sustained_note_release init_sustain_timers stop_sustain_timers pcmidi_handle_report pcmidi_setup_extra_keys pcmidi_snd_initialise pcmidi_snd_terminate Make them static. Signed-off-by: Axel Lin --- drivers/hid/hid-prodikeys.c | 15 ++++++++------- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/hid/hid-prodikeys.c b/drivers/hid/hid-prodikeys.c index ab19f29..7563229 100644 --- a/drivers/hid/hid-prodikeys.c +++ b/drivers/hid/hid-prodikeys.c @@ -242,7 +242,7 @@ drop_note: return; } -void pcmidi_sustained_note_release(unsigned long data) +static void pcmidi_sustained_note_release(unsigned long data) { struct pcmidi_sustain *pms = (struct pcmidi_sustain *)data; @@ -250,7 +250,7 @@ void pcmidi_sustained_note_release(unsigned long data) pms->in_use = 0; } -void init_sustain_timers(struct pcmidi_snd *pm) +static void init_sustain_timers(struct pcmidi_snd *pm) { struct pcmidi_sustain *pms; unsigned i; @@ -264,7 +264,7 @@ void init_sustain_timers(struct pcmidi_snd *pm) } } -void stop_sustain_timers(struct pcmidi_snd *pm) +static void stop_sustain_timers(struct pcmidi_snd *pm) { struct pcmidi_sustain *pms; unsigned i; @@ -499,7 +499,7 @@ static int pcmidi_handle_report4(struct pcmidi_snd *pm, u8 *data) return 1; } -int pcmidi_handle_report( +static int pcmidi_handle_report( struct pcmidi_snd *pm, unsigned report_id, u8 *data, int size) { int ret = 0; @@ -518,7 +518,8 @@ int pcmidi_handle_report( return ret; } -void pcmidi_setup_extra_keys(struct pcmidi_snd *pm, struct input_dev *input) +static void pcmidi_setup_extra_keys( + struct pcmidi_snd *pm, struct input_dev *input) { /* reassigned functionality for N/A keys MY PICTURES => KEY_WORDPROCESSOR @@ -602,7 +603,7 @@ static struct snd_rawmidi_ops pcmidi_in_ops = { .trigger = pcmidi_in_trigger }; -int pcmidi_snd_initialise(struct pcmidi_snd *pm) +static int pcmidi_snd_initialise(struct pcmidi_snd *pm) { static int dev; struct snd_card *card; @@ -720,7 +721,7 @@ fail: return err; } -int pcmidi_snd_terminate(struct pcmidi_snd *pm) +static int pcmidi_snd_terminate(struct pcmidi_snd *pm) { if (pm->card) { stop_sustain_timers(pm);