From patchwork Thu Aug 4 20:42:54 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bojan Prtvar X-Patchwork-Id: 1036792 X-Patchwork-Delegate: jikos@jikos.cz Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p74KllE4012701 for ; Thu, 4 Aug 2011 20:47:47 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753479Ab1HDUn3 (ORCPT ); Thu, 4 Aug 2011 16:43:29 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:42194 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752876Ab1HDUn2 (ORCPT ); Thu, 4 Aug 2011 16:43:28 -0400 Received: by eyx24 with SMTP id 24so804830eyx.19 for ; Thu, 04 Aug 2011 13:43:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; bh=2L9qxuBLM6r6jwBX2xV+cZ5tODO1pDZKP0drlYxHY8Q=; b=DS2M4ECUCkJxmmALLjreKl1T5/bEvvVsVBgU6oqP0oDwzWLXHoDaoNsU5kigddB7/d t5rSY9cj8CUatLqEQc0cHHvweqEZvgZ/ZE6rA+dX1YnyEqIR84iOmcuOBSZ2WRdO2Y/F rEslyrGtzQeDtmEjgvUKxBCueiZJMb3w4eNFc= Received: by 10.204.15.77 with SMTP id j13mr479760bka.190.1312490607335; Thu, 04 Aug 2011 13:43:27 -0700 (PDT) Received: from localhost.localdomain (109-93-49-6.dynamic.isp.telekom.rs [109.93.49.6]) by mx.google.com with ESMTPS id x1sm3357625fah.0.2011.08.04.13.43.25 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 04 Aug 2011 13:43:26 -0700 (PDT) From: Bojan Prtvar To: jkosina@suse.cz Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Bojan Prtvar Subject: [PATCH 1/2] HID: kfree() NULL pointer cleanup Date: Thu, 4 Aug 2011 22:42:54 +0200 Message-Id: <1312490574-14804-1-git-send-email-prtvar.b@gmail.com> X-Mailer: git-send-email 1.7.1 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Thu, 04 Aug 2011 20:47:47 +0000 (UTC) Checking for NULL pointers before kfree() is redundant. Signed-off-by: Bojan Prtvar --- drivers/hid/hid-prodikeys.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-prodikeys.c b/drivers/hid/hid-prodikeys.c index 158b389..62f95d4 100644 --- a/drivers/hid/hid-prodikeys.c +++ b/drivers/hid/hid-prodikeys.c @@ -849,9 +849,7 @@ static int pk_probe(struct hid_device *hdev, const struct hid_device_id *id) err_stop: hid_hw_stop(hdev); err_free: - if (pm != NULL) - kfree(pm); - + kfree(pm); kfree(pk); return ret; }