diff mbox

hid-debug: Show application usage for each collection.

Message ID 1313451542-79316-1-git-send-email-jeffbrown@android.com (mailing list archive)
State New, archived
Delegated to: Jiri Kosina
Headers show

Commit Message

Jeff Brown Aug. 15, 2011, 11:39 p.m. UTC
From: Jeff Brown <jeffbrown@android.com>

Signed-off-by: jeffbrown@android.com
---
 drivers/hid/hid-debug.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

Comments

Benjamin Tissoires Aug. 16, 2011, 7:32 a.m. UTC | #1
On Tue, Aug 16, 2011 at 01:39,  <jeffbrown@android.com> wrote:
> From: Jeff Brown <jeffbrown@android.com>

Reviewed-by: Benjamin Tissoires <benjamin.tissoires@logitech.com>

>
> Signed-off-by: jeffbrown@android.com
> ---
>  drivers/hid/hid-debug.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
> index bae4874..9a243ca 100644
> --- a/drivers/hid/hid-debug.c
> +++ b/drivers/hid/hid-debug.c
> @@ -450,6 +450,11 @@ void hid_dump_field(struct hid_field *field, int n, struct seq_file *f) {
>                seq_printf(f, "Logical(");
>                hid_resolv_usage(field->logical, f); seq_printf(f, ")\n");
>        }
> +       if (field->application) {
> +               tab(n, f);
> +               seq_printf(f, "Application(");
> +               hid_resolv_usage(field->application, f); seq_printf(f, ")\n");
> +       }
>        tab(n, f); seq_printf(f, "Usage(%d)\n", field->maxusage);
>        for (j = 0; j < field->maxusage; j++) {
>                tab(n+2, f); hid_resolv_usage(field->usage[j].hid, f); seq_printf(f, "\n");
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jiri Kosina Aug. 16, 2011, 9:37 a.m. UTC | #2
On Tue, 16 Aug 2011, Benjamin Tissoires wrote:

> > From: Jeff Brown <jeffbrown@android.com>
> 
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@logitech.com>

Applied, thanks.
Jeff Brown Aug. 24, 2011, 6:58 p.m. UTC | #3
On Tue, Aug 16, 2011 at 12:32 AM, Benjamin Tissoires
<benjamin.tissoires@gmail.com> wrote:
> On Tue, Aug 16, 2011 at 01:39,  <jeffbrown@android.com> wrote:
>> From: Jeff Brown <jeffbrown@android.com>
>
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@logitech.com>

Just a friendly ping.

Do I need to do anything more on this, or on the other patch to hid-multitouch?

>> Signed-off-by: jeffbrown@android.com
>> ---
>>  drivers/hid/hid-debug.c |    5 +++++
>>  1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
>> index bae4874..9a243ca 100644
>> --- a/drivers/hid/hid-debug.c
>> +++ b/drivers/hid/hid-debug.c
>> @@ -450,6 +450,11 @@ void hid_dump_field(struct hid_field *field, int n, struct seq_file *f) {
>>                seq_printf(f, "Logical(");
>>                hid_resolv_usage(field->logical, f); seq_printf(f, ")\n");
>>        }
>> +       if (field->application) {
>> +               tab(n, f);
>> +               seq_printf(f, "Application(");
>> +               hid_resolv_usage(field->application, f); seq_printf(f, ")\n");
>> +       }
>>        tab(n, f); seq_printf(f, "Usage(%d)\n", field->maxusage);
>>        for (j = 0; j < field->maxusage; j++) {
>>                tab(n+2, f); hid_resolv_usage(field->usage[j].hid, f); seq_printf(f, "\n");
>> --
>> 1.7.0.4
>>
>> --
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jiri Kosina Aug. 24, 2011, 7:04 p.m. UTC | #4
On Wed, 24 Aug 2011, Jeffrey Brown wrote:

> >> From: Jeff Brown <jeffbrown@android.com>
> >
> > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@logitech.com>
> 
> Just a friendly ping.
> 
> Do I need to do anything more on this, or on the other patch to 
> hid-multitouch?

Hi Jeffrey,

it's queued in my tree, 'upstream' branch.

[1] http://git.kernel.org/?p=linux/kernel/git/jikos/hid.git;a=summary
Jeff Brown Aug. 24, 2011, 7:05 p.m. UTC | #5
On Wed, Aug 24, 2011 at 12:04 PM, Jiri Kosina <jkosina@suse.cz> wrote:
> Hi Jeffrey,
>
> it's queued in my tree, 'upstream' branch.
>
> [1] http://git.kernel.org/?p=linux/kernel/git/jikos/hid.git;a=summary

Great!  Thanks.

Jeff.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
index bae4874..9a243ca 100644
--- a/drivers/hid/hid-debug.c
+++ b/drivers/hid/hid-debug.c
@@ -450,6 +450,11 @@  void hid_dump_field(struct hid_field *field, int n, struct seq_file *f) {
 		seq_printf(f, "Logical(");
 		hid_resolv_usage(field->logical, f); seq_printf(f, ")\n");
 	}
+	if (field->application) {
+		tab(n, f);
+		seq_printf(f, "Application(");
+		hid_resolv_usage(field->application, f); seq_printf(f, ")\n");
+	}
 	tab(n, f); seq_printf(f, "Usage(%d)\n", field->maxusage);
 	for (j = 0; j < field->maxusage; j++) {
 		tab(n+2, f); hid_resolv_usage(field->usage[j].hid, f); seq_printf(f, "\n");