| Message ID | 1347428349.14558.1.camel@phoenix (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Jiri Kosina |
| Headers | show |
Hi Axel, On Wed, 12 Sep 2012 13:39:09 Axel Lin <axel.lin@gmail.com> wrote: > Seems this is a left over of commit 4382973 > "workqueue: deprecate flush[_delayed]_work_sync()" It is, see https://lkml.org/lkml/2012/9/6/297 for a previous patch. This should fix itself when Linus merges Tejun's workqueue changes and picolcd changes. Bruno > This fixes below build warning: > > CC [M] drivers/hid/hid-picolcd_fb.o > drivers/hid/hid-picolcd_fb.c: In function 'picolcd_exit_framebuffer': > drivers/hid/hid-picolcd_fb.c:611:2: warning: 'flush_delayed_work_sync' is deprecated (declared at include/linux/workqueue.h:454) [-Wdeprecated-declarations] > > Signed-off-by: Axel Lin <axel.lin@gmail.com> > Cc: Tejun Heo <tj@kernel.org> > --- > drivers/hid/hid-picolcd_fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c > index 0008a51..eb00357 100644 > --- a/drivers/hid/hid-picolcd_fb.c > +++ b/drivers/hid/hid-picolcd_fb.c > @@ -608,7 +608,7 @@ void picolcd_exit_framebuffer(struct picolcd_data *data) > /* make sure there is no running update - thus that fbdata->picolcd > * once obtained under lock is guaranteed not to get free() under > * the feet of the deferred work */ > - flush_delayed_work_sync(&info->deferred_work); > + flush_delayed_work(&info->deferred_work); > > data->fb_info = NULL; > unregister_framebuffer(info); -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c index 0008a51..eb00357 100644 --- a/drivers/hid/hid-picolcd_fb.c +++ b/drivers/hid/hid-picolcd_fb.c @@ -608,7 +608,7 @@ void picolcd_exit_framebuffer(struct picolcd_data *data) /* make sure there is no running update - thus that fbdata->picolcd * once obtained under lock is guaranteed not to get free() under * the feet of the deferred work */ - flush_delayed_work_sync(&info->deferred_work); + flush_delayed_work(&info->deferred_work); data->fb_info = NULL; unregister_framebuffer(info);
Seems this is a left over of commit 4382973 "workqueue: deprecate flush[_delayed]_work_sync()" This fixes below build warning: CC [M] drivers/hid/hid-picolcd_fb.o drivers/hid/hid-picolcd_fb.c: In function 'picolcd_exit_framebuffer': drivers/hid/hid-picolcd_fb.c:611:2: warning: 'flush_delayed_work_sync' is deprecated (declared at include/linux/workqueue.h:454) [-Wdeprecated-declarations] Signed-off-by: Axel Lin <axel.lin@gmail.com> Cc: Tejun Heo <tj@kernel.org> --- drivers/hid/hid-picolcd_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)