diff mbox

Input: edt-ft5x06 - return -EFAULT on copy_to_user() error

Message ID 1347858772.8376.1.camel@phoenix (mailing list archive)
State New, archived
Headers show

Commit Message

axel lin Sept. 17, 2012, 5:12 a.m. UTC 
copy_to_user() returns the number of bytes remaining, but we want a
negative error code here.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/input/touchscreen/edt-ft5x06.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff mbox

Patch

diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
index bf00b32..02e9dab 100644
--- a/drivers/input/touchscreen/edt-ft5x06.c
+++ b/drivers/input/touchscreen/edt-ft5x06.c
@@ -567,7 +567,9 @@  static ssize_t edt_ft5x06_debugfs_raw_data_read(struct file *file,
 
 	read = min_t(size_t, count, tsdata->raw_bufsize - *off);
 	error = copy_to_user(buf, tsdata->raw_buffer + *off, read);
-	if (!error)
+	if (error)
+		error = -EFAULT;
+	else
 		*off += read;
 out:
 	mutex_unlock(&tsdata->mutex);