From patchwork Mon Sep 17 06:34:05 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Achatz X-Patchwork-Id: 1465461 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 89A67DFFFF for ; Mon, 17 Sep 2012 06:35:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750919Ab2IQGeI (ORCPT ); Mon, 17 Sep 2012 02:34:08 -0400 Received: from mail-in-13.arcor-online.net ([151.189.21.53]:39368 "EHLO mail-in-13.arcor-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750733Ab2IQGeH (ORCPT ); Mon, 17 Sep 2012 02:34:07 -0400 Received: from mail-in-17-z2.arcor-online.net (mail-in-17-z2.arcor-online.net [151.189.8.34]) by mx.arcor.de (Postfix) with ESMTP id 8B6B6212626; Mon, 17 Sep 2012 08:34:06 +0200 (CEST) Received: from mail-in-08.arcor-online.net (mail-in-08.arcor-online.net [151.189.21.48]) by mail-in-17-z2.arcor-online.net (Postfix) with ESMTP id 8547410C038; Mon, 17 Sep 2012 08:34:06 +0200 (CEST) Received: from [192.168.0.7] (dslb-092-075-166-003.pools.arcor-ip.net [92.75.166.3]) (Authenticated sender: screamingfist@arcor.de) by mail-in-08.arcor-online.net (Postfix) with ESMTPSA id 508E73AE9A0; Mon, 17 Sep 2012 08:34:06 +0200 (CEST) X-DKIM: Sendmail DKIM Filter v2.8.2 mail-in-08.arcor-online.net 508E73AE9A0 Subject: [PATCH/RFC] HID: roccat: removing devices from blacklist From: Stefan Achatz Reply-To: erazor_de@users.sourceforge.net To: Jiri Kosina , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 17 Sep 2012 08:34:05 +0200 Message-ID: <1347863645.2606.66.camel@neuromancer.tessier-ashpool> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 (2.30.3-1.fc13) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org I would suggest to remove the Roccat devices from generic drivers blacklist. Some Distros tend to have kernels without the special modules compiled, which prevents users of these devices to work with live images or installers. The Roccat devices work flawlessly with generic drivers (except the old Kone with a small glitch). My modules are only needed when using my tools for configuration and extended capabilities. These tools come with udev rules which transfer the control from generic driver to externally compiled modules if installed. I have to update these udev rules for the change from generic-usb to hid-generic anyway, so I would add a rule to also handle the kernel contained modules. Signed-off-by: Stefan Achatz --- drivers/hid/hid-core.c | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 8bcd168..4f2ba5a 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -1627,14 +1627,6 @@ static const struct hid_device_id hid_have_special_driver[] = { { HID_USB_DEVICE(USB_VENDOR_ID_ORTEK, USB_DEVICE_ID_ORTEK_WKB2000) }, { HID_USB_DEVICE(USB_VENDOR_ID_PETALYNX, USB_DEVICE_ID_PETALYNX_MAXTER_REMOTE) }, { HID_USB_DEVICE(USB_VENDOR_ID_PRIMAX, USB_DEVICE_ID_PRIMAX_KEYBOARD) }, - { HID_USB_DEVICE(USB_VENDOR_ID_ROCCAT, USB_DEVICE_ID_ROCCAT_KONE) }, - { HID_USB_DEVICE(USB_VENDOR_ID_ROCCAT, USB_DEVICE_ID_ROCCAT_ARVO) }, - { HID_USB_DEVICE(USB_VENDOR_ID_ROCCAT, USB_DEVICE_ID_ROCCAT_ISKU) }, - { HID_USB_DEVICE(USB_VENDOR_ID_ROCCAT, USB_DEVICE_ID_ROCCAT_KONEPLUS) }, - { HID_USB_DEVICE(USB_VENDOR_ID_ROCCAT, USB_DEVICE_ID_ROCCAT_KOVAPLUS) }, - { HID_USB_DEVICE(USB_VENDOR_ID_ROCCAT, USB_DEVICE_ID_ROCCAT_PYRA_WIRED) }, - { HID_USB_DEVICE(USB_VENDOR_ID_ROCCAT, USB_DEVICE_ID_ROCCAT_PYRA_WIRELESS) }, - { HID_USB_DEVICE(USB_VENDOR_ID_ROCCAT, USB_DEVICE_ID_ROCCAT_SAVU) }, { HID_USB_DEVICE(USB_VENDOR_ID_SAITEK, USB_DEVICE_ID_SAITEK_PS1000) }, { HID_USB_DEVICE(USB_VENDOR_ID_SAMSUNG, USB_DEVICE_ID_SAMSUNG_IR_REMOTE) }, { HID_USB_DEVICE(USB_VENDOR_ID_SAMSUNG, USB_DEVICE_ID_SAMSUNG_WIRELESS_KBD_MOUSE) },