| Message ID | 1349782278-9023-2-git-send-email-shubhrajyoti@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, 9 Oct 2012 17:01:18 +0530, Shubhrajyoti D wrote: > Convert the struct i2c_msg initialization to C99 format. This makes > maintaining and editing the code simpler. Also helps once other fields > like transferred are added in future. > > Thanks to Julia Lawall <julia.lawall@lip6.fr> for automating the conversion > > Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com> > --- > drivers/input/touchscreen/cy8ctmg110_ts.c | 14 ++++++++++++-- > 1 files changed, 12 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/touchscreen/cy8ctmg110_ts.c b/drivers/input/touchscreen/cy8ctmg110_ts.c > index 464f1bf..f4cfedf 100644 > --- a/drivers/input/touchscreen/cy8ctmg110_ts.c > +++ b/drivers/input/touchscreen/cy8ctmg110_ts.c > @@ -99,9 +99,19 @@ static int cy8ctmg110_read_regs(struct cy8ctmg110 *tsc, > int ret; > struct i2c_msg msg[2] = { > /* first write slave position to i2c devices */ > - { client->addr, 0, 1, &cmd }, > + { > + .addr = client->addr, > + .flags = 0, You can actually omit fields with value 0, that's one of the benefits of C99-style struct initialization. > + .len = 1, > + .buf = &cmd > + }, > /* Second read data from position */ > - { client->addr, I2C_M_RD, len, data } > + { > + .addr = client->addr, > + .flags = I2C_M_RD, > + .len = len, > + .buf = data > + } > }; > > ret = i2c_transfer(client->adapter, msg, 2); Acked-by: Jean Delvare <khali@linux-fr.org>
diff --git a/drivers/input/touchscreen/cy8ctmg110_ts.c b/drivers/input/touchscreen/cy8ctmg110_ts.c index 464f1bf..f4cfedf 100644 --- a/drivers/input/touchscreen/cy8ctmg110_ts.c +++ b/drivers/input/touchscreen/cy8ctmg110_ts.c @@ -99,9 +99,19 @@ static int cy8ctmg110_read_regs(struct cy8ctmg110 *tsc, int ret; struct i2c_msg msg[2] = { /* first write slave position to i2c devices */ - { client->addr, 0, 1, &cmd }, + { + .addr = client->addr, + .flags = 0, + .len = 1, + .buf = &cmd + }, /* Second read data from position */ - { client->addr, I2C_M_RD, len, data } + { + .addr = client->addr, + .flags = I2C_M_RD, + .len = len, + .buf = data + } }; ret = i2c_transfer(client->adapter, msg, 2);
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Thanks to Julia Lawall <julia.lawall@lip6.fr> for automating the conversion Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com> --- drivers/input/touchscreen/cy8ctmg110_ts.c | 14 ++++++++++++-- 1 files changed, 12 insertions(+), 2 deletions(-)